aboutsummaryrefslogtreecommitdiffstats
path: root/fs/cifs
diff options
context:
space:
mode:
authorDaniel Borkmann <dborkman@redhat.com>2014-02-17 12:11:11 +0100
committerBen Hutchings <ben@decadent.org.uk>2014-04-02 00:59:01 +0100
commitffbd2b62c349e1541513883b25bcecc2fa238e60 (patch)
tree23725a643538b15f007aa2c48f02ccb42464721e /fs/cifs
parent22bff3616cf35c5e19da9169f560e4336020899c (diff)
downloadkernel_samsung_smdk4412-ffbd2b62c349e1541513883b25bcecc2fa238e60.zip
kernel_samsung_smdk4412-ffbd2b62c349e1541513883b25bcecc2fa238e60.tar.gz
kernel_samsung_smdk4412-ffbd2b62c349e1541513883b25bcecc2fa238e60.tar.bz2
net: sctp: fix sctp_connectx abi for ia32 emulation/compat mode
[ Upstream commit ffd5939381c609056b33b7585fb05a77b4c695f3 ] SCTP's sctp_connectx() abi breaks for 64bit kernels compiled with 32bit emulation (e.g. ia32 emulation or x86_x32). Due to internal usage of 'struct sctp_getaddrs_old' which includes a struct sockaddr pointer, sizeof(param) check will always fail in kernel as the structure in 64bit kernel space is 4bytes larger than for user binaries compiled in 32bit mode. Thus, applications making use of sctp_connectx() won't be able to run under such circumstances. Introduce a compat interface in the kernel to deal with such situations by using a 'struct compat_sctp_getaddrs_old' structure where user data is copied into it, and then sucessively transformed into a 'struct sctp_getaddrs_old' structure with the help of compat_ptr(). That fixes sctp_connectx() abi without any changes needed in user space, and lets the SCTP test suite pass when compiled in 32bit and run on 64bit kernels. Fixes: f9c67811ebc0 ("sctp: Fix regression introduced by new sctp_connectx api") Signed-off-by: Daniel Borkmann <dborkman@redhat.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: Vlad Yasevich <vyasevich@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'fs/cifs')
0 files changed, 0 insertions, 0 deletions