diff options
| author | Jan Kara <jack@suse.cz> | 2013-01-30 00:28:01 +0100 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-03-06 03:24:11 +0000 |
| commit | 53edcd239765c93597d079ac98858916d1f724f4 (patch) | |
| tree | 0d2d1b589312b4a05b6363174f8fc525f44ae0cb /fs/direct-io.c | |
| parent | 668f6e6afe49c6c7d16bb99f2d9e2baa4a14fb44 (diff) | |
| download | kernel_samsung_smdk4412-53edcd239765c93597d079ac98858916d1f724f4.zip kernel_samsung_smdk4412-53edcd239765c93597d079ac98858916d1f724f4.tar.gz kernel_samsung_smdk4412-53edcd239765c93597d079ac98858916d1f724f4.tar.bz2 | |
fs: Fix possible use-after-free with AIO
commit 54c807e71d5ac59dee56c685f2b66e27cd54c475 upstream.
Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.
CC: Christoph Hellwig <hch@infradead.org>
CC: Jens Axboe <axboe@kernel.dk>
CC: Jeff Moyer <jmoyer@redhat.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'fs/direct-io.c')
| -rw-r--r-- | fs/direct-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/direct-io.c b/fs/direct-io.c index d740ab6..ac401d2 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -304,9 +304,9 @@ static ssize_t dio_complete(struct dio *dio, loff_t offset, ssize_t ret, bool is dio->end_io(dio->iocb, offset, transferred, dio->private, ret, is_async); } else { + inode_dio_done(dio->inode); if (is_async) aio_complete(dio->iocb, ret, 0); - inode_dio_done(dio->inode); } return ret; |