diff options
| author | Sergio Gelato <Sergio.Gelato@astro.su.se> | 2014-09-24 08:47:24 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-11-05 20:27:49 +0000 |
| commit | 5b6da64a7e447eadce0d3e201c0fd6f540f2ec93 (patch) | |
| tree | 605220d2cbb6f2d41e86781259a49bfa43cc2140 /fs/nfsd | |
| parent | 4b808fd2ef61f6d8bdaabe30b67da3f5ea9948bf (diff) | |
| download | kernel_samsung_smdk4412-5b6da64a7e447eadce0d3e201c0fd6f540f2ec93.zip kernel_samsung_smdk4412-5b6da64a7e447eadce0d3e201c0fd6f540f2ec93.tar.gz kernel_samsung_smdk4412-5b6da64a7e447eadce0d3e201c0fd6f540f2ec93.tar.bz2 | |
nfsd: Fix ACL null pointer deref
BugLink: http://bugs.launchpad.net/bugs/1348670
Fix regression introduced in pre-3.14 kernels by cherry-picking
aa07c713ecfc0522916f3cd57ac628ea6127c0ec
(NFSD: Call ->set_acl with a NULL ACL structure if no entries).
The affected code was removed in 3.14 by commit
4ac7249ea5a0ceef9f8269f63f33cc873c3fac61
(nfsd: use get_acl and ->set_acl).
The ->set_acl methods are already able to cope with a NULL argument.
Signed-off-by: Sergio Gelato <Sergio.Gelato@astro.su.se>
[bwh: Rewrite the subject]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'fs/nfsd')
| -rw-r--r-- | fs/nfsd/vfs.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 11e1888..e2e7914 100644 --- a/fs/nfsd/vfs.c +++ b/fs/nfsd/vfs.c @@ -508,6 +508,9 @@ set_nfsv4_acl_one(struct dentry *dentry, struct posix_acl *pacl, char *key) char *buf = NULL; int error = 0; + if (!pacl) + return vfs_setxattr(dentry, key, NULL, 0, 0); + buflen = posix_acl_xattr_size(pacl->a_count); buf = kmalloc(buflen, GFP_KERNEL); error = -ENOMEM; |