diff options
| author | Filipe Manana <fdmanana@suse.com> | 2015-06-13 06:52:56 +0100 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2015-08-12 16:33:18 +0200 |
| commit | c6bbfa525c51fd10970b7cb0ed295c5e7ee27511 (patch) | |
| tree | b063ba1f84140b0214d971ab849d16c28c250e03 /fs | |
| parent | 66af8054f10b9ad1152bc05d65f0126becf320bd (diff) | |
| download | kernel_samsung_smdk4412-c6bbfa525c51fd10970b7cb0ed295c5e7ee27511.zip kernel_samsung_smdk4412-c6bbfa525c51fd10970b7cb0ed295c5e7ee27511.tar.gz kernel_samsung_smdk4412-c6bbfa525c51fd10970b7cb0ed295c5e7ee27511.tar.bz2 | |
Btrfs: use kmem_cache_free when freeing entry in inode cache
commit c3f4a1685bb87e59c886ee68f7967eae07d4dffa upstream.
The free space entries are allocated using kmem_cache_zalloc(),
through __btrfs_add_free_space(), therefore we should use
kmem_cache_free() and not kfree() to avoid any confusion and
any potential problem. Looking at the kfree() definition at
mm/slab.c it has the following comment:
/*
* (...)
*
* Don't free memory not originally allocated by kmalloc()
* or you will run into trouble.
*/
So better be safe and use kmem_cache_free().
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Chris Mason <clm@fb.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/inode-map.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c index a1fee6f..41eac47 100644 --- a/fs/btrfs/inode-map.c +++ b/fs/btrfs/inode-map.c @@ -269,7 +269,7 @@ void btrfs_unpin_free_ino(struct btrfs_root *root) __btrfs_add_free_space(ctl, info->offset, count); free: rb_erase(&info->offset_index, rbroot); - kfree(info); + kmem_cache_free(btrfs_free_space_cachep, info); } } |