diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2013-06-28 02:37:42 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-07-28 16:18:35 -0700 |
| commit | f4ded0dfedaa8cab85c67fd5db5b9eef9f981c15 (patch) | |
| tree | c8d2678715d194687e1885dcbeedf8a62b41f2a8 /include | |
| parent | 3a35ccb6009ad66aa21f821a3c99ca0374b59a28 (diff) | |
| download | kernel_samsung_smdk4412-f4ded0dfedaa8cab85c67fd5db5b9eef9f981c15.zip kernel_samsung_smdk4412-f4ded0dfedaa8cab85c67fd5db5b9eef9f981c15.tar.gz kernel_samsung_smdk4412-f4ded0dfedaa8cab85c67fd5db5b9eef9f981c15.tar.bz2 | |
neighbour: fix a race in neigh_destroy()
[ Upstream commit c9ab4d85de222f3390c67aedc9c18a50e767531e ]
There is a race in neighbour code, because neigh_destroy() uses
skb_queue_purge(&neigh->arp_queue) without holding neighbour lock,
while other parts of the code assume neighbour rwlock is what
protects arp_queue
Convert all skb_queue_purge() calls to the __skb_queue_purge() variant
Use __skb_queue_head_init() instead of skb_queue_head_init()
to make clear we do not use arp_queue.lock
And hold neigh->lock in neigh_destroy() to close the race.
Reported-by: Joe Jin <joe.jin@oracle.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions