diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2013-01-21 20:48:17 +0100 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-02-20 03:15:30 +0000 |
| commit | 8957028bd89221048c784d524ee42513356fc822 (patch) | |
| tree | c31153c97415cb04b0c4bf8ab71ab58226c28725 /kernel/sched.c | |
| parent | f224540e9fc7be42e1867f1e4967889b29073abb (diff) | |
| download | kernel_samsung_smdk4412-8957028bd89221048c784d524ee42513356fc822.zip kernel_samsung_smdk4412-8957028bd89221048c784d524ee42513356fc822.tar.gz kernel_samsung_smdk4412-8957028bd89221048c784d524ee42513356fc822.tar.bz2 | |
wake_up_process() should be never used to wakeup a TASK_STOPPED/TRACED task
commit 9067ac85d533651b98c2ff903182a20cbb361fcb upstream.
wake_up_process() should never wakeup a TASK_STOPPED/TRACED task.
Change it to use TASK_NORMAL and add the WARN_ON().
TASK_ALL has no other users, probably can be killed.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: adjust filename]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'kernel/sched.c')
| -rw-r--r-- | kernel/sched.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/sched.c b/kernel/sched.c index fcc893f..eeeec4e 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -2924,7 +2924,8 @@ out: */ int wake_up_process(struct task_struct *p) { - return try_to_wake_up(p, TASK_ALL, 0); + WARN_ON(task_is_stopped_or_traced(p)); + return try_to_wake_up(p, TASK_NORMAL, 0); } EXPORT_SYMBOL(wake_up_process); |