diff options
| author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2012-05-11 17:31:26 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-08-02 14:37:38 +0100 |
| commit | 1217fd87cfd53eab752837f19386e0a5594719d9 (patch) | |
| tree | 50c6a3748c32de07750c9a2180516192b2562260 /kernel/sched_fair.c | |
| parent | 2b2c3e47f0a98261d5d6ab7f61420fb4e479b472 (diff) | |
| download | kernel_samsung_smdk4412-1217fd87cfd53eab752837f19386e0a5594719d9.zip kernel_samsung_smdk4412-1217fd87cfd53eab752837f19386e0a5594719d9.tar.gz kernel_samsung_smdk4412-1217fd87cfd53eab752837f19386e0a5594719d9.tar.bz2 | |
sched/nohz: Fix rq->cpu_load[] calculations
commit 556061b00c9f2fd6a5524b6bde823ef12f299ecf upstream.
While investigating why the load-balancer did funny I found that the
rq->cpu_load[] tables were completely screwy.. a bit more digging
revealed that the updates that got through were missing ticks followed
by a catchup of 2 ticks.
The catchup assumes the cpu was idle during that time (since only nohz
can cause missed ticks and the machine is idle etc..) this means that
esp. the higher indices were significantly lower than they ought to
be.
The reason for this is that its not correct to compare against jiffies
on every jiffy on any other cpu than the cpu that updates jiffies.
This patch cludges around it by only doing the catch-up stuff from
nohz_idle_balance() and doing the regular stuff unconditionally from
the tick.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: pjt@google.com
Cc: Venkatesh Pallipadi <venki@google.com>
Link: http://lkml.kernel.org/n/tip-tp4kj18xdd5aj4vvj0qg55s2@git.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
[bwh: Backported to 3.2: adjust filenames and context; keep functions static]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'kernel/sched_fair.c')
| -rw-r--r-- | kernel/sched_fair.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index 8a39fa3..66e4576 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -4735,7 +4735,7 @@ static void nohz_idle_balance(int this_cpu, enum cpu_idle_type idle) raw_spin_lock_irq(&this_rq->lock); update_rq_clock(this_rq); - update_cpu_load(this_rq); + update_idle_cpu_load(this_rq); raw_spin_unlock_irq(&this_rq->lock); rebalance_domains(balance_cpu, CPU_IDLE); |