diff options
| author | Zhu Yanhai <gaoyang.zyh@taobao.com> | 2013-01-08 12:56:52 +0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-09-10 01:57:04 +0100 |
| commit | bb8d7bf7a9f112926e8b32c8c127136dea47f03f (patch) | |
| tree | d26c9a322c3a1602b82069fb088aaf9d82fee40a /kernel/sched_fair.c | |
| parent | d2f1837b4bfeca92b188de170a6abd1ee4514dbc (diff) | |
| download | kernel_samsung_smdk4412-bb8d7bf7a9f112926e8b32c8c127136dea47f03f.zip kernel_samsung_smdk4412-bb8d7bf7a9f112926e8b32c8c127136dea47f03f.tar.gz kernel_samsung_smdk4412-bb8d7bf7a9f112926e8b32c8c127136dea47f03f.tar.bz2 | |
sched: Fix the broken sched_rr_get_interval()
commit a59f4e079d19464eebb9b06513a1d4f55fdae5ba upstream.
The caller of sched_sliced() should pass se.cfs_rq and se as the
arguments, however in sched_rr_get_interval() we gave it
rq.cfs_rq and se, which made the following computation obviously
wrong.
The change was introduced by commit:
77034937dc45 sched: fix crash in sys_sched_rr_get_interval()
... 5 years ago, while it had been the correct 'cfs_rq_of' before
the commit. The change seems to be irrelevant to the commit
msg, which was to return a 0 timeslice for tasks that are on an
idle runqueue. So I believe that was just a plain typo.
Signed-off-by: Zhu Yanhai <gaoyang.zyh@taobao.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Turner <pjt@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1357621012-15039-1-git-send-email-gaoyang.zyh@taobao.com
[ Since this is an ABI and an old bug, we'll test this via a
slow upstream route, to hopefully discover any app breakage. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'kernel/sched_fair.c')
| -rw-r--r-- | kernel/sched_fair.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index 66e4576..59474c5 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -5033,7 +5033,7 @@ static unsigned int get_rr_interval_fair(struct rq *rq, struct task_struct *task * idle runqueue: */ if (rq->cfs.load.weight) - rr_interval = NS_TO_JIFFIES(sched_slice(&rq->cfs, se)); + rr_interval = NS_TO_JIFFIES(sched_slice(cfs_rq_of(se), se)); return rr_interval; } |