diff options
author | Wengang Wang <wen.gang.wang@oracle.com> | 2015-07-06 14:35:11 +0800 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2015-08-12 16:33:21 +0200 |
commit | 67164064f2559098e72ecd23096541cf8fb22a81 (patch) | |
tree | a7a231a638cb0923c152c3860b1580a1245e966c /net/atm | |
parent | ea1f670125b9047bc30f7fd42231b05315dffd58 (diff) | |
download | kernel_samsung_smdk4412-67164064f2559098e72ecd23096541cf8fb22a81.zip kernel_samsung_smdk4412-67164064f2559098e72ecd23096541cf8fb22a81.tar.gz kernel_samsung_smdk4412-67164064f2559098e72ecd23096541cf8fb22a81.tar.bz2 |
rds: rds_ib_device.refcount overflow
commit 4fabb59449aa44a585b3603ffdadd4c5f4d0c033 upstream.
Fixes: 3e0249f9c05c ("RDS/IB: add refcount tracking to struct rds_ib_device")
There lacks a dropping on rds_ib_device.refcount in case rds_ib_alloc_fmr
failed(mr pool running out). this lead to the refcount overflow.
A complain in line 117(see following) is seen. From vmcore:
s_ib_rdma_mr_pool_depleted is 2147485544 and rds_ibdev->refcount is -2147475448.
That is the evidence the mr pool is used up. so rds_ib_alloc_fmr is very likely
to return ERR_PTR(-EAGAIN).
115 void rds_ib_dev_put(struct rds_ib_device *rds_ibdev)
116 {
117 BUG_ON(atomic_read(&rds_ibdev->refcount) <= 0);
118 if (atomic_dec_and_test(&rds_ibdev->refcount))
119 queue_work(rds_wq, &rds_ibdev->free_work);
120 }
fix is to drop refcount when rds_ib_alloc_fmr failed.
Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
Reviewed-by: Haggai Eran <haggaie@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'net/atm')
0 files changed, 0 insertions, 0 deletions