diff options
| author | Eric Leblond <eric@regit.org> | 2012-08-16 22:02:58 +0000 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-09-19 15:04:55 +0100 |
| commit | 1b048ea7242555f91066228ef136ba299f4ae567 (patch) | |
| tree | 3fc877490a9c1aa9034a4166306f0a60da72916f /net/core/dev.c | |
| parent | daf8fa93325e55ec605c4e725e6dc07d63d0d5c1 (diff) | |
| download | kernel_samsung_smdk4412-1b048ea7242555f91066228ef136ba299f4ae567.zip kernel_samsung_smdk4412-1b048ea7242555f91066228ef136ba299f4ae567.tar.gz kernel_samsung_smdk4412-1b048ea7242555f91066228ef136ba299f4ae567.tar.bz2 | |
af_packet: don't emit packet on orig fanout group
[ Upstream commit c0de08d04215031d68fa13af36f347a6cfa252ca ]
If a packet is emitted on one socket in one group of fanout sockets,
it is transmitted again. It is thus read again on one of the sockets
of the fanout group. This result in a loop for software which
generate packets when receiving one.
This retransmission is not the intended behavior: a fanout group
must behave like a single socket. The packet should not be
transmitted on a socket if it originates from a socket belonging
to the same fanout group.
This patch fixes the issue by changing the transmission check to
take fanout group info account.
Reported-by: Aleksandr Kotov <a1k@mail.ru>
Signed-off-by: Eric Leblond <eric@regit.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'net/core/dev.c')
| -rw-r--r-- | net/core/dev.c | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 75da76d..832ba6d 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1631,6 +1631,19 @@ static inline int deliver_skb(struct sk_buff *skb, return pt_prev->func(skb, skb->dev, pt_prev, orig_dev); } +static inline bool skb_loop_sk(struct packet_type *ptype, struct sk_buff *skb) +{ + if (ptype->af_packet_priv == NULL) + return false; + + if (ptype->id_match) + return ptype->id_match(ptype, skb->sk); + else if ((struct sock *)ptype->af_packet_priv == skb->sk) + return true; + + return false; +} + /* * Support routine. Sends outgoing frames to any network * taps currently in use. @@ -1648,8 +1661,7 @@ static void dev_queue_xmit_nit(struct sk_buff *skb, struct net_device *dev) * they originated from - MvS (miquels@drinkel.ow.org) */ if ((ptype->dev == dev || !ptype->dev) && - (ptype->af_packet_priv == NULL || - (struct sock *)ptype->af_packet_priv != skb->sk)) { + (!skb_loop_sk(ptype, skb))) { if (pt_prev) { deliver_skb(skb2, pt_prev, skb->dev); pt_prev = ptype; |