diff options
| author | Eric Dumazet <edumazet@google.com> | 2012-06-13 09:45:16 +0000 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-07-25 04:11:40 +0100 |
| commit | dcf42d8ca45ca2009ead5cfae84c1c0de0a0af72 (patch) | |
| tree | e394ade7bc29ed9f5f2fbddb07099d3f8d1d856a /net/core/dev.c | |
| parent | caac50847fd87dcc587181e3af3bd0aebf49964e (diff) | |
| download | kernel_samsung_smdk4412-dcf42d8ca45ca2009ead5cfae84c1c0de0a0af72.zip kernel_samsung_smdk4412-dcf42d8ca45ca2009ead5cfae84c1c0de0a0af72.tar.gz kernel_samsung_smdk4412-dcf42d8ca45ca2009ead5cfae84c1c0de0a0af72.tar.bz2 | |
bnx2x: fix panic when TX ring is full
commit bc14786a100cc6a81cd060e8031ec481241b418c upstream.
There is a off by one error in the minimal number of BD in
bnx2x_start_xmit() and bnx2x_tx_int() before stopping/resuming tx queue.
A full size GSO packet, with data included in skb->head really needs
(MAX_SKB_FRAGS + 4) BDs, because of bnx2x_tx_split()
This error triggers if BQL is disabled and heavy TCP transmit traffic
occurs.
bnx2x_tx_split() definitely can be called, remove a wrong comment.
Reported-by: Tomas Hruby <thruby@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eilon Greenstein <eilong@broadcom.com>
Cc: Yaniv Rosner <yanivr@broadcom.com>
Cc: Merav Sicron <meravs@broadcom.com>
Cc: Tom Herbert <therbert@google.com>
Cc: Robert Evans <evansr@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'net/core/dev.c')
0 files changed, 0 insertions, 0 deletions