diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-05-15 23:57:10 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-15 23:57:10 -0700 |
| commit | 3b098e2d7c693796cc4dffb07caa249fc0f70771 (patch) | |
| tree | 586c4f5dc57988ade175ffc7e4b6d0261b12e166 /net/core/sysctl_net_core.c | |
| parent | a1aa3483041bd3691c7f029272ccef4ce70bd957 (diff) | |
| download | kernel_samsung_smdk4412-3b098e2d7c693796cc4dffb07caa249fc0f70771.zip kernel_samsung_smdk4412-3b098e2d7c693796cc4dffb07caa249fc0f70771.tar.gz kernel_samsung_smdk4412-3b098e2d7c693796cc4dffb07caa249fc0f70771.tar.bz2 | |
net: Consistent skb timestamping
With RPS inclusion, skb timestamping is not consistent in RX path.
If netif_receive_skb() is used, its deferred after RPS dispatch.
If netif_rx() is used, its done before RPS dispatch.
This can give strange tcpdump timestamps results.
I think timestamping should be done as soon as possible in the receive
path, to get meaningful values (ie timestamps taken at the time packet
was delivered by NIC driver to our stack), even if NAPI already can
defer timestamping a bit (RPS can help to reduce the gap)
Tom Herbert prefer to sample timestamps after RPS dispatch. In case
sampling is expensive (HPET/acpi_pm on x86), this makes sense.
Let admins switch from one mode to another, using a new
sysctl, /proc/sys/net/core/netdev_tstamp_prequeue
Its default value (1), means timestamps are taken as soon as possible,
before backlog queueing, giving accurate timestamps.
Setting a 0 value permits to sample timestamps when processing backlog,
after RPS dispatch, to lower the load of the pre-RPS cpu.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/sysctl_net_core.c')
| -rw-r--r-- | net/core/sysctl_net_core.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c index dcc7d25..01eee5d 100644 --- a/net/core/sysctl_net_core.c +++ b/net/core/sysctl_net_core.c @@ -122,6 +122,13 @@ static struct ctl_table net_core_table[] = { .proc_handler = proc_dointvec }, { + .procname = "netdev_tstamp_prequeue", + .data = &netdev_tstamp_prequeue, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec + }, + { .procname = "message_cost", .data = &net_ratelimit_state.interval, .maxlen = sizeof(int), |