aboutsummaryrefslogtreecommitdiffstats
path: root/net/ipv6/ip6mr.c
diff options
context:
space:
mode:
authorNeil Horman <nhorman@tuxdriver.com>2013-06-12 14:26:44 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-08-11 15:38:22 -0700
commita3c7417da6d8cdb421f6614d7ade485ead85da03 (patch)
tree9bee58415a71af8fe36750ca826c5bdaf4cbde44 /net/ipv6/ip6mr.c
parentabaf7787fb4339b1c903508624a6e819650626a2 (diff)
downloadkernel_samsung_smdk4412-a3c7417da6d8cdb421f6614d7ade485ead85da03.zip
kernel_samsung_smdk4412-a3c7417da6d8cdb421f6614d7ade485ead85da03.tar.gz
kernel_samsung_smdk4412-a3c7417da6d8cdb421f6614d7ade485ead85da03.tar.bz2
sctp: fully initialize sctp_outq in sctp_outq_init
[ Upstream commit c5c7774d7eb4397891edca9ebdf750ba90977a69 ] In commit 2f94aabd9f6c925d77aecb3ff020f1cc12ed8f86 (refactor sctp_outq_teardown to insure proper re-initalization) we modified sctp_outq_teardown to use sctp_outq_init to fully re-initalize the outq structure. Steve West recently asked me why I removed the q->error = 0 initalization from sctp_outq_teardown. I did so because I was operating under the impression that sctp_outq_init would properly initalize that value for us, but it doesn't. sctp_outq_init operates under the assumption that the outq struct is all 0's (as it is when called from sctp_association_init), but using it in __sctp_outq_teardown violates that assumption. We should do a memset in sctp_outq_init to ensure that the entire structure is in a known state there instead. Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Reported-by: "West, Steve (NSN - US/Fort Worth)" <steve.west@nsn.com> CC: Vlad Yasevich <vyasevich@gmail.com> CC: netdev@vger.kernel.org CC: davem@davemloft.net Acked-by: Vlad Yasevich <vyasevich@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/ipv6/ip6mr.c')
0 files changed, 0 insertions, 0 deletions