diff options
| author | Jan Engelhardt <jengelh@medozas.de> | 2010-03-18 00:27:03 +0100 |
|---|---|---|
| committer | Jan Engelhardt <jengelh@medozas.de> | 2010-03-18 14:20:07 +0100 |
| commit | 85bc3f38147c5d3fb1eb9ca2236536389b592cae (patch) | |
| tree | 1e853e78c883c5a2dcf72e7d432e7ebf6be04973 /net/netfilter/xt_LED.c | |
| parent | f5c511c67aaec323c186543856cfddab31bed1d1 (diff) | |
| download | kernel_samsung_smdk4412-85bc3f38147c5d3fb1eb9ca2236536389b592cae.zip kernel_samsung_smdk4412-85bc3f38147c5d3fb1eb9ca2236536389b592cae.tar.gz kernel_samsung_smdk4412-85bc3f38147c5d3fb1eb9ca2236536389b592cae.tar.bz2 | |
netfilter: xtables: do not print any messages on ENOMEM
ENOMEM is a very obvious error code (cf. EINVAL), so I think we do not
really need a warning message. Not to mention that if the allocation
fails, the user is most likely going to get a stack trace from slab
already.
Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Diffstat (limited to 'net/netfilter/xt_LED.c')
| -rw-r--r-- | net/netfilter/xt_LED.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/netfilter/xt_LED.c b/net/netfilter/xt_LED.c index f86dc52..0d6c288 100644 --- a/net/netfilter/xt_LED.c +++ b/net/netfilter/xt_LED.c @@ -92,10 +92,8 @@ static bool led_tg_check(const struct xt_tgchk_param *par) } ledinternal = kzalloc(sizeof(struct xt_led_info_internal), GFP_KERNEL); - if (!ledinternal) { - printk(KERN_CRIT KBUILD_MODNAME ": out of memory\n"); + if (!ledinternal) return false; - } ledinternal->netfilter_led_trigger.name = ledinfo->id; |