diff options
author | Jonathan Corbet <corbet@lwn.net> | 2009-02-01 14:52:56 -0700 |
---|---|---|
committer | Jonathan Corbet <corbet@lwn.net> | 2009-03-16 08:34:35 -0600 |
commit | 60aa49243d09afc873f082567d2e3c16634ced84 (patch) | |
tree | bb7c8d9668b35a3aa4e90d0a62500ac9d3e67f7f /sound/core/pcm_native.c | |
parent | 76398425bb06b07cc3a3b1ce169c67dc9d6874ed (diff) | |
download | kernel_samsung_smdk4412-60aa49243d09afc873f082567d2e3c16634ced84.zip kernel_samsung_smdk4412-60aa49243d09afc873f082567d2e3c16634ced84.tar.gz kernel_samsung_smdk4412-60aa49243d09afc873f082567d2e3c16634ced84.tar.bz2 |
Rationalize fasync return values
Most fasync implementations do something like:
return fasync_helper(...);
But fasync_helper() will return a positive value at times - a feature used
in at least one place. Thus, a number of other drivers do:
err = fasync_helper(...);
if (err < 0)
return err;
return 0;
In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Diffstat (limited to 'sound/core/pcm_native.c')
-rw-r--r-- | sound/core/pcm_native.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index a789efc..a75c194 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -3246,9 +3246,7 @@ static int snd_pcm_fasync(int fd, struct file * file, int on) err = fasync_helper(fd, file, on, &runtime->fasync); out: unlock_kernel(); - if (err < 0) - return err; - return 0; + return err; } /* |