aboutsummaryrefslogtreecommitdiffstats
path: root/sound
diff options
context:
space:
mode:
authorKangjie Lu <kangjielu@gmail.com>2016-05-03 16:44:32 -0400
committerSimon Shields <keepcalm444@gmail.com>2016-05-17 22:11:13 +1000
commit634a18fa462f27fb73b1d7ec2646d2e08d391b41 (patch)
tree9cbd8b3fbc57b2da981a9e9685865fdc068ceec1 /sound
parent75f9d7249fcdce27a26aa50a1620f60d24b9afc5 (diff)
downloadkernel_samsung_smdk4412-634a18fa462f27fb73b1d7ec2646d2e08d391b41.zip
kernel_samsung_smdk4412-634a18fa462f27fb73b1d7ec2646d2e08d391b41.tar.gz
kernel_samsung_smdk4412-634a18fa462f27fb73b1d7ec2646d2e08d391b41.tar.bz2
ALSA: timer: Fix leak in events via snd_timer_user_tinterrupt
The stack object “r1” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized. Change-Id: Ie3dcdee7da8ad292712814e8402c571a717ab8d1 Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
-rw-r--r--sound/core/timer.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/core/timer.c b/sound/core/timer.c
index c0a11d5..22c43b3 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1215,6 +1215,7 @@ static void snd_timer_user_tinterrupt(struct snd_timer_instance *timeri,
}
if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&
tu->last_resolution != resolution) {
+ memset(&r1, 0, sizeof(r1));
r1.event = SNDRV_TIMER_EVENT_RESOLUTION;
r1.tstamp = tstamp;
r1.val = resolution;