diff options
Diffstat (limited to 'drivers/usb/serial')
-rw-r--r-- | drivers/usb/serial/Kconfig | 9 | ||||
-rw-r--r-- | drivers/usb/serial/Makefile | 1 | ||||
-rw-r--r-- | drivers/usb/serial/csvt.c | 446 | ||||
-rw-r--r-- | drivers/usb/serial/qcserial.c | 34 | ||||
-rw-r--r-- | drivers/usb/serial/qcserial.h | 10 | ||||
-rw-r--r-- | drivers/usb/serial/usb-serial.c | 7 | ||||
-rw-r--r-- | drivers/usb/serial/usb-wwan.h | 4 | ||||
-rw-r--r-- | drivers/usb/serial/usb_wwan.c | 68 |
8 files changed, 562 insertions, 17 deletions
diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig index b71e309..caa5fda 100644 --- a/drivers/usb/serial/Kconfig +++ b/drivers/usb/serial/Kconfig @@ -651,6 +651,15 @@ config USB_SERIAL_SSU100 To compile this driver as a module, choose M here: the module will be called ssu100. +config USB_SERIAL_CSVT + tristate "USB serial driver for Circuit-Switched Video Telephony" + help + Say Y here if you want to use usb serial driver for Circuit-Switched + Video Telephony + + To compile this driver as a module, choose M here: the + module will be called csvt. + config USB_SERIAL_DEBUG tristate "USB Debugging Device" help diff --git a/drivers/usb/serial/Makefile b/drivers/usb/serial/Makefile index 9e536ee..2d085b2 100644 --- a/drivers/usb/serial/Makefile +++ b/drivers/usb/serial/Makefile @@ -60,3 +60,4 @@ obj-$(CONFIG_USB_SERIAL_WHITEHEAT) += whiteheat.o obj-$(CONFIG_USB_SERIAL_XIRCOM) += keyspan_pda.o obj-$(CONFIG_USB_SERIAL_VIVOPAY_SERIAL) += vivopay-serial.o obj-$(CONFIG_USB_SERIAL_ZIO) += zio.o +obj-$(CONFIG_USB_SERIAL_CSVT) += csvt.o diff --git a/drivers/usb/serial/csvt.c b/drivers/usb/serial/csvt.c new file mode 100644 index 0000000..28eba8a --- /dev/null +++ b/drivers/usb/serial/csvt.c @@ -0,0 +1,446 @@ +/* Copyright (c) 2012, Code Aurora Forum. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/slab.h> +#include <linux/tty.h> +#include <linux/serial.h> +#include <linux/tty_flip.h> +#include <linux/uaccess.h> +#include <linux/usb.h> +#include <linux/usb/ch9.h> +#include <linux/usb/cdc.h> +#include <linux/usb/serial.h> +#include <asm/unaligned.h> + + +/* output control lines*/ +#define CSVT_CTRL_DTR 0x01 +#define CSVT_CTRL_RTS 0x02 + +/* input control lines*/ +#define CSVT_CTRL_CTS 0x01 +#define CSVT_CTRL_DSR 0x02 +#define CSVT_CTRL_RI 0x04 +#define CSVT_CTRL_CD 0x08 + +static int debug; +module_param(debug, int, S_IRUGO | S_IWUSR); + +struct csvt_ctrl_dev { + struct mutex dev_lock; + + /* input control lines (DSR, CTS, CD, RI) */ + unsigned int cbits_tolocal; + + /* output control lines (DTR, RTS) */ + unsigned int cbits_tomdm; +}; + +static const struct usb_device_id id_table[] = { + { USB_DEVICE_AND_INTERFACE_INFO(0x05c6 , 0x904c, 0xff, 0xfe, 0xff)}, + {}, /* terminating entry */ +}; +MODULE_DEVICE_TABLE(usb, id_table); + +static struct usb_driver csvt_driver = { + .name = "qc_csvt", + .probe = usb_serial_probe, + .disconnect = usb_serial_disconnect, + .id_table = id_table, + .suspend = usb_serial_suspend, + .resume = usb_serial_resume, + .supports_autosuspend = true, +}; + +#define CSVT_IFC_NUM 4 + +static int csvt_probe(struct usb_serial *serial, const struct usb_device_id *id) +{ + struct usb_host_interface *intf = + serial->interface->cur_altsetting; + + pr_debug("%s:\n", __func__); + + if (intf->desc.bInterfaceNumber != CSVT_IFC_NUM) + return -ENODEV; + + usb_enable_autosuspend(serial->dev); + + return 0; +} + +static int csvt_ctrl_write_cmd(struct csvt_ctrl_dev *dev, + struct usb_serial_port *port) +{ + struct usb_device *udev = port->serial->dev; + struct usb_interface *iface = port->serial->interface; + unsigned int iface_num; + int retval = 0; + + retval = usb_autopm_get_interface(iface); + if (retval < 0) { + dev_err(&port->dev, "%s: Unable to resume interface: %d\n", + __func__, retval); + return retval; + } + + dev_dbg(&port->dev, "%s: cbits to mdm 0x%x\n", __func__, + dev->cbits_tomdm); + + iface_num = iface->cur_altsetting->desc.bInterfaceNumber; + + retval = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), + USB_CDC_REQ_SET_CONTROL_LINE_STATE, + (USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE), + dev->cbits_tomdm, + iface_num, + NULL, 0, USB_CTRL_SET_TIMEOUT); + usb_autopm_put_interface(iface); + + return retval; +} + +static void csvt_ctrl_dtr_rts(struct usb_serial_port *port, int on) +{ + struct csvt_ctrl_dev *dev = usb_get_serial_port_data(port); + + if (!dev) + return; + + dev_dbg(&port->dev, "%s", __func__); + + mutex_lock(&dev->dev_lock); + if (on) { + dev->cbits_tomdm |= CSVT_CTRL_DTR; + dev->cbits_tomdm |= CSVT_CTRL_RTS; + } else { + dev->cbits_tomdm &= ~CSVT_CTRL_DTR; + dev->cbits_tomdm &= ~CSVT_CTRL_RTS; + } + mutex_unlock(&dev->dev_lock); + + csvt_ctrl_write_cmd(dev, port); +} + +static int get_serial_info(struct usb_serial_port *port, + struct serial_struct __user *retinfo) +{ + struct serial_struct tmp; + + if (!retinfo) + return -EFAULT; + + memset(&tmp, 0, sizeof(tmp)); + tmp.line = port->serial->minor; + tmp.port = port->number; + tmp.baud_base = tty_get_baud_rate(port->port.tty); + tmp.close_delay = port->port.close_delay / 10; + tmp.closing_wait = + port->port.closing_wait == ASYNC_CLOSING_WAIT_NONE ? + ASYNC_CLOSING_WAIT_NONE : + port->port.closing_wait / 10; + + if (copy_to_user(retinfo, &tmp, sizeof(*retinfo))) + return -EFAULT; + return 0; +} + +static int set_serial_info(struct usb_serial_port *port, + struct serial_struct __user *newinfo) +{ + struct serial_struct new_serial; + unsigned int closing_wait; + unsigned int close_delay; + int retval = 0; + + if (copy_from_user(&new_serial, newinfo, sizeof(new_serial))) + return -EFAULT; + + close_delay = new_serial.close_delay * 10; + closing_wait = new_serial.closing_wait == ASYNC_CLOSING_WAIT_NONE ? + ASYNC_CLOSING_WAIT_NONE : new_serial.closing_wait * 10; + + mutex_lock(&port->port.mutex); + + if (!capable(CAP_SYS_ADMIN)) { + if ((close_delay != port->port.close_delay) || + (closing_wait != port->port.closing_wait)) + retval = -EPERM; + else + retval = -EOPNOTSUPP; + } else { + port->port.close_delay = close_delay; + port->port.closing_wait = closing_wait; + } + + mutex_unlock(&port->port.mutex); + return retval; +} + +static int csvt_ctrl_ioctl(struct tty_struct *tty, unsigned int cmd, + unsigned long arg) +{ + struct usb_serial_port *port = tty->driver_data; + + dev_dbg(&port->dev, "%s cmd 0x%04x", __func__, cmd); + + switch (cmd) { + case TIOCGSERIAL: + return get_serial_info(port, + (struct serial_struct __user *) arg); + case TIOCSSERIAL: + return set_serial_info(port, + (struct serial_struct __user *) arg); + default: + break; + } + + dev_err(&port->dev, "%s arg not supported", __func__); + + return -ENOIOCTLCMD; +} + +static int csvt_ctrl_tiocmget(struct tty_struct *tty) +{ + struct usb_serial_port *port = tty->driver_data; + struct csvt_ctrl_dev *dev = usb_get_serial_port_data(port); + unsigned int control_state = 0; + + if (!dev) + return -ENODEV; + + mutex_lock(&dev->dev_lock); + control_state = (dev->cbits_tomdm & CSVT_CTRL_DTR ? TIOCM_DTR : 0) | + (dev->cbits_tomdm & CSVT_CTRL_RTS ? TIOCM_RTS : 0) | + (dev->cbits_tolocal & CSVT_CTRL_DSR ? TIOCM_DSR : 0) | + (dev->cbits_tolocal & CSVT_CTRL_RI ? TIOCM_RI : 0) | + (dev->cbits_tolocal & CSVT_CTRL_CD ? TIOCM_CD : 0) | + (dev->cbits_tolocal & CSVT_CTRL_CTS ? TIOCM_CTS : 0); + mutex_unlock(&dev->dev_lock); + + dev_dbg(&port->dev, "%s -- %x", __func__, control_state); + + return control_state; +} + +static int csvt_ctrl_tiocmset(struct tty_struct *tty, + unsigned int set, unsigned int clear) +{ + struct usb_serial_port *port = tty->driver_data; + struct csvt_ctrl_dev *dev = usb_get_serial_port_data(port); + + if (!dev) + return -ENODEV; + + dev_dbg(&port->dev, "%s\n", __func__); + + mutex_lock(&dev->dev_lock); + if (set & CSVT_CTRL_DTR) + dev->cbits_tomdm |= TIOCM_DTR; + if (set & CSVT_CTRL_RTS) + dev->cbits_tomdm |= TIOCM_RTS; + + if (clear & CSVT_CTRL_DTR) + dev->cbits_tomdm &= ~TIOCM_DTR; + if (clear & CSVT_CTRL_RTS) + dev->cbits_tomdm &= ~TIOCM_RTS; + mutex_unlock(&dev->dev_lock); + + return csvt_ctrl_write_cmd(dev, port); +} + +static void csvt_ctrl_set_termios(struct tty_struct *tty, + struct usb_serial_port *port, + struct ktermios *old_termios) +{ + struct csvt_ctrl_dev *dev = usb_get_serial_port_data(port); + + if (!dev) + return; + + dev_dbg(&port->dev, "%s", __func__); + + /* Doesn't support option setting */ + tty_termios_copy_hw(tty->termios, old_termios); + + csvt_ctrl_write_cmd(dev, port); +} + +static void csvt_ctrl_int_cb(struct urb *urb) +{ + int status; + struct usb_cdc_notification *ctrl; + struct usb_serial_port *port = urb->context; + struct csvt_ctrl_dev *dev; + unsigned int ctrl_bits; + unsigned char *data; + + switch (urb->status) { + case 0: + /*success*/ + break; + case -ESHUTDOWN: + case -ENOENT: + case -ECONNRESET: + case -EPROTO: + /* unplug */ + return; + case -EPIPE: + dev_err(&port->dev, "%s: stall on int endpoint\n", __func__); + /* TBD : halt to be cleared in work */ + case -EOVERFLOW: + default: + pr_debug_ratelimited("%s: non zero urb status = %d\n", + __func__, urb->status); + goto resubmit_int_urb; + } + + dev = usb_get_serial_port_data(port); + if (!dev) + return; + + ctrl = urb->transfer_buffer; + data = (unsigned char *)(ctrl + 1); + + usb_serial_debug_data(debug, &port->dev, __func__, + urb->actual_length, data); + + switch (ctrl->bNotificationType) { + case USB_CDC_NOTIFY_NETWORK_CONNECTION: + dev_dbg(&port->dev, "%s network\n", ctrl->wValue ? + "connected to" : "disconnected from"); + break; + case USB_CDC_NOTIFY_SERIAL_STATE: + ctrl_bits = get_unaligned_le16(data); + dev_dbg(&port->dev, "serial state: %d\n", ctrl_bits); + dev->cbits_tolocal = ctrl_bits; + break; + default: + dev_err(&port->dev, "%s: unknown notification %d received:" + "index %d len %d data0 %d data1 %d", + __func__, ctrl->bNotificationType, ctrl->wIndex, + ctrl->wLength, data[0], data[1]); + } + +resubmit_int_urb: + status = usb_submit_urb(urb, GFP_ATOMIC); + if (status) + dev_err(&port->dev, "%s: Error re-submitting Int URB %d\n", + __func__, status); + +} + +static int csvt_ctrl_open(struct tty_struct *tty, + struct usb_serial_port *port) +{ + int retval; + + dev_dbg(&port->dev, "%s port %d", __func__, port->number); + + retval = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); + if (retval) { + dev_err(&port->dev, "usb_submit_urb(read int) failed\n"); + return retval; + } + + retval = usb_serial_generic_open(tty, port); + if (retval) + usb_kill_urb(port->interrupt_in_urb); + + return retval; +} + +static void csvt_ctrl_close(struct usb_serial_port *port) +{ + dev_dbg(&port->dev, "%s port %d", __func__, port->number); + + usb_serial_generic_close(port); + usb_kill_urb(port->interrupt_in_urb); +} + +static int csvt_ctrl_attach(struct usb_serial *serial) +{ + struct csvt_ctrl_dev *dev; + + dev = kzalloc(sizeof(*dev), GFP_KERNEL); + if (!dev) + return -ENOMEM; + + mutex_init(&dev->dev_lock); + usb_set_serial_port_data(serial->port[0], dev); + + return 0; +} + +static void csvt_ctrl_release(struct usb_serial *serial) +{ + struct usb_serial_port *port = serial->port[0]; + struct csvt_ctrl_dev *dev = usb_get_serial_port_data(port); + + dev_dbg(&port->dev, "%s", __func__); + + kfree(dev); + usb_set_serial_port_data(port, NULL); +} + +static struct usb_serial_driver csvt_device = { + .driver = { + .owner = THIS_MODULE, + .name = "qc_csvt", + }, + .description = "qc_csvt", + .id_table = id_table, + .usb_driver = &csvt_driver, + .num_ports = 1, + .open = csvt_ctrl_open, + .close = csvt_ctrl_close, + .probe = csvt_probe, + .dtr_rts = csvt_ctrl_dtr_rts, + .tiocmget = csvt_ctrl_tiocmget, + .tiocmset = csvt_ctrl_tiocmset, + .ioctl = csvt_ctrl_ioctl, + .set_termios = csvt_ctrl_set_termios, + .read_int_callback = csvt_ctrl_int_cb, + .attach = csvt_ctrl_attach, + .release = csvt_ctrl_release, +}; + +static int __init csvt_init(void) +{ + int retval; + + retval = usb_serial_register(&csvt_device); + if (retval) { + err("%s: usb serial register failed\n", __func__); + return retval; + } + + retval = usb_register(&csvt_driver); + if (retval) { + usb_serial_deregister(&csvt_device); + err("%s: usb register failed\n", __func__); + return retval; + } + + return 0; +} + +static void __exit csvt_exit(void) +{ + usb_deregister(&csvt_driver); + usb_serial_deregister(&csvt_device); +} + +module_init(csvt_init); +module_exit(csvt_exit); + +MODULE_LICENSE("GPL v2"); diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index a89c0ac..879dd87 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c @@ -16,6 +16,9 @@ #include <linux/usb.h> #include <linux/usb/serial.h> #include <linux/slab.h> +#ifdef CONFIG_MDM_HSIC_PM +#include "qcserial.h" +#endif #include "usb-wwan.h" #define DRIVER_AUTHOR "Qualcomm Inc" @@ -105,6 +108,8 @@ static const struct usb_device_id id_table[] = { {USB_DEVICE(0x413c, 0x8193)}, /* Dell Gobi 3000 QDL */ {USB_DEVICE(0x413c, 0x8194)}, /* Dell Gobi 3000 Composite */ {USB_DEVICE(0x1199, 0x9013)}, /* Sierra Wireless Gobi 3000 Modem device (MC8355) */ + {USB_DEVICE(0x05c6, 0x9048)}, /* MDM9x15 device */ + {USB_DEVICE(0x05c6, 0x904C)}, /* MDM9x15 device */ {USB_DEVICE(0x12D1, 0x14F0)}, /* Sony Gobi 3000 QDL */ {USB_DEVICE(0x12D1, 0x14F1)}, /* Sony Gobi 3000 Composite */ { } /* Terminating entry */ @@ -120,9 +125,26 @@ static struct usb_driver qcdriver = { .id_table = id_table, .suspend = usb_serial_suspend, .resume = usb_serial_resume, + .reset_resume = usb_serial_resume, .supports_autosuspend = true, }; +#ifdef CONFIG_MDM_HSIC_PM +void check_chip_configuration(char *product) +{ + if (!product) + return; + + pr_info("%s: usb product name = %s\n", __func__, product); + + if (!strncmp(product, PRODUCT_DLOAD, sizeof(PRODUCT_DLOAD))) + mdm_set_chip_configuration(true); + else if (!strncmp(product, PRODUCT_SAHARA, sizeof(PRODUCT_SAHARA))) + mdm_set_chip_configuration(false); + else + panic("UnKnown MDM product"); +} +#endif static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id) { struct usb_wwan_intf_private *data; @@ -146,9 +168,17 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id) return -ENOMEM; spin_lock_init(&data->susp_lock); - +#ifdef CONFIG_MDM_HSIC_PM + if (id->idVendor == 0x05c6 && id->idProduct == 0x9008) + check_chip_configuration(serial->dev->product); + + if (id->idVendor == 0x05c6 && + (id->idProduct == 0x9008 || id->idProduct == 0x9048 || + id->idProduct == 0x904c)) + goto set_interface; usb_enable_autosuspend(serial->dev); - +set_interface: +#endif switch (nintf) { case 1: /* QDL mode */ diff --git a/drivers/usb/serial/qcserial.h b/drivers/usb/serial/qcserial.h new file mode 100644 index 0000000..8504173 --- /dev/null +++ b/drivers/usb/serial/qcserial.h @@ -0,0 +1,10 @@ +#if !defined(_QCSERIAL_H_) +#define _QCSERIAL_H_ +#include <linux/wakelock.h> + +#define PRODUCT_DLOAD "QHSUSB_DLOAD" +#define PRODUCT_SAHARA "QHSUSB__BULK" + +extern void mdm_set_chip_configuration(bool dload); + +#endif diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c index 5d7b71b..9667684 100644 --- a/drivers/usb/serial/usb-serial.c +++ b/drivers/usb/serial/usb-serial.c @@ -355,9 +355,10 @@ static int serial_write(struct tty_struct *tty, const unsigned char *buf, if (port->serial->dev->state == USB_STATE_NOTATTACHED) goto exit; - - dbg("%s - port %d, %d byte(s)", __func__, port->number, count); - +#ifdef CONFIG_MACH_M0 + printk(KERN_INFO "%s - port %d, %d byte(s)", + __func__, port->number, count); +#endif /* pass on to the driver specific version of this function */ retval = port->serial->type->write(tty, port, buf, count); diff --git a/drivers/usb/serial/usb-wwan.h b/drivers/usb/serial/usb-wwan.h index de8d490..a99577b 100644 --- a/drivers/usb/serial/usb-wwan.h +++ b/drivers/usb/serial/usb-wwan.h @@ -31,7 +31,11 @@ extern int usb_wwan_resume(struct usb_serial *serial); /* per port private data */ +#ifdef CONFIG_MDM_HSIC_PM +#define N_IN_URB 1 +#else #define N_IN_URB 5 +#endif #define N_OUT_URB 5 #define IN_BUFLEN 65536 #define OUT_BUFLEN 65536 diff --git a/drivers/usb/serial/usb_wwan.c b/drivers/usb/serial/usb_wwan.c index 2a9d21d..2e2a60d 100644 --- a/drivers/usb/serial/usb_wwan.c +++ b/drivers/usb/serial/usb_wwan.c @@ -219,6 +219,11 @@ int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port, dbg("%s: write (%d chars)", __func__, count); +#ifdef CONFIG_MDM_HSIC_PM + if (port->serial->dev->actconfig->desc.bNumInterfaces == 9) + pr_info("%s: write (%d chars)", __func__, count); +#endif + i = 0; left = count; for (i = 0; left > 0 && i < N_OUT_URB; i++) { @@ -237,6 +242,8 @@ int usb_wwan_write(struct tty_struct *tty, struct usb_serial_port *port, dbg("%s: endpoint %d buf %d", __func__, usb_pipeendpoint(this_urb->pipe), i); + usb_mark_last_busy( + interface_to_usbdev(port->serial->interface)); err = usb_autopm_get_interface_async(port->serial->interface); if (err < 0) break; @@ -285,29 +292,61 @@ static void usb_wwan_indat_callback(struct urb *urb) struct tty_struct *tty; unsigned char *data = urb->transfer_buffer; int status = urb->status; + int rx_len = urb->actual_length; + struct usb_wwan_intf_private *intfdata; dbg("%s: %p", __func__, urb); endpoint = usb_pipeendpoint(urb->pipe); port = urb->context; + intfdata = port->serial->private; + usb_mark_last_busy(interface_to_usbdev(port->serial->interface)); if (status) { dbg("%s: nonzero status: %d on endpoint %02x.", __func__, status, endpoint); +#ifdef CONFIG_MDM_HSIC_PM + if (status == -ENOENT && (urb->actual_length > 0)) { + pr_info("%s: handle dropped packet\n", __func__); + goto handle_rx; + } +#endif } else { +#ifdef CONFIG_MDM_HSIC_PM +handle_rx: +#endif tty = tty_port_tty_get(&port->port); if (tty) { - if (urb->actual_length) { - tty_insert_flip_string(tty, data, - urb->actual_length); + if (urb->actual_length > 0) { +#ifdef CONFIG_MDM_HSIC_PM + struct usb_device *udev = port->serial->dev; + /* corner case : efs packet rx at rpm suspend + * it can control twice in racing condition + * rx call back and suspend, both of then ca + * call this function , so clear the packet + * length once it handled + */ + urb->status = -EINPROGRESS; + urb->actual_length = 0; + if (udev->actconfig->desc.bNumInterfaces == 9) + pr_info("%s: read urb received : %d\n", + __func__, rx_len); +#endif + tty_insert_flip_string(tty, data, rx_len); tty_flip_buffer_push(tty); } else dbg("%s: empty read urb received", __func__); tty_kref_put(tty); - } + } else + return; +#ifdef CONFIG_MDM_HSIC_PM + /* do not re-submit urb for no entry status */ + if (status == -ENOENT) + return; +#endif /* Resubmit urb so we continue receiving */ - if (status != -ESHUTDOWN) { + if (status != -ESHUTDOWN || !intfdata->suspended) { err = usb_submit_urb(urb, GFP_ATOMIC); if (err) { if (err != -EPERM) { @@ -319,6 +358,8 @@ static void usb_wwan_indat_callback(struct urb *urb) } else { usb_mark_last_busy(port->serial->dev); } + usb_mark_last_busy( + interface_to_usbdev(port->serial->interface)); } } @@ -338,6 +379,7 @@ static void usb_wwan_outdat_callback(struct urb *urb) usb_serial_port_softint(port); usb_autopm_put_interface_async(port->serial->interface); + usb_mark_last_busy(interface_to_usbdev(port->serial->interface)); portdata = usb_get_serial_port_data(port); spin_lock(&intfdata->susp_lock); intfdata->in_flight--; @@ -405,6 +447,7 @@ int usb_wwan_open(struct tty_struct *tty, struct usb_serial_port *port) portdata = usb_get_serial_port_data(port); intfdata = serial->private; + intfdata->suspended = 0; /* explicitly set the driver mode to raw */ tty->raw = 1; @@ -582,8 +625,7 @@ bail_out_error2: kfree(portdata->out_buffer[j]); bail_out_error: for (j = 0; j < N_IN_URB; j++) - if (portdata->in_buffer[j]) - free_page((unsigned long)portdata->in_buffer[j]); + kfree(portdata->in_buffer[j]); kfree(portdata); return 1; } @@ -608,8 +650,10 @@ static void stop_read_write_urbs(struct usb_serial *serial) void usb_wwan_disconnect(struct usb_serial *serial) { + struct usb_wwan_intf_private *intfdata = serial->private; dbg("%s", __func__); + intfdata->suspended = 1; stop_read_write_urbs(serial); } EXPORT_SYMBOL(usb_wwan_disconnect); @@ -629,8 +673,7 @@ void usb_wwan_release(struct usb_serial *serial) for (j = 0; j < N_IN_URB; j++) { usb_free_urb(portdata->in_urbs[j]); - free_page((unsigned long) - portdata->in_buffer[j]); + kfree(portdata->in_buffer[j]); portdata->in_urbs[j] = NULL; } for (j = 0; j < N_OUT_URB; j++) { @@ -736,6 +779,10 @@ int usb_wwan_resume(struct usb_serial *serial) } } + spin_lock_irq(&intfdata->susp_lock); + intfdata->suspended = 0; + spin_unlock_irq(&intfdata->susp_lock); + for (i = 0; i < serial->num_ports; i++) { /* walk all ports */ port = serial->port[i]; @@ -761,9 +808,6 @@ int usb_wwan_resume(struct usb_serial *serial) play_delayed(port); spin_unlock_irq(&intfdata->susp_lock); } - spin_lock_irq(&intfdata->susp_lock); - intfdata->suspended = 0; - spin_unlock_irq(&intfdata->susp_lock); err_out: return err; } |