aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Staging: comedi: pcl816: update convert_src mask for AI cmdtestIan Abbott2009-12-111-1/+3
| | | | | | | | | | The COMEDI_CMDTEST ioctl needs to clear unsupported bits in the struct comedi_cmd's convert_src and other *_src members. This needs fixing in the pcl816 driver's AI cmdtest. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: initialize divisor variablesIan Abbott2009-12-116-9/+10
| | | | | | | | | | | The i8253_cascade_ns_to_timer_2div() function (and i8253_cascade_ns_to_timer macro) checks the old values *d1 and *d2 for correctness as a heuristic before calculating new values. Don't call the function with uninitialized values in *d1 and *d2. Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: serial2002: decrease stack usageIan Abbott2009-12-111-2/+2
| | | | | | | | | | | 512 bytes of stack can be saved in serial_2002_open() by modifying 'struct config_t'. A short int suffices for the 'kind' and 'bits' members. (Actually, a char would suffice, but wouldn't save any more stack than a short int.) Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: fix usbdux timeout bugBernd Porr2009-12-111-8/+9
| | | | | | | | | | | I've fixed a bug in the USBDUX driver which caused timeouts while sending commands to the boards. This was mainly because of one bulk transfer which had a timeout of 1ms (!). I've now set all timeouts to 1000ms. From: Bernd Porr <BerndPorr@f2s.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ke_counter: fix style issuesDirk Hohndel2009-12-111-9/+12
| | | | | | | | | | 80 char limit (where useful) braces around single line block KERN_ facility for printk Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ii_pci_20kc: fix style printkDirk Hohndel2009-12-111-18/+21
| | | | | | | | | | add KERN_ facility to printk (mostly KERN_INFO, some KERN_WARNING) I think I found a bug - commented on it but didn't change as it's just in a printk (off by 1 error in output) Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ii_pci20kc: white space fixesDirk Hohndel2009-12-111-22/+22
| | | | | | | | | No code changes - left some 80 char violations alone as folding those lines would have made code less readable Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: icp_multi: don't init staticDirk Hohndel2009-12-111-1/+1
| | | | | | | | don't initialize static variable to 0 Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: icp_multi: fix style issue printkDirk Hohndel2009-12-111-38/+55
| | | | | | | | add KERN_ facility to printk (mostly KERN_DEBUG, some KERN_WARNING) Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: icp_multi: white space style fixesDirk Hohndel2009-12-111-124/+126
| | | | | | | | no code changes, just fixing white space, line length, etc Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: gsc_hdpi: style fixes static functionDirk Hohndel2009-12-111-2/+2
| | | | | | | | Convert external function to static Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: gsc_hpdi: Fix style issuesDirk Hohndel2009-12-111-51/+49
| | | | | | | | | | | Style cleanup in staging based on Greg's tutorial / checkpatch Fix 80 char line length (where useful) - includes two changes to code to make it more logical / readable Remove {} around single line blocks Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: gsc_hpdi: style fixes printkDirk Hohndel2009-12-111-9/+13
| | | | | | | | | Style cleanup in staging based on Greg's tutorial / checkpatch Add printk KERN_ facility level (KERN_WARNING seemed appropriate for all) Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: drivers: ni_6527: fixup checkpatch.pl warningsKlaas van Gend2009-12-111-19/+14
| | | | | | | | | This patch fixes all warnings as issued by checkpatch.pl. Note that I had to modify some of the logging messages to make that possible. Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: comedi_fc: checkpatch.pl fixesKlaas van Gend2009-12-111-4/+1
| | | | | | | | This patch fixes all warnings as issued by checkpatch.pl. Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: pcl726: fix coding style issuesKevyn-Alexandre Paré2009-12-111-21/+20
| | | | | | Signed-off-by: Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: addi-data: Cleanup redundant tests on unsignedRoel Kluin2009-12-1110-14/+12
| | | | | | | | | The variables are unsigned so the test `>= 0' is always true, In these cases the other part of the test catch wrapped values. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi: multiq3: add KERN_Klaas van Gend2009-12-111-5/+6
| | | | | | | | | Add KERN_ to printk statements to reduce the number of warnings shown by checkpatch.pl. Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi: multiq3: remove warning on bracesKlaas van Gend2009-12-111-9/+5
| | | | | | | | | Remove braces in if statements to make the file exhibit less warnings when checked using checkpatch.pl. Signed-off-by: Klaas van Gend <klaas.van.gend@mvista.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: adl_pci8164 coding style fixesBRAGA, Bruno2009-12-111-18/+19
| | | | | | | | | | | Corrected coding style: - excessive curly braces - printk without KERN_* logging - 80+ chars per line of code Signed-off-by: BRAGA, Bruno <bruno.braga@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: remove EXTERN macro since it is not usedShawn Bohrer2009-12-111-8/+0
| | | | | | Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: remove __cplusplus checkShawn Bohrer2009-12-111-8/+0
| | | | | | | | c++ isn't supported in the kernel. Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: Don't check for -ENOIOCTLCMDShawn Bohrer2009-12-111-6/+3
| | | | | | | | unlocked_ioctl() never returns -ENOIOCTLCMD so remove the check. Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: remove check for HAVE_COMPAT_IOCTLShawn Bohrer2009-12-113-130/+0
| | | | | | | | | All new kernels have support for compat_ioctl so remove the check and support for older kernels. Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* staging: comedi: Remove check for HAVE_UNLOCKED_IOCTLShawn Bohrer2009-12-113-26/+2
| | | | | | | All new kernels have unlocked_ioctl so we don't need to check. Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: pcmmio: more coding style cleanupDaniel Patrick Johnson2009-12-111-33/+77
| | | | | Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: pcmmio: Coding style cleanupDaniel Patrick Johnson2009-12-111-39/+82
| | | | | | Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: Comedi: pcm_common: Fixed all checkpatch issuesDaniel Patrick Johnson2009-12-111-2/+2
| | | | | | Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_mio_cs.c: coding style cleanupDaniel Patrick Johnson2009-12-111-6/+3
| | | | | | Signed-off-by: Daniel Patrick Johnson <teknotus@teknot.us> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: trivial fix of a very frequent spelling mistakeDirk Hohndel2009-12-1113-15/+15
| | | | | | | | | | | | | | something-bility is spelled as something-blity so a grep for 'blit' would find these lines this is so trivial that I didn't split it by subsystem / copy additional maintainers - all changes are to comments The only purpose is to get fewer false positives when grepping around the kernel sources. Signed-off-by: Dirk Hohndel <hohndel@infradead.org> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: amplc_pc263.c: more coding style fixesKevyn-Alexandre Paré2009-12-111-8/+4
| | | | | | Signed-off-by: Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: amplc_pc263.c: fix coding style issuesKevyn-Alexandre Paré2009-12-111-2/+4
| | | | | | Signed-off-by: Kevyn-Alexandre Paré <kevyn.alexandre.pare@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: adl_pci7432: coding style cleanupBruce Jones2009-12-111-17/+15
| | | | | | | Correct coding style problems in this file. Signed-off-by: Bruce Jones <brucej@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: adl_pci7296: CodingStyle cleanupBruce Jones2009-12-111-10/+9
| | | | | | | | Fix up printk's and other simple coding style issues. Signed-off-by: Bruce Jones <brucej@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: acl7225b.c: CodingStyle printk fixupsBruce Jones2009-12-111-5/+4
| | | | | | | | | Clean up the printk's in this driver. Signed-off-by: Bruce Jones <brucej@linux.com> Cc: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: comedi_compat32.h: Fixed checkpatch.pl issuesShane Warden2009-12-111-1/+3
| | | | | Signed-off-by: Shane Warden <shane.warden@onyxneon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: vmk80xx: cleanup formattingBruce Jones2009-12-111-12/+12
| | | | | | | | | Clean up formatting of a struct initializer, as per the standard conventions. Signed-off-by: Bruce Jones <brucej@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_atmio16d: printk fixupsBruce Jones2009-12-111-14/+16
| | | | | | | | | Fix improper use of printks in this driver. Most are debug messages under a DEBUG #ifdef, a few are info/warnings that should get logged for driver error conditions. Signed-off-by: Bruce Jones <brucej@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: nt_atmio16d: space and tab fixesBruce Jones2009-12-111-13/+13
| | | | | | | | | | Turn spaces into tabs to keep scripts/checkpatch.pl happy. The actual changes here are in a comment, so the script is just being silly. Signed-off-by: Bruce Jones <brucej@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_atmio16d: brace fixesBruce Jones2009-12-111-12/+6
| | | | | | | | Fix improper use of braces in drivers/staging/comedi/drivers/ni_atmio16d.c Signed-off-by: Bruce Jones <brucej@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_atmio16d: fix formating errorsBruce Jones2009-12-111-7/+7
| | | | | | | | | Correct formatting errors - in this case line length and spaces before parens. Signed-off-by: Bruce Jones <brucej@linux.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: mite.h: deletion of unused functionsmatt mooney2009-12-111-7/+0
| | | | | | | | | drivers/mite.h: removed declared but undefined functions mite_ll_from_kvmem and mite_setregs Signed-off-by: matt mooney <mfm@muteddisk.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: mite.c: fix coding stylematt mooney2009-12-111-110/+121
| | | | | | | | | - drivers/mite.c: added KERN_ facility level to printk - moved EXPORT_SYMBOL macro to follow function/variable Signed-off-by: matt mooney <mfm@muteddisk.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comdi: ni_at_ao.c: fix coding style errorAllison Randal2009-12-111-3/+3
| | | | | | | | The line was too long, used braces on single line for loop body. Signed-off-by: Allison Randal <allison@parrot.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: comedidev.h: Fixed checkpatch.pl issuesShane Warden2009-12-111-26/+34
| | | | | | Signed-off-by: Shane Warden <shane.warden@onyxneon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: comedi_compat32: Fixed checkpatch.pl issuesShane Warden2009-12-111-11/+11
| | | | | | Signed-off-by: Shane Warden <shane.warden@onyxneon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_labpc_cs: wrapped long commentsBart Massey2009-12-111-1/+2
| | | | | Signed-off-by: Bart Massey <bart@cs.pdx.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_labpc_cs: removed null check from kfreeBart Massey2009-12-111-3/+2
| | | | | Signed-off-by: Bart Massey <bart@cs.pdx.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_labpc_cs: removed null initialization of staticBart Massey2009-12-111-1/+1
| | | | | Signed-off-by: Bart Massey <bart@cs.pdx.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
* Staging: comedi: ni_labbc_cs: cleaned up debug define a bitBart Massey2009-12-111-2/+1
| | | | | | Signed-off-by: Bart Massey <bart@cs.pdx.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>