From e032b7aab92db3c9cdd27e06bb7fd75f6e323ac2 Mon Sep 17 00:00:00 2001 From: gorhill Date: Tue, 19 Aug 2014 23:01:36 -0400 Subject: code review (lot more needed), jshint --- js/3p-filters.js | 2 +- js/messaging.js | 2 ++ js/start.js | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) (limited to 'js') diff --git a/js/3p-filters.js b/js/3p-filters.js index cb3da21..cfff9e1 100644 --- a/js/3p-filters.js +++ b/js/3p-filters.js @@ -319,7 +319,7 @@ var onListLinkClicked = function(ev) { /******************************************************************************/ -var onPurgeClicked = function(ev) { +var onPurgeClicked = function() { var button = uDom(this); var li = button.parent(); var href = li.find('a').first().attr('href'); diff --git a/js/messaging.js b/js/messaging.js index 86c2309..95c175d 100644 --- a/js/messaging.js +++ b/js/messaging.js @@ -19,6 +19,8 @@ Home: https://github.com/gorhill/uBlock */ +/* global chrome, µBlock */ + // So there might be memory leaks related to the direct use of sendMessage(), // as per https://code.google.com/p/chromium/issues/detail?id=320723. The issue // is not marked as resolved, and the last message from chromium dev is: diff --git a/js/start.js b/js/start.js index aef9f4a..8f140ab 100644 --- a/js/start.js +++ b/js/start.js @@ -19,7 +19,7 @@ Home: https://github.com/gorhill/uBlock */ -// ORDER IS IMPORTANT +/* global µBlock */ /******************************************************************************/ -- cgit v1.1