aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2013-01-23 10:29:29 +0100
committerSamuel Tardieu <sam@rfc1149.net>2013-01-23 10:32:17 +0100
commit60c81eb3e8c58802cd5dd918a0dec0a6c97c9109 (patch)
treee39623f529388c141cf9f637ad5be4f7add7da87
parentce409f250855609a05dc736ec2da8ada7355079b (diff)
downloadcgeo-60c81eb3e8c58802cd5dd918a0dec0a6c97c9109.zip
cgeo-60c81eb3e8c58802cd5dd918a0dec0a6c97c9109.tar.gz
cgeo-60c81eb3e8c58802cd5dd918a0dec0a6c97c9109.tar.bz2
Refactoring: do not use a mutable variable
-rw-r--r--main/src/cgeo/geocaching/EditWaypointActivity.java7
1 files changed, 2 insertions, 5 deletions
diff --git a/main/src/cgeo/geocaching/EditWaypointActivity.java b/main/src/cgeo/geocaching/EditWaypointActivity.java
index accac5e..7e089cf 100644
--- a/main/src/cgeo/geocaching/EditWaypointActivity.java
+++ b/main/src/cgeo/geocaching/EditWaypointActivity.java
@@ -415,12 +415,9 @@ public class EditWaypointActivity extends AbstractActivity {
coords = coords.project(bearing, distance);
}
- String tmpName = ((EditText) findViewById(R.id.name)).getText().toString().trim();
// if no name is given, just give the waypoint its number as name
- if (StringUtils.isEmpty(tmpName)) {
- tmpName = res.getString(R.string.waypoint) + " " + (wpCount + 1);
- }
- final String name = tmpName;
+ final String givenName = ((EditText) findViewById(R.id.name)).getText().toString().trim();
+ final String name = StringUtils.isNotEmpty(givenName) ? givenName : res.getString(R.string.waypoint) + " " + (wpCount + 1);
final String note = ((EditText) findViewById(R.id.note)).getText().toString().trim();
final Geopoint coordsToSave = coords;
final ProgressDialog progress = ProgressDialog.show(EditWaypointActivity.this, getString(R.string.cache), getString(R.string.waypoint_being_saved), true);