diff options
| author | Samuel Tardieu <sam@rfc1149.net> | 2011-10-18 21:57:53 +0200 |
|---|---|---|
| committer | Samuel Tardieu <sam@rfc1149.net> | 2011-10-18 21:57:53 +0200 |
| commit | 67d7ae3073a16f13e50ba383c29aed24dc0b2ce8 (patch) | |
| tree | a6ec5842cea6206225d8cba8265047bb44d83d6e | |
| parent | e070d99c437ec6ee6852283786e2793af8cebeff (diff) | |
| download | cgeo-67d7ae3073a16f13e50ba383c29aed24dc0b2ce8.zip cgeo-67d7ae3073a16f13e50ba383c29aed24dc0b2ce8.tar.gz cgeo-67d7ae3073a16f13e50ba383c29aed24dc0b2ce8.tar.bz2 | |
Add three extra FIXME in parsing code
| -rw-r--r-- | main/src/cgeo/geocaching/cgBase.java | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/main/src/cgeo/geocaching/cgBase.java b/main/src/cgeo/geocaching/cgBase.java index 0615c0f..ca82bb0 100644 --- a/main/src/cgeo/geocaching/cgBase.java +++ b/main/src/cgeo/geocaching/cgBase.java @@ -692,9 +692,14 @@ public class cgBase { String inventoryPre = null; // GC* code + // FIXME: most of the blocks below cannot raise any exception try { final Matcher matcherCode = patternCode.matcher(row); + // FIXME: what are those while loops that can erase the previous values? This should either be fixed + // or documented here. while (matcherCode.find()) { + // FIXME: here, and probably below, a find necessarily has a group count > 0 as the first group + // is not optional. if (matcherCode.groupCount() > 0) { // The String constructor is necessary as long as the pattern matching doesn't use the // methods from BaseUtil. Otherwise every geocode holds the complete page in memory |