aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2014-08-03 21:57:56 +0200
committerSamuel Tardieu <sam@rfc1149.net>2014-08-04 00:42:20 +0200
commit68b79ef34f9457a225acde7b9fc4d7ff3fa383b3 (patch)
treeea4105a289faf949c23e723fce273913f557079f
parent836eab0ce727bbecb25d626afc6d5170f685a98c (diff)
downloadcgeo-68b79ef34f9457a225acde7b9fc4d7ff3fa383b3.zip
cgeo-68b79ef34f9457a225acde7b9fc4d7ff3fa383b3.tar.gz
cgeo-68b79ef34f9457a225acde7b9fc4d7ff3fa383b3.tar.bz2
Use multicatch
-rw-r--r--main/src/cgeo/geocaching/CgeoApplication.java7
-rw-r--r--main/src/cgeo/geocaching/connector/gc/GCMap.java10
-rw-r--r--main/src/cgeo/geocaching/files/FileTypeDetector.java3
-rw-r--r--main/src/cgeo/geocaching/sorting/SortActionProvider.java4
-rw-r--r--main/src/cgeo/geocaching/utils/CryptUtils.java8
5 files changed, 6 insertions, 26 deletions
diff --git a/main/src/cgeo/geocaching/CgeoApplication.java b/main/src/cgeo/geocaching/CgeoApplication.java
index 6d07b7f..269c1b6 100644
--- a/main/src/cgeo/geocaching/CgeoApplication.java
+++ b/main/src/cgeo/geocaching/CgeoApplication.java
@@ -62,12 +62,7 @@ public class CgeoApplication extends Application {
final Field menuKeyField = ViewConfiguration.class.getDeclaredField("sHasPermanentMenuKey");
menuKeyField.setAccessible(true);
menuKeyField.setBoolean(config, false);
- } catch (final IllegalArgumentException e) {
- // ignore
- } catch (final NoSuchFieldException e) {
- // ignore
- } catch (final IllegalAccessException e) {
- // ignore
+ } catch (IllegalArgumentException | IllegalAccessException | NoSuchFieldException ignore) {
}
// ensure initialization of lists
DataStore.getLists();
diff --git a/main/src/cgeo/geocaching/connector/gc/GCMap.java b/main/src/cgeo/geocaching/connector/gc/GCMap.java
index 27ce06e..c7318ce 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCMap.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCMap.java
@@ -102,11 +102,7 @@ public class GCMap {
caches.add(cache);
}
result.addAndPutInCache(caches);
- } catch (JSONException e) {
- result.setError(StatusCode.UNKNOWN_ERROR);
- } catch (ParseException e) {
- result.setError(StatusCode.UNKNOWN_ERROR);
- } catch (NumberFormatException e) {
+ } catch (JSONException | ParseException | NumberFormatException e) {
result.setError(StatusCode.UNKNOWN_ERROR);
}
return result;
@@ -220,9 +216,7 @@ public class GCMap {
searchResult.addAndPutInCache(caches);
Log.d("Retrieved " + searchResult.getCount() + " caches for tile " + tile.toString());
- } catch (RuntimeException e) {
- Log.e("GCMap.parseMapJSON", e);
- } catch (JSONException e) {
+ } catch (RuntimeException | JSONException e) {
Log.e("GCMap.parseMapJSON", e);
}
diff --git a/main/src/cgeo/geocaching/files/FileTypeDetector.java b/main/src/cgeo/geocaching/files/FileTypeDetector.java
index 389b83a..ab0f032 100644
--- a/main/src/cgeo/geocaching/files/FileTypeDetector.java
+++ b/main/src/cgeo/geocaching/files/FileTypeDetector.java
@@ -10,7 +10,6 @@ import android.content.ContentResolver;
import android.net.Uri;
import java.io.BufferedReader;
-import java.io.FileNotFoundException;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
@@ -37,8 +36,6 @@ public class FileTypeDetector {
reader = new BufferedReader(new InputStreamReader(is));
type = detectHeader(reader);
reader.close();
- } catch (FileNotFoundException e) {
- Log.e("FileTypeDetector", e);
} catch (IOException e) {
Log.e("FileTypeDetector", e);
} finally {
diff --git a/main/src/cgeo/geocaching/sorting/SortActionProvider.java b/main/src/cgeo/geocaching/sorting/SortActionProvider.java
index e9e65a0..61b2ffb 100644
--- a/main/src/cgeo/geocaching/sorting/SortActionProvider.java
+++ b/main/src/cgeo/geocaching/sorting/SortActionProvider.java
@@ -136,9 +136,7 @@ public class SortActionProvider extends ActionProvider implements OnMenuItemClic
final CacheComparator comparator = cacheComparator.newInstance();
onClickListener.call(comparator);
}
- } catch (final InstantiationException e) {
- Log.e("selectComparator", e);
- } catch (final IllegalAccessException e) {
+ } catch (final InstantiationException | IllegalAccessException e) {
Log.e("selectComparator", e);
}
}
diff --git a/main/src/cgeo/geocaching/utils/CryptUtils.java b/main/src/cgeo/geocaching/utils/CryptUtils.java
index 815c2f4..908add8 100644
--- a/main/src/cgeo/geocaching/utils/CryptUtils.java
+++ b/main/src/cgeo/geocaching/utils/CryptUtils.java
@@ -88,9 +88,7 @@ public final class CryptUtils {
final MessageDigest digest = MessageDigest.getInstance("MD5");
digest.update(text.getBytes(CharEncoding.UTF_8), 0, text.length());
return new BigInteger(1, digest.digest()).toString(16);
- } catch (NoSuchAlgorithmException e) {
- Log.e("CryptUtils.md5", e);
- } catch (UnsupportedEncodingException e) {
+ } catch (NoSuchAlgorithmException | UnsupportedEncodingException e) {
Log.e("CryptUtils.md5", e);
}
@@ -105,9 +103,7 @@ public final class CryptUtils {
final Mac mac = Mac.getInstance("HmacSHA1");
mac.init(secretKeySpec);
macBytes = mac.doFinal(text.getBytes(CharEncoding.UTF_8));
- } catch (GeneralSecurityException e) {
- Log.e("CryptUtils.hashHmac", e);
- } catch (UnsupportedEncodingException e) {
+ } catch (GeneralSecurityException | UnsupportedEncodingException e) {
Log.e("CryptUtils.hashHmac", e);
}