diff options
| author | Samuel Tardieu <sam@rfc1149.net> | 2012-04-27 17:39:54 +0200 |
|---|---|---|
| committer | Samuel Tardieu <sam@rfc1149.net> | 2012-04-27 17:39:54 +0200 |
| commit | 8d2a8e9856896a958efc59bb12c5c45c552cdfaa (patch) | |
| tree | fb086f668529b3a312ae8585c3bce7b7cb2fb6bc | |
| parent | 8bf6387d0df1459573ffcfd5992654d5c936bd2d (diff) | |
| download | cgeo-8d2a8e9856896a958efc59bb12c5c45c552cdfaa.zip cgeo-8d2a8e9856896a958efc59bb12c5c45c552cdfaa.tar.gz cgeo-8d2a8e9856896a958efc59bb12c5c45c552cdfaa.tar.bz2 | |
Refactoring: remove unnecessary unboxing
| -rw-r--r-- | main/src/cgeo/geocaching/connector/gc/GCParser.java | 2 | ||||
| -rw-r--r-- | main/src/cgeo/geocaching/files/GPXParser.java | 2 | ||||
| -rw-r--r-- | main/src/cgeo/geocaching/maps/PositionOverlay.java | 2 | ||||
| -rw-r--r-- | tests/src/cgeo/test/Compare.java | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/main/src/cgeo/geocaching/connector/gc/GCParser.java b/main/src/cgeo/geocaching/connector/gc/GCParser.java index 5ad7b53..0e5221c 100644 --- a/main/src/cgeo/geocaching/connector/gc/GCParser.java +++ b/main/src/cgeo/geocaching/connector/gc/GCParser.java @@ -1502,7 +1502,7 @@ public abstract class GCParser { final Integer ctl = Integer.valueOf(trackableMatcher.group(3)); final Integer id = Integer.valueOf(trackableMatcher.group(5)); if (trackCode != null && name != null && ctl != null && id != null) { - final TrackableLog entry = new TrackableLog(trackCode, name, id.intValue(), ctl.intValue()); + final TrackableLog entry = new TrackableLog(trackCode, name, id, ctl); Log.i("Trackable in inventory (#" + entry.ctl + "/" + entry.id + "): " + entry.trackCode + " - " + entry.name); trackableLogs.add(entry); diff --git a/main/src/cgeo/geocaching/files/GPXParser.java b/main/src/cgeo/geocaching/files/GPXParser.java index ec8c307..8a405fc 100644 --- a/main/src/cgeo/geocaching/files/GPXParser.java +++ b/main/src/cgeo/geocaching/files/GPXParser.java @@ -436,7 +436,7 @@ public abstract class GPXParser extends FileParser { @Override public void end(String watchList) { - cache.setOnWatchlist(Boolean.valueOf(watchList.trim()).booleanValue()); + cache.setOnWatchlist(Boolean.valueOf(watchList.trim())); } }); diff --git a/main/src/cgeo/geocaching/maps/PositionOverlay.java b/main/src/cgeo/geocaching/maps/PositionOverlay.java index a09b6de..ba39cd2 100644 --- a/main/src/cgeo/geocaching/maps/PositionOverlay.java +++ b/main/src/cgeo/geocaching/maps/PositionOverlay.java @@ -210,7 +210,7 @@ public class PositionOverlay implements GeneralOverlay { marginTop = center.y - heightArrowHalf; Matrix matrix = new Matrix(); - matrix.setRotate(heading.floatValue(), widthArrowHalf, heightArrowHalf); + matrix.setRotate(heading, widthArrowHalf, heightArrowHalf); matrix.postTranslate(marginLeft, marginTop); canvas.drawBitmap(arrow, matrix, null); diff --git a/tests/src/cgeo/test/Compare.java b/tests/src/cgeo/test/Compare.java index 93eef99..817addc 100644 --- a/tests/src/cgeo/test/Compare.java +++ b/tests/src/cgeo/test/Compare.java @@ -42,7 +42,7 @@ public abstract class Compare { assertTrue(actual.getAttributes().contains(attribute)); } for (LogType logType : expected.getLogCounts().keySet()) { - assertTrue(actual.getLogCounts().get(logType).intValue() >= expected.getLogCounts().get(logType).intValue()); + assertTrue(actual.getLogCounts().get(logType) >= expected.getLogCounts().get(logType)); } // The inventories can differ too often, therefore we don't compare them. Also, the personal note |