findbugs: unchecked casts

11 files changed, 43 insertions, 51 deletions

diff --git a/main/src/cgeo/geocaching/Geocache.java b/main/src/cgeo/geocaching/Geocache.java
index 2c3f218..7aceed4 100644
--- a/main/src/cgeo/geocaching/Geocache.java
+++ b/main/src/cgeo/geocaching/Geocache.java
@@ -1,8 +1,7 @@
 package cgeo.geocaching;
 
-import cgeo.geocaching.activity.ActivityMixin;
-import cgeo.geocaching.activity.IAbstractActivity;
 import cgeo.geocaching.cgData.StorageLocation;
+import cgeo.geocaching.activity.ActivityMixin;
 import cgeo.geocaching.connector.ConnectorFactory;
 import cgeo.geocaching.connector.IConnector;
 import cgeo.geocaching.connector.ILoggingManager;
@@ -448,16 +447,16 @@ public class Geocache implements ICache, IWaypoint {
         return cacheType.getValue().isEvent();
     }
 
-    public void logVisit(final IAbstractActivity fromActivity) {
+    public void logVisit(final Activity fromActivity) {
         if (!getConnector().canLog(this)) {
-            fromActivity.showToast(((Activity) fromActivity).getResources().getString(R.string.err_cannot_log_visit));
+            ActivityMixin.showToast(fromActivity, fromActivity.getResources().getString(R.string.err_cannot_log_visit));
             return;
         }
-        final Intent logVisitIntent = new Intent((Activity) fromActivity, LogCacheActivity.class);
+        final Intent logVisitIntent = new Intent(fromActivity, LogCacheActivity.class);
         logVisitIntent.putExtra(LogCacheActivity.EXTRAS_ID, cacheId);
         logVisitIntent.putExtra(LogCacheActivity.EXTRAS_GEOCODE, geocode);
 
-        ((Activity) fromActivity).startActivity(logVisitIntent);
+        fromActivity.startActivity(logVisitIntent);
     }
 
     public void logOffline(final Activity fromActivity, final LogType logType) {
@@ -569,7 +568,7 @@ public class Geocache implements ICache, IWaypoint {
         return getConnector().supportsOwnCoordinates();
     }
 
-    public ILoggingManager getLoggingManager(Activity activity) {
+    public ILoggingManager getLoggingManager(final LogCacheActivity activity) {
         return getConnector().getLoggingManager(activity, this);
     }
 
diff --git a/main/src/cgeo/geocaching/activity/AbstractListActivity.java b/main/src/cgeo/geocaching/activity/AbstractListActivity.java
index 47c747f..93e9b7f 100644
--- a/main/src/cgeo/geocaching/activity/AbstractListActivity.java
+++ b/main/src/cgeo/geocaching/activity/AbstractListActivity.java
@@ -1,7 +1,6 @@
 package cgeo.geocaching.activity;
 
 import cgeo.geocaching.cgeoapplication;
-import cgeo.geocaching.compatibility.Compatibility;
 
 import android.content.res.Resources;
 import android.graphics.drawable.Drawable;
@@ -77,7 +76,7 @@ public abstract class AbstractListActivity extends FragmentListActivity implemen
 
     @Override
     public void invalidateOptionsMenuCompatible() {
-        Compatibility.invalidateOptionsMenu(this);
+        ActivityMixin.invalidateOptionsMenu(this);
     }
 
     public void onCreate(Bundle savedInstanceState, int resourceLayoutID) {
diff --git a/main/src/cgeo/geocaching/apps/cachelist/CacheListAppFactory.java b/main/src/cgeo/geocaching/apps/cachelist/CacheListAppFactory.java
index b747eee..ca06c52 100644
--- a/main/src/cgeo/geocaching/apps/cachelist/CacheListAppFactory.java
+++ b/main/src/cgeo/geocaching/apps/cachelist/CacheListAppFactory.java
@@ -1,9 +1,9 @@
 package cgeo.geocaching.apps.cachelist;
 
+import cgeo.geocaching.Geocache;
 import cgeo.geocaching.R;
 import cgeo.geocaching.SearchResult;
-import cgeo.geocaching.Geocache;
-import cgeo.geocaching.activity.IAbstractActivity;
+import cgeo.geocaching.activity.ActivityMixin;
 import cgeo.geocaching.apps.AbstractAppFactory;
 import cgeo.geocaching.utils.Log;
 
@@ -55,13 +55,13 @@ public final class CacheListAppFactory extends AbstractAppFactory {
         }
     }
 
-    public static boolean onMenuItemSelected(final MenuItem item, final List<Geocache> caches, final IAbstractActivity activity,
+    public static boolean onMenuItemSelected(final MenuItem item, final List<Geocache> caches, final Activity activity,
             final SearchResult search) {
         final CacheListApp app = (CacheListApp) getAppFromMenuItem(item, LazyHolder.apps);
         if (app != null) {
             try {
-                boolean result = app.invoke(caches, (Activity) activity, search);
-                activity.invalidateOptionsMenuCompatible();
+                boolean result = app.invoke(caches, activity, search);
+                ActivityMixin.invalidateOptionsMenu(activity);
                 return result;
             } catch (Exception e) {
                 Log.e("CacheListAppFactory.onMenuItemSelected", e);
diff --git a/main/src/cgeo/geocaching/connector/AbstractConnector.java b/main/src/cgeo/geocaching/connector/AbstractConnector.java
index 28ad12b..b93cda0 100644
--- a/main/src/cgeo/geocaching/connector/AbstractConnector.java
+++ b/main/src/cgeo/geocaching/connector/AbstractConnector.java
@@ -1,13 +1,12 @@
 package cgeo.geocaching.connector;
 
 import cgeo.geocaching.Geocache;
+import cgeo.geocaching.LogCacheActivity;
 import cgeo.geocaching.R;
 import cgeo.geocaching.geopoint.Geopoint;
 
 import org.apache.commons.lang3.StringUtils;
 
-import android.app.Activity;
-
 public abstract class AbstractConnector implements IConnector {
 
     @Override
@@ -79,7 +78,7 @@ public abstract class AbstractConnector implements IConnector {
     }
 
     @Override
-    public ILoggingManager getLoggingManager(Activity activity, Geocache cache) {
+    public ILoggingManager getLoggingManager(final LogCacheActivity activity, final Geocache cache) {
         return new NoLoggingManager();
     }
 
diff --git a/main/src/cgeo/geocaching/connector/IConnector.java b/main/src/cgeo/geocaching/connector/IConnector.java
index 0c175cd..4ab7bde 100644
--- a/main/src/cgeo/geocaching/connector/IConnector.java
+++ b/main/src/cgeo/geocaching/connector/IConnector.java
@@ -2,10 +2,9 @@ package cgeo.geocaching.connector;
 
 import cgeo.geocaching.Geocache;
 import cgeo.geocaching.ICache;
+import cgeo.geocaching.LogCacheActivity;
 import cgeo.geocaching.geopoint.Geopoint;
 
-import android.app.Activity;
-
 public interface IConnector {
     /**
      * get name for display (currently only used in links)
@@ -87,7 +86,7 @@ public interface IConnector {
      *
      * @return
      */
-    public ILoggingManager getLoggingManager(Activity activity, Geocache cache);
+    public ILoggingManager getLoggingManager(final LogCacheActivity activity, final Geocache cache);
 
     /**
      * get host name of the connector server for dynamic loading of data
diff --git a/main/src/cgeo/geocaching/connector/gc/GCConnector.java b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
index 835359a..9ac9c9d 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCConnector.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
@@ -2,6 +2,7 @@ package cgeo.geocaching.connector.gc;
 
 import cgeo.geocaching.Geocache;
 import cgeo.geocaching.ICache;
+import cgeo.geocaching.LogCacheActivity;
 import cgeo.geocaching.R;
 import cgeo.geocaching.SearchResult;
 import cgeo.geocaching.cgData;
@@ -15,15 +16,14 @@ import cgeo.geocaching.connector.capability.ISearchByViewPort;
 import cgeo.geocaching.enumerations.StatusCode;
 import cgeo.geocaching.geopoint.Geopoint;
 import cgeo.geocaching.geopoint.Viewport;
-import cgeo.geocaching.settings.SettingsActivity;
 import cgeo.geocaching.settings.Settings;
+import cgeo.geocaching.settings.SettingsActivity;
 import cgeo.geocaching.utils.CancellableHandler;
 import cgeo.geocaching.utils.Log;
 
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.lang3.StringUtils;
 
-import android.app.Activity;
 import android.content.Context;
 import android.os.Handler;
 
@@ -104,7 +104,7 @@ public class GCConnector extends AbstractConnector implements ISearchByGeocode,
     }
 
     @Override
-    public ILoggingManager getLoggingManager(Activity activity, Geocache cache) {
+    public ILoggingManager getLoggingManager(final LogCacheActivity activity, final Geocache cache) {
         return new GCLoggingManager(activity, cache);
     }
 
diff --git a/main/src/cgeo/geocaching/connector/gc/GCLoggingManager.java b/main/src/cgeo/geocaching/connector/gc/GCLoggingManager.java
index 2aa5c75..dfb1f55 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCLoggingManager.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCLoggingManager.java
@@ -3,7 +3,6 @@ package cgeo.geocaching.connector.gc;
 import cgeo.geocaching.Geocache;
 import cgeo.geocaching.LogCacheActivity;
 import cgeo.geocaching.R;
-import cgeo.geocaching.settings.Settings;
 import cgeo.geocaching.TrackableLog;
 import cgeo.geocaching.activity.ActivityMixin;
 import cgeo.geocaching.connector.ILoggingManager;
@@ -13,12 +12,12 @@ import cgeo.geocaching.enumerations.LogType;
 import cgeo.geocaching.enumerations.StatusCode;
 import cgeo.geocaching.loaders.UrlLoader;
 import cgeo.geocaching.network.Parameters;
+import cgeo.geocaching.settings.Settings;
 import cgeo.geocaching.utils.Log;
 
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.tuple.ImmutablePair;
 
-import android.app.Activity;
 import android.net.Uri;
 import android.os.Bundle;
 import android.support.v4.app.LoaderManager;
@@ -38,8 +37,8 @@ public class GCLoggingManager implements ILoggingManager, LoaderManager.LoaderCa
     private List<LogType> possibleLogTypes;
     private boolean hasLoaderError = true;
 
-    public GCLoggingManager(Activity activity, Geocache cache) {
-        this.activity = (LogCacheActivity) activity;
+    public GCLoggingManager(final LogCacheActivity activity, final Geocache cache) {
+        this.activity = activity;
         this.cache = cache;
     }
 
diff --git a/main/src/cgeo/geocaching/connector/oc/OCApiLiveConnector.java b/main/src/cgeo/geocaching/connector/oc/OCApiLiveConnector.java
index d35e54b..663bbf7 100644
--- a/main/src/cgeo/geocaching/connector/oc/OCApiLiveConnector.java
+++ b/main/src/cgeo/geocaching/connector/oc/OCApiLiveConnector.java
@@ -1,6 +1,7 @@
 package cgeo.geocaching.connector.oc;
 
 import cgeo.geocaching.Geocache;
+import cgeo.geocaching.LogCacheActivity;
 import cgeo.geocaching.SearchResult;
 import cgeo.geocaching.cgData;
 import cgeo.geocaching.cgeoapplication;
@@ -16,7 +17,6 @@ import cgeo.geocaching.utils.CryptUtils;
 
 import org.apache.commons.lang3.StringUtils;
 
-import android.app.Activity;
 import android.content.Context;
 import android.os.Handler;
 
@@ -110,7 +110,7 @@ public class OCApiLiveConnector extends OCApiConnector implements ISearchByCente
     }
 
     @Override
-    public ILoggingManager getLoggingManager(Activity activity, Geocache cache) {
+    public ILoggingManager getLoggingManager(final LogCacheActivity activity, final Geocache cache) {
         return new OkapiLoggingManager(activity, this, cache);
     }
 
diff --git a/main/src/cgeo/geocaching/connector/oc/OkapiLoggingManager.java b/main/src/cgeo/geocaching/connector/oc/OkapiLoggingManager.java
index c995975..9ffe7a2 100644
--- a/main/src/cgeo/geocaching/connector/oc/OkapiLoggingManager.java
+++ b/main/src/cgeo/geocaching/connector/oc/OkapiLoggingManager.java
@@ -9,7 +9,6 @@ import cgeo.geocaching.connector.LogResult;
 import cgeo.geocaching.enumerations.LogType;
 import cgeo.geocaching.enumerations.StatusCode;
 
-import android.app.Activity;
 import android.net.Uri;
 
 import java.util.Arrays;
@@ -26,10 +25,10 @@ public class OkapiLoggingManager implements ILoggingManager {
     private final static List<LogType> standardLogTypes = Arrays.asList(LogType.FOUND_IT, LogType.DIDNT_FIND_IT, LogType.NOTE);
     private final static List<LogType> eventLogTypes = Arrays.asList(LogType.WILL_ATTEND, LogType.ATTENDED, LogType.NOTE);
 
-    public OkapiLoggingManager(Activity activity, OCApiLiveConnector connector, Geocache cache) {
+    public OkapiLoggingManager(final LogCacheActivity activity, OCApiLiveConnector connector, Geocache cache) {
         this.connector = connector;
         this.cache = cache;
-        this.activity = (LogCacheActivity) activity;
+        this.activity = activity;
     }
 
     @Override
diff --git a/main/src/cgeo/geocaching/files/GPXImporter.java b/main/src/cgeo/geocaching/files/GPXImporter.java
index a1c04d7..3f11c26 100644
--- a/main/src/cgeo/geocaching/files/GPXImporter.java
+++ b/main/src/cgeo/geocaching/files/GPXImporter.java
@@ -3,12 +3,12 @@ package cgeo.geocaching.files;
 import cgeo.geocaching.Geocache;
 import cgeo.geocaching.R;
 import cgeo.geocaching.SearchResult;
-import cgeo.geocaching.settings.Settings;
 import cgeo.geocaching.StaticMapsProvider;
 import cgeo.geocaching.cgData;
-import cgeo.geocaching.activity.IAbstractActivity;
+import cgeo.geocaching.activity.ActivityMixin;
 import cgeo.geocaching.activity.Progress;
 import cgeo.geocaching.enumerations.LoadFlags;
+import cgeo.geocaching.settings.Settings;
 import cgeo.geocaching.utils.CancellableHandler;
 import cgeo.geocaching.utils.Log;
 
@@ -17,7 +17,6 @@ import org.apache.commons.lang3.StringUtils;
 import android.app.Activity;
 import android.app.ProgressDialog;
 import android.content.ContentResolver;
-import android.content.Context;
 import android.content.Intent;
 import android.content.res.Resources;
 import android.net.Uri;
@@ -61,13 +60,13 @@ public class GPXImporter {
 
     private final Resources res;
     private final int listId;
-    private final IAbstractActivity fromActivity;
+    private final Activity fromActivity;
     private final Handler importFinishedHandler;
 
-    public GPXImporter(final IAbstractActivity fromActivity, final int listId, final Handler importFinishedHandler) {
+    public GPXImporter(final Activity fromActivity, final int listId, final Handler importFinishedHandler) {
         this.listId = listId;
         this.fromActivity = fromActivity;
-        res = ((Activity) fromActivity).getResources();
+        res = fromActivity.getResources();
         this.importFinishedHandler = importFinishedHandler;
     }
 
@@ -91,8 +90,8 @@ public class GPXImporter {
      * Import GPX provided via intent of activity that instantiated this GPXImporter.
      */
     public void importGPX() {
-        final ContentResolver contentResolver = ((Activity) fromActivity).getContentResolver();
-        final Intent intent = ((Activity) fromActivity).getIntent();
+        final ContentResolver contentResolver = fromActivity.getContentResolver();
+        final Intent intent = fromActivity.getIntent();
         final Uri uri = intent.getData();
 
         String mimeType = intent.getType();
@@ -397,7 +396,7 @@ public class GPXImporter {
             switch (msg.what) {
                 case IMPORT_STEP_START:
                     final Message cancelMessage = importStepHandler.obtainMessage(IMPORT_STEP_CANCEL);
-                    progress.show((Context) fromActivity, res.getString(R.string.gpx_import_title_reading_file), res.getString(R.string.gpx_import_loading_caches), ProgressDialog.STYLE_HORIZONTAL, cancelMessage);
+                    progress.show(fromActivity, res.getString(R.string.gpx_import_title_reading_file), res.getString(R.string.gpx_import_loading_caches), ProgressDialog.STYLE_HORIZONTAL, cancelMessage);
                     break;
 
                 case IMPORT_STEP_READ_FILE:
@@ -409,7 +408,7 @@ public class GPXImporter {
                 case IMPORT_STEP_STORE_STATIC_MAPS:
                     progress.dismiss();
                     final Message skipMessage = importStepHandler.obtainMessage(IMPORT_STEP_STATIC_MAPS_SKIPPED, msg.arg2, 0);
-                    progress.show((Context) fromActivity, res.getString(R.string.gpx_import_title_static_maps), res.getString(R.string.gpx_import_store_static_maps), ProgressDialog.STYLE_HORIZONTAL, skipMessage);
+                    progress.show(fromActivity, res.getString(R.string.gpx_import_title_static_maps), res.getString(R.string.gpx_import_store_static_maps), ProgressDialog.STYLE_HORIZONTAL, skipMessage);
                     progress.setMaxProgressAndReset(msg.arg2);
                     break;
 
@@ -418,19 +417,19 @@ public class GPXImporter {
                     progressHandler.cancel();
                     final StringBuilder bufferSkipped = new StringBuilder(20);
                     bufferSkipped.append(res.getString(R.string.gpx_import_static_maps_skipped)).append(", ").append(msg.arg1).append(' ').append(res.getString(R.string.gpx_import_caches_imported));
-                    fromActivity.helpDialog(res.getString(R.string.gpx_import_title_caches_imported), bufferSkipped.toString());
+                    ActivityMixin.helpDialog(fromActivity, res.getString(R.string.gpx_import_title_caches_imported), bufferSkipped.toString());
                     importFinished();
                     break;
 
                 case IMPORT_STEP_FINISHED:
                     progress.dismiss();
-                    fromActivity.helpDialog(res.getString(R.string.gpx_import_title_caches_imported), msg.arg1 + " " + res.getString(R.string.gpx_import_caches_imported));
+                    ActivityMixin.helpDialog(fromActivity, res.getString(R.string.gpx_import_title_caches_imported), msg.arg1 + " " + res.getString(R.string.gpx_import_caches_imported));
                     importFinished();
                     break;
 
                 case IMPORT_STEP_FINISHED_WITH_ERROR:
                     progress.dismiss();
-                    fromActivity.helpDialog(res.getString(R.string.gpx_import_title_caches_import_failed), res.getString(msg.arg1) + "\n\n" + msg.obj);
+                    ActivityMixin.helpDialog(fromActivity, res.getString(R.string.gpx_import_title_caches_import_failed), res.getString(msg.arg1) + "\n\n" + msg.obj);
                     importFinished();
                     break;
 
@@ -442,7 +441,7 @@ public class GPXImporter {
                 case IMPORT_STEP_CANCELED:
                     final StringBuilder bufferCanceled = new StringBuilder(20);
                     bufferCanceled.append(res.getString(R.string.gpx_import_canceled));
-                    fromActivity.showShortToast(bufferCanceled.toString());
+                    ActivityMixin.showShortToast(fromActivity, bufferCanceled.toString());
                     importFinished();
                     break;
 
diff --git a/main/src/cgeo/geocaching/ui/LoggingUI.java b/main/src/cgeo/geocaching/ui/LoggingUI.java
index 0ee724a..c2e2d24 100644
--- a/main/src/cgeo/geocaching/ui/LoggingUI.java
+++ b/main/src/cgeo/geocaching/ui/LoggingUI.java
@@ -3,10 +3,9 @@ package cgeo.geocaching.ui;
 import cgeo.geocaching.Geocache;
 import cgeo.geocaching.LogEntry;
 import cgeo.geocaching.R;
-import cgeo.geocaching.settings.Settings;
 import cgeo.geocaching.cgData;
-import cgeo.geocaching.activity.IAbstractActivity;
 import cgeo.geocaching.enumerations.LogType;
+import cgeo.geocaching.settings.Settings;
 
 import android.app.Activity;
 import android.app.AlertDialog;
@@ -61,13 +60,13 @@ public class LoggingUI extends AbstractUIFactory {
         }
     }
 
-    public static boolean onMenuItemSelected(final MenuItem item, IAbstractActivity activity, Geocache cache) {
+    public static boolean onMenuItemSelected(final MenuItem item, final Activity activity, final Geocache cache) {
         switch (item.getItemId()) {
             case R.id.menu_log_visit:
                 cache.logVisit(activity);
                 return true;
             case R.id.menu_log_visit_offline:
-                showOfflineMenu(cache, (Activity) activity);
+                showOfflineMenu(cache, activity);
                 return true;
             default:
                 return false;
@@ -100,7 +99,7 @@ public class LoggingUI extends AbstractUIFactory {
                 if (logTypeEntry.logType == null) {
                     switch (logTypeEntry.specialLogType) {
                         case LOG_CACHE:
-                            cache.logVisit((IAbstractActivity) activity);
+                            cache.logVisit(activity);
                             break;
 
                         case CLEAR_LOG: