aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2011-09-22 22:23:28 +0200
committerSamuel Tardieu <sam@rfc1149.net>2011-09-26 08:55:08 +0200
commit9372dd0086c295fd282f8b821aab7e60caf2a70d (patch)
tree2c4dc719ade381713b014ddc1e0091677f3032e3
parent8c1c51950a9c7f9bf078fe9dfcc38cd042347bbf (diff)
downloadcgeo-9372dd0086c295fd282f8b821aab7e60caf2a70d.zip
cgeo-9372dd0086c295fd282f8b821aab7e60caf2a70d.tar.gz
cgeo-9372dd0086c295fd282f8b821aab7e60caf2a70d.tar.bz2
Remove unused requestId
It looks like it used for nothing but logs.
-rw-r--r--main/src/cgeo/geocaching/cgBase.java22
-rw-r--r--main/src/cgeo/geocaching/cgeocaches.java2
-rw-r--r--main/src/cgeo/geocaching/cgeoinit.java2
3 files changed, 8 insertions, 18 deletions
diff --git a/main/src/cgeo/geocaching/cgBase.java b/main/src/cgeo/geocaching/cgBase.java
index eb61a05..67d745f 100644
--- a/main/src/cgeo/geocaching/cgBase.java
+++ b/main/src/cgeo/geocaching/cgBase.java
@@ -638,7 +638,7 @@ public class cgBase {
}
if (recaptchaJsParam != null) {
- final String recaptchaJs = request(URI_GOOGLE_RECAPTCHA, "GET", "k=" + urlencode_rfc3986(recaptchaJsParam.trim()), 0, true).getData();
+ final String recaptchaJs = request(URI_GOOGLE_RECAPTCHA, "GET", "k=" + urlencode_rfc3986(recaptchaJsParam.trim()), true).getData();
if (StringUtils.isNotBlank(recaptchaJs)) {
final Matcher matcherRecaptchaChallenge = patternRecaptchaChallenge.matcher(recaptchaJs);
@@ -915,7 +915,7 @@ public class cgBase {
}
params.append("&ctl00%24ContentBody%24uxDownloadLoc=Download+Waypoints");
- final String coordinates = request(URI_GC_SEEK_NEAREST, "POST", params.toString(), 0, true).getData();
+ final String coordinates = request(URI_GC_SEEK_NEAREST, "POST", params.toString(), true).getData();
if (StringUtils.isNotBlank(coordinates)) {
if (coordinates.contains("You have not agreed to the license agreement. The license agreement is required before you can start downloading GPX or LOC files from Geocaching.com")) {
@@ -3578,25 +3578,15 @@ public class cgBase {
}
public cgResponse request(final Uri uri, String method, Map<String, String> params, boolean xContentType, boolean my, boolean addF) {
- // prepare parameters
final String paramsDone = prepareParameters(params, my, addF);
- return request(uri, method, paramsDone, 0, xContentType);
+ return request(uri, method, paramsDone, xContentType);
}
- public cgResponse request(final Uri uri, String method, Map<String, String> params, int requestId, boolean xContentType, boolean my, boolean addF) {
- final String paramsDone = prepareParameters(params, my, addF);
- return request(uri, method, paramsDone, requestId, xContentType);
- }
-
- public cgResponse request(final Uri uri, String method, String params, int requestId, Boolean xContentType) {
+ public cgResponse request(final Uri uri, String method, String params, Boolean xContentType) {
URL u = null;
int httpCode = -1;
String httpMessage = null;
- if (requestId == 0) {
- requestId = (int) (Math.random() * 1000);
- }
-
if (method == null || (method.equalsIgnoreCase("GET") == false && method.equalsIgnoreCase("POST") == false)) {
method = "POST";
} else {
@@ -3693,7 +3683,7 @@ public class cgBase {
httpMessage = connection.getResponseMessage();
final String paramsLog = params.replaceAll(passMatch, "password=***");
- Log.i(cgSettings.tag + "|" + requestId, "[" + method + " " + (params.length() / 1024) + "k | " + httpCode + " | " + (buffer.length() / 1024) + "k] Downloaded " + uri + "?" + paramsLog);
+ Log.i(cgSettings.tag, "[" + method + " " + (params.length() / 1024) + "k | " + httpCode + " | " + (buffer.length() / 1024) + "k] Downloaded " + uri + "?" + paramsLog);
connection.disconnect();
br.close();
@@ -4436,7 +4426,7 @@ public class cgBase {
}
public String getMapUserToken(Handler noTokenHandler) {
- final cgResponse response = request(URI_GC_MAP_DEFAULT, "GET", "", 0, false);
+ final cgResponse response = request(URI_GC_MAP_DEFAULT, "GET", "", false);
final String data = response.getData();
String usertoken = null;
diff --git a/main/src/cgeo/geocaching/cgeocaches.java b/main/src/cgeo/geocaching/cgeocaches.java
index 5499861..ac5aeb1 100644
--- a/main/src/cgeo/geocaching/cgeocaches.java
+++ b/main/src/cgeo/geocaching/cgeocaches.java
@@ -2085,7 +2085,7 @@ public class cgeocaches extends AbstractListActivity {
if (deviceCode == null) {
deviceCode = "";
}
- cgResponse responseFromWeb = base.request(URI_SEND2CGEO_READ, "GET", "code=" + cgBase.urlencode_rfc3986(deviceCode), 0, true);
+ cgResponse responseFromWeb = base.request(URI_SEND2CGEO_READ, "GET", "code=" + cgBase.urlencode_rfc3986(deviceCode), true);
if (responseFromWeb.getStatusCode() == 200) {
if (responseFromWeb.getData().length() > 2) {
diff --git a/main/src/cgeo/geocaching/cgeoinit.java b/main/src/cgeo/geocaching/cgeoinit.java
index 3f32cef..870c5f9 100644
--- a/main/src/cgeo/geocaching/cgeoinit.java
+++ b/main/src/cgeo/geocaching/cgeoinit.java
@@ -1048,7 +1048,7 @@ public class cgeoinit extends AbstractActivity {
String params = "name=" + cgBase.urlencode_rfc3986(nam) + "&code=" + cgBase.urlencode_rfc3986(cod);
- cgResponse response = base.request(URI_SEND2CGEO_AUTH, "GET", params, 0, true);
+ cgResponse response = base.request(URI_SEND2CGEO_AUTH, "GET", params, true);
if (response.getStatusCode() == 200)
{