refactoring: findbugs cleanup

* don't catch raw exceptions

24 files changed, 75 insertions, 75 deletions

diff --git a/main/src/cgeo/geocaching/AbstractPopupActivity.java b/main/src/cgeo/geocaching/AbstractPopupActivity.java
index 1cf0353..03f0680 100644
--- a/main/src/cgeo/geocaching/AbstractPopupActivity.java
+++ b/main/src/cgeo/geocaching/AbstractPopupActivity.java
@@ -64,7 +64,7 @@ public abstract class AbstractPopupActivity extends AbstractActivity {
                     cacheDistance.bringToFront();
                 }
                 onUpdateGeoData(geo);
-            } catch (final Exception e) {
+            } catch (final RuntimeException e) {
                 Log.w("Failed to UpdateLocation location.");
             }
         }
@@ -209,7 +209,7 @@ public abstract class AbstractPopupActivity extends AbstractActivity {
 
             menu.findItem(R.id.menu_default_navigation).setTitle(NavigationAppFactory.getDefaultNavigationApplication().getName());
             LoggingUI.onPrepareOptionsMenu(menu, cache);
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // nothing
         }
 
diff --git a/main/src/cgeo/geocaching/CacheDetailActivity.java b/main/src/cgeo/geocaching/CacheDetailActivity.java
index e4bed64..1fc20ec 100644
--- a/main/src/cgeo/geocaching/CacheDetailActivity.java
+++ b/main/src/cgeo/geocaching/CacheDetailActivity.java
@@ -291,7 +291,7 @@ public class CacheDetailActivity extends AbstractViewPagerActivity<CacheDetailAc
                 title = geocode;
             }
             progress.show(this, title, res.getString(R.string.cache_dialog_loading_details), true, loadCacheHandler.cancelMessage());
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // nothing, we lost the window
         }
 
@@ -422,7 +422,7 @@ public class CacheDetailActivity extends AbstractViewPagerActivity<CacheDetailAc
                                 break;
                             }
                         }
-                    } catch (final Exception e) {
+                    } catch (final RuntimeException e) {
                     }
                 }
                 break;
diff --git a/main/src/cgeo/geocaching/CompassActivity.java b/main/src/cgeo/geocaching/CompassActivity.java
index 002f00e..c8579e1 100644
--- a/main/src/cgeo/geocaching/CompassActivity.java
+++ b/main/src/cgeo/geocaching/CompassActivity.java
@@ -282,7 +282,7 @@ public class CompassActivity extends AbstractActivity {
                 if (!Settings.isUseCompass() || geo.getSpeed() > 5) { // use GPS when speed is higher than 18 km/h
                     updateNorthHeading(geo.getBearing());
                 }
-            } catch (Exception e) {
+            } catch (RuntimeException e) {
                 Log.w("Failed to LocationUpdater location.");
             }
         }
diff --git a/main/src/cgeo/geocaching/EditWaypointActivity.java b/main/src/cgeo/geocaching/EditWaypointActivity.java
index 56ee959..59666e9 100644
--- a/main/src/cgeo/geocaching/EditWaypointActivity.java
+++ b/main/src/cgeo/geocaching/EditWaypointActivity.java
@@ -114,7 +114,7 @@ public class EditWaypointActivity extends AbstractActivity {
                 if (own) {
                     initializeWaypointTypeSelector();
                 }
-            } catch (Exception e) {
+            } catch (RuntimeException e) {
                 Log.e("EditWaypointActivity.loadWaypointHandler", e);
             } finally {
                 if (waitDialog != null) {
diff --git a/main/src/cgeo/geocaching/LogCacheActivity.java b/main/src/cgeo/geocaching/LogCacheActivity.java
index 207dce5..3ed77e2 100644
--- a/main/src/cgeo/geocaching/LogCacheActivity.java
+++ b/main/src/cgeo/geocaching/LogCacheActivity.java
@@ -570,7 +570,7 @@ public class LogCacheActivity extends AbstractLoggingActivity implements DateDia
                 }
 
                 return logResult.getPostLogResult();
-            } catch (Exception e) {
+            } catch (RuntimeException e) {
                 Log.e("VisitCacheActivity.Poster.doInBackgroundInternal", e);
             }
 
diff --git a/main/src/cgeo/geocaching/MainActivity.java b/main/src/cgeo/geocaching/MainActivity.java
index c7c28f3..b6f267a 100644
--- a/main/src/cgeo/geocaching/MainActivity.java
+++ b/main/src/cgeo/geocaching/MainActivity.java
@@ -47,6 +47,7 @@ import android.widget.ImageView;
 import android.widget.LinearLayout;
 import android.widget.TextView;
 
+import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -141,7 +142,7 @@ public class MainActivity extends AbstractActivity {
 
                     navLocation.setText(StringUtils.join(addressParts, ", "));
                 }
-            } catch (Exception e) {
+            } catch (RuntimeException e) {
                 // nothing
             }
 
@@ -721,7 +722,7 @@ public class MainActivity extends AbstractActivity {
                 final Geocoder geocoder = new Geocoder(MainActivity.this, Locale.getDefault());
                 final Geopoint coords = app.currentGeo().getCoords();
                 addresses = geocoder.getFromLocation(coords.getLatitude(), coords.getLongitude(), 1);
-            } catch (Exception e) {
+            } catch (IOException e) {
                 Log.i("Failed to obtain address");
             }
 
diff --git a/main/src/cgeo/geocaching/NavigateAnyPointActivity.java b/main/src/cgeo/geocaching/NavigateAnyPointActivity.java
index 741414b..87d7ba7 100644
--- a/main/src/cgeo/geocaching/NavigateAnyPointActivity.java
+++ b/main/src/cgeo/geocaching/NavigateAnyPointActivity.java
@@ -331,7 +331,7 @@ public class NavigateAnyPointActivity extends AbstractActivity {
             menu.findItem(R.id.menu_caches_around).setVisible(visible);
 
             menu.findItem(R.id.menu_clear_history).setEnabled(!getHistoryOfSearchedLocations().isEmpty());
-        } catch (Exception e) {
+        } catch (RuntimeException e) {
             // nothing
         }
 
@@ -454,7 +454,7 @@ public class NavigateAnyPointActivity extends AbstractActivity {
             try {
                 latButton.setHint(geo.getCoords().format(GeopointFormatter.Format.LAT_DECMINUTE_RAW));
                 lonButton.setHint(geo.getCoords().format(GeopointFormatter.Format.LON_DECMINUTE_RAW));
-            } catch (final Exception e) {
+            } catch (final RuntimeException e) {
                 Log.w("Failed to update location.");
             }
         }
diff --git a/main/src/cgeo/geocaching/SearchActivity.java b/main/src/cgeo/geocaching/SearchActivity.java
index 57b391f..8f58bcd 100644
--- a/main/src/cgeo/geocaching/SearchActivity.java
+++ b/main/src/cgeo/geocaching/SearchActivity.java
@@ -238,7 +238,7 @@ public class SearchActivity extends AbstractActivity {
                         lonEdit.setHint(geo.getCoords().format(GeopointFormatter.Format.LON_DECMINUTE_RAW));
                     }
                 }
-            } catch (final Exception e) {
+            } catch (final RuntimeException e) {
                 Log.w("Failed to update location.");
             }
         }
diff --git a/main/src/cgeo/geocaching/UsefulAppsActivity.java b/main/src/cgeo/geocaching/UsefulAppsActivity.java
index 8093bba..41ea96e 100644
--- a/main/src/cgeo/geocaching/UsefulAppsActivity.java
+++ b/main/src/cgeo/geocaching/UsefulAppsActivity.java
@@ -50,7 +50,7 @@ public class UsefulAppsActivity extends AbstractActivity {
                 marketIntent.addFlags(Intent.FLAG_ACTIVITY_NO_HISTORY | Intent.FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET);
                 activity.startActivity(marketIntent);
 
-            } catch (Exception e) {
+            } catch (RuntimeException e) {
                 // market not available in standard emulator
             }
         }
diff --git a/main/src/cgeo/geocaching/apps/cache/navi/GoogleMapsApp.java b/main/src/cgeo/geocaching/apps/cache/navi/GoogleMapsApp.java
index 03fae9e..4cbfa00 100644
--- a/main/src/cgeo/geocaching/apps/cache/navi/GoogleMapsApp.java
+++ b/main/src/cgeo/geocaching/apps/cache/navi/GoogleMapsApp.java
@@ -27,7 +27,7 @@ class GoogleMapsApp extends AbstractPointNavigationApp {
             activity.startActivity(new Intent(Intent.ACTION_VIEW,
                     Uri.parse("geo:" + point.getLatitude() + "," + point.getLongitude())));
             return;
-        } catch (Exception e) {
+        } catch (RuntimeException e) {
             // nothing
         }
         Log.i("GoogleMapsApp.navigate: No maps application available.");
diff --git a/main/src/cgeo/geocaching/cgeocaches.java b/main/src/cgeo/geocaching/cgeocaches.java
index 59174f5..d1ea7c4 100644
--- a/main/src/cgeo/geocaching/cgeocaches.java
+++ b/main/src/cgeo/geocaching/cgeocaches.java
@@ -655,7 +655,7 @@ public class cgeocaches extends AbstractListActivity implements FilteredActivity
 
             setMenuItemLabel(menu, MENU_REMOVE_FROM_HISTORY, R.string.cache_remove_from_history, R.string.cache_clear_history);
             setMenuItemLabel(menu, MENU_EXPORT, R.string.export, R.string.export);
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             Log.e("cgeocaches.onPrepareOptionsMenu", e);
         }
 
diff --git a/main/src/cgeo/geocaching/connector/gc/GCMap.java b/main/src/cgeo/geocaching/connector/gc/GCMap.java
index 4fdde56..27d8a77 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCMap.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCMap.java
@@ -236,7 +236,9 @@ public class GCMap {
             }
             Log.d("Retrieved " + searchResult.getCount() + " caches for tile " + tile.toString());
 
-        } catch (Exception e) {
+        } catch (RuntimeException e) {
+            Log.e("GCMap.parseMapJSON", e);
+        } catch (JSONException e) {
             Log.e("GCMap.parseMapJSON", e);
         }
 
diff --git a/main/src/cgeo/geocaching/connector/gc/GCParser.java b/main/src/cgeo/geocaching/connector/gc/GCParser.java
index 34e48ab..3885679 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCParser.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCParser.java
@@ -147,7 +147,7 @@ public abstract class GCParser {
                         }
                     }
                 }
-            } catch (final Exception e) {
+            } catch (final RuntimeException e) {
                 // failed to parse GUID and/or Disabled
                 Log.w("GCParser.parseSearch: Failed to parse GUID and/or Disabled data");
             }
@@ -320,7 +320,7 @@ public abstract class GCParser {
 
                 LocParser.parseLoc(searchResult, coordinates);
 
-            } catch (final Exception e) {
+            } catch (final RuntimeException e) {
                 Log.e("GCParser.parseSearch.CIDs", e);
             }
         }
@@ -569,7 +569,7 @@ public abstract class GCParser {
                 }
                 cache.setAttributes(attributes);
             }
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // failed to parse cache attributes
             Log.w("GCParser.parseCache: Failed to parse cache attributes");
         }
@@ -598,7 +598,7 @@ public abstract class GCParser {
                 }
                 cache.addSpoiler(new Image(url, title, description));
             }
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // failed to parse cache spoilers
             Log.w("GCParser.parseCache: Failed to parse cache spoilers");
         }
@@ -632,7 +632,7 @@ public abstract class GCParser {
                     }
                 }
             }
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // failed to parse cache inventory
             Log.w("GCParser.parseCache: Failed to parse cache inventory (2)");
         }
@@ -654,7 +654,7 @@ public abstract class GCParser {
                     }
                 }
             }
-        } catch (final Exception e) {
+        } catch (final NumberFormatException e) {
             // failed to parse logs
             Log.w("GCParser.parseCache: Failed to parse cache log count");
         }
@@ -1083,7 +1083,7 @@ public abstract class GCParser {
 
                 page = Network.getResponseData(Network.postRequest(uri, params));
             }
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             Log.e("GCParser.postLog.confim", e);
         }
 
@@ -1396,7 +1396,7 @@ public abstract class GCParser {
                 trackable.setOwnerGuid(matcherOwner.group(1));
                 trackable.setOwner(matcherOwner.group(2).trim());
             }
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // failed to parse trackable owner name
             Log.w("GCParser.parseTrackable: Failed to parse trackable owner name");
         }
@@ -1427,7 +1427,7 @@ public abstract class GCParser {
             if (TextUtils.matches(page, GCConstants.PATTERN_TRACKABLE_SPOTTEDOWNER)) {
                 trackable.setSpottedType(Trackable.SPOTTED_OWNER);
             }
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // failed to parse trackable last known place
             Log.w("GCParser.parseTrackable: Failed to parse trackable last known place");
         }
@@ -1476,7 +1476,7 @@ public abstract class GCParser {
                     trackable.setDetails(convertLinks(details));
                 }
             }
-        } catch (final Exception e) {
+        } catch (final RuntimeException e) {
             // failed to parse trackable details & image
             Log.w("GCParser.parseTrackable: Failed to parse trackable details & image");
         }
diff --git a/main/src/cgeo/geocaching/connector/gc/SearchHandler.java b/main/src/cgeo/geocaching/connector/gc/SearchHandler.java
index 4358399..795ed2f 100644
--- a/main/src/cgeo/geocaching/connector/gc/SearchHandler.java
+++ b/main/src/cgeo/geocaching/connector/gc/SearchHandler.java
@@ -91,7 +91,7 @@ public class SearchHandler extends Handler {
 
                 dlg.create().show();
             }
-        } catch (Exception e) {
+        } catch (MalformedURLException e) {
             Log.e("Error in reCAPTCHA handler", e);
         }
     }
diff --git a/main/src/cgeo/geocaching/export/GpxExport.java b/main/src/cgeo/geocaching/export/GpxExport.java
index 821a3f6..36e43a0 100644
--- a/main/src/cgeo/geocaching/export/GpxExport.java
+++ b/main/src/cgeo/geocaching/export/GpxExport.java
@@ -141,7 +141,7 @@ class GpxExport extends AbstractExport {
                         ExportTask.this.publishProgress(countExported);
                     }
                 });
-            } catch (final Exception e) {
+            } catch (final IOException e) {
                 Log.e("GpxExport.ExportTask export", e);
 
                 if (writer != null) {
diff --git a/main/src/cgeo/geocaching/files/GPXParser.java b/main/src/cgeo/geocaching/files/GPXParser.java
index 7ea0a39..3358759 100644
--- a/main/src/cgeo/geocaching/files/GPXParser.java
+++ b/main/src/cgeo/geocaching/files/GPXParser.java
@@ -272,7 +272,7 @@ public abstract class GPXParser extends FileParser {
                                     Double.valueOf(longitude)));
                         }
                     }
-                } catch (final Exception e) {
+                } catch (final NumberFormatException e) {
                     Log.w("Failed to parse waypoint's latitude and/or longitude.");
                 }
             }
@@ -501,7 +501,7 @@ public abstract class GPXParser extends FileParser {
                         if (attrs.getIndex("available") > -1) {
                             cache.setDisabled(!attrs.getValue("available").equalsIgnoreCase("true"));
                         }
-                    } catch (final Exception e) {
+                    } catch (final RuntimeException e) {
                         Log.w("Failed to parse cache attributes.");
                     }
                 }
@@ -680,7 +680,7 @@ public abstract class GPXParser extends FileParser {
                         if (attrs.getIndex("ref") > -1) {
                             trackable.setGeocode(attrs.getValue("ref"));
                         }
-                    } catch (final Exception e) {
+                    } catch (final RuntimeException e) {
                         // nothing
                     }
                 }
@@ -724,7 +724,7 @@ public abstract class GPXParser extends FileParser {
                         if (attrs.getIndex("id") > -1) {
                             log.id = Integer.parseInt(attrs.getValue("id"));
                         }
-                    } catch (final Exception e) {
+                    } catch (final NumberFormatException e) {
                         // nothing
                     }
                 }
diff --git a/main/src/cgeo/geocaching/files/SimpleDirChooser.java b/main/src/cgeo/geocaching/files/SimpleDirChooser.java
index 6b2366c..8f69b88 100644
--- a/main/src/cgeo/geocaching/files/SimpleDirChooser.java
+++ b/main/src/cgeo/geocaching/files/SimpleDirChooser.java
@@ -93,7 +93,7 @@ public class SimpleDirChooser extends AbstractListActivity {
             for (File currentDir : dirs) {
                 listDirs.add(new Option(currentDir.getName(), currentDir.getAbsolutePath()));
             }
-        } catch (Exception e) {
+        } catch (RuntimeException e) {
         }
         Collections.sort(listDirs);
         if (dir.getParent() != null) {
diff --git a/main/src/cgeo/geocaching/gcvote/GCVote.java b/main/src/cgeo/geocaching/gcvote/GCVote.java
index 868be2b..a0c4265 100644
--- a/main/src/cgeo/geocaching/gcvote/GCVote.java
+++ b/main/src/cgeo/geocaching/gcvote/GCVote.java
@@ -97,29 +97,21 @@ public final class GCVote {
 
                 String id = null;
                 String guid = null;
-                try {
-                    final MatcherWrapper matcherGuid = new MatcherWrapper(patternGuid, voteData);
-                    if (matcherGuid.find()) {
-                        if (matcherGuid.groupCount() > 0) {
-                            guid = matcherGuid.group(1);
-                            if (requestByGuids) {
-                                id = guid;
-                            }
+                final MatcherWrapper matcherGuid = new MatcherWrapper(patternGuid, voteData);
+                if (matcherGuid.find()) {
+                    if (matcherGuid.groupCount() > 0) {
+                        guid = matcherGuid.group(1);
+                        if (requestByGuids) {
+                            id = guid;
                         }
                     }
-                } catch (Exception e) {
-                    Log.w("GCVote.getRating: Failed to parse guid");
                 }
                 if (!requestByGuids) {
-                    try {
-                        final MatcherWrapper matcherWp = new MatcherWrapper(patternWaypoint, voteData);
-                        if (matcherWp.find()) {
-                            if (matcherWp.groupCount() > 0) {
-                                id = matcherWp.group(1);
-                            }
+                    final MatcherWrapper matcherWp = new MatcherWrapper(patternWaypoint, voteData);
+                    if (matcherWp.find()) {
+                        if (matcherWp.groupCount() > 0) {
+                            id = matcherWp.group(1);
                         }
-                    } catch (Exception e) {
-                        Log.w("GCVote.getRating: Failed to parse waypoint");
                     }
                 }
                 if (id == null) {
@@ -127,17 +119,13 @@ public final class GCVote {
                 }
 
                 boolean loggedIn = false;
-                try {
-                    final MatcherWrapper matcherLoggedIn = new MatcherWrapper(patternLogIn, page);
-                    if (matcherLoggedIn.find()) {
-                        if (matcherLoggedIn.groupCount() > 0) {
-                            if (matcherLoggedIn.group(1).equalsIgnoreCase("true")) {
-                                loggedIn = true;
-                            }
+                final MatcherWrapper matcherLoggedIn = new MatcherWrapper(patternLogIn, page);
+                if (matcherLoggedIn.find()) {
+                    if (matcherLoggedIn.groupCount() > 0) {
+                        if (matcherLoggedIn.group(1).equalsIgnoreCase("true")) {
+                            loggedIn = true;
                         }
                     }
-                } catch (Exception e) {
-                    Log.w("GCVote.getRating: Failed to parse loggedIn");
                 }
 
                 float rating = 0;
@@ -146,7 +134,7 @@ public final class GCVote {
                     if (matcherRating.find()) {
                         rating = Float.parseFloat(matcherRating.group(1));
                     }
-                } catch (Exception e) {
+                } catch (NumberFormatException e) {
                     Log.w("GCVote.getRating: Failed to parse rating");
                 }
                 if (rating <= 0) {
@@ -159,7 +147,7 @@ public final class GCVote {
                     if (matcherVotes.find()) {
                         votes = Integer.parseInt(matcherVotes.group(1));
                     }
-                } catch (Exception e) {
+                } catch (NumberFormatException e) {
                     Log.w("GCVote.getRating: Failed to parse vote count");
                 }
                 if (votes < 0) {
@@ -173,7 +161,7 @@ public final class GCVote {
                         if (matcherVote.find()) {
                             myVote = Float.parseFloat(matcherVote.group(1));
                         }
-                    } catch (Exception e) {
+                    } catch (NumberFormatException e) {
                         Log.w("GCVote.getRating: Failed to parse user's vote");
                     }
                 }
@@ -184,7 +172,7 @@ public final class GCVote {
                     ratingsCache.put(guid, gcvoteRating);
                 }
             }
-        } catch (Exception e) {
+        } catch (RuntimeException e) {
             Log.e("GCVote.getRating", e);
         }
 
diff --git a/main/src/cgeo/geocaching/maps/CGeoMap.java b/main/src/cgeo/geocaching/maps/CGeoMap.java
index 0817170..0703dd8 100644
--- a/main/src/cgeo/geocaching/maps/CGeoMap.java
+++ b/main/src/cgeo/geocaching/maps/CGeoMap.java
@@ -609,7 +609,7 @@ public class CGeoMap extends AbstractMap implements OnMapDragListener, ViewFacto
                 default: // DETAILED
                     menu.findItem(R.id.menu_strategy_detailed).setChecked(true);
             }
-        } catch (Exception e) {
+        } catch (RuntimeException e) {
             Log.e("CGeoMap.onPrepareOptionsMenu", e);
         }
 
@@ -948,7 +948,7 @@ public class CGeoMap extends AbstractMap implements OnMapDragListener, ViewFacto
                             mapView.repaintRequired(overlayPosition);
                         }
                     }
-                } catch (Exception e) {
+                } catch (RuntimeException e) {
                     Log.w("Failed to update location.");
                 }
             }
@@ -1418,7 +1418,7 @@ public class CGeoMap extends AbstractMap implements OnMapDragListener, ViewFacto
                                 }
 
                                 sleep(delay);
-                            } catch (Exception e) {
+                            } catch (InterruptedException e) {
                                 // nothing
                             }
                         }
@@ -1501,7 +1501,7 @@ public class CGeoMap extends AbstractMap implements OnMapDragListener, ViewFacto
             try {
                 mapController.setCenter(mapItemFactory.getGeoPointBase(new Geopoint(mapState[0] / 1.0e6, mapState[1] / 1.0e6)));
                 mapController.setZoom(mapState[2]);
-            } catch (Exception e) {
+            } catch (RuntimeException e) {
                 // nothing at all
             }
 
@@ -1525,7 +1525,7 @@ public class CGeoMap extends AbstractMap implements OnMapDragListener, ViewFacto
                 if (viewport.getLatitudeSpan() != 0 && viewport.getLongitudeSpan() != 0) {
                     mapController.zoomToSpan((int) (viewport.getLatitudeSpan() * 1e6), (int) (viewport.getLongitudeSpan() * 1e6));
                 }
-            } catch (Exception e) {
+            } catch (RuntimeException e) {
                 // nothing at all
             }
 
diff --git a/main/src/cgeo/geocaching/maps/CachesOverlay.java b/main/src/cgeo/geocaching/maps/CachesOverlay.java
index 8e117eb..ad455b5 100644
--- a/main/src/cgeo/geocaching/maps/CachesOverlay.java
+++ b/main/src/cgeo/geocaching/maps/CachesOverlay.java
@@ -4,7 +4,6 @@ import cgeo.geocaching.CachePopup;
 import cgeo.geocaching.Geocache;
 import cgeo.geocaching.IWaypoint;
 import cgeo.geocaching.R;
-import cgeo.geocaching.settings.Settings;
 import cgeo.geocaching.WaypointPopup;
 import cgeo.geocaching.cgData;
 import cgeo.geocaching.activity.Progress;
@@ -19,11 +18,13 @@ import cgeo.geocaching.maps.interfaces.MapItemFactory;
 import cgeo.geocaching.maps.interfaces.MapProjectionImpl;
 import cgeo.geocaching.maps.interfaces.MapProvider;
 import cgeo.geocaching.maps.interfaces.MapViewImpl;
+import cgeo.geocaching.settings.Settings;
 import cgeo.geocaching.utils.Log;
 
 import org.apache.commons.lang3.StringUtils;
 
 import android.content.Context;
+import android.content.res.Resources.NotFoundException;
 import android.graphics.Canvas;
 import android.graphics.DashPathEffect;
 import android.graphics.Paint;
@@ -243,7 +244,7 @@ public class CachesOverlay extends AbstractItemizedOverlay {
             }
 
             progress.dismiss();
-        } catch (Exception e) {
+        } catch (NotFoundException e) {
             Log.e("CachesOverlay.onTap", e);
             if (progress != null) {
                 progress.dismiss();
diff --git a/main/src/cgeo/geocaching/sorting/ComparatorUserInterface.java b/main/src/cgeo/geocaching/sorting/ComparatorUserInterface.java
index 4d1a994..3cdd393 100644
--- a/main/src/cgeo/geocaching/sorting/ComparatorUserInterface.java
+++ b/main/src/cgeo/geocaching/sorting/ComparatorUserInterface.java
@@ -90,7 +90,9 @@ public class ComparatorUserInterface {
                         CacheComparator comparator = entry.cacheComparator.newInstance();
                         runAfterwards.run(comparator);
                     }
-                } catch (Exception e) {
+                } catch (InstantiationException e) {
+                    Log.e("selectComparator", e);
+                } catch (IllegalAccessException e) {
                     Log.e("selectComparator", e);
                 }
                 dialog.dismiss();
diff --git a/main/src/cgeo/geocaching/ui/DecryptTextClickListener.java b/main/src/cgeo/geocaching/ui/DecryptTextClickListener.java
index f10e13a..56c7f2f 100644
--- a/main/src/cgeo/geocaching/ui/DecryptTextClickListener.java
+++ b/main/src/cgeo/geocaching/ui/DecryptTextClickListener.java
@@ -31,7 +31,7 @@ public class DecryptTextClickListener implements View.OnClickListener {
                 String string = (String) text;

                 logView.setText(CryptUtils.rot13(string));

             }

-        } catch (Exception e) {

+        } catch (RuntimeException e) {

             // nothing

         }

     }

diff --git a/main/src/cgeo/geocaching/ui/dialog/CustomProgressDialog.java b/main/src/cgeo/geocaching/ui/dialog/CustomProgressDialog.java
index e80c446..97c5c29 100644
--- a/main/src/cgeo/geocaching/ui/dialog/CustomProgressDialog.java
+++ b/main/src/cgeo/geocaching/ui/dialog/CustomProgressDialog.java
@@ -10,6 +10,7 @@ import android.view.View;
 import android.widget.TextView;
 
 import java.lang.reflect.Field;
+import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 
 /**
@@ -38,7 +39,11 @@ public class CustomProgressDialog extends ProgressDialog {
                     method.invoke(textView, View.GONE);
                 }
             }
-        } catch (Exception e) {
+        } catch (NoSuchMethodException e) {
+            Log.e("Failed to invoke the progressDialog method 'setVisibility' and set 'mProgressNumber' to GONE.", e);
+        } catch (IllegalAccessException e) {
+            Log.e("Failed to invoke the progressDialog method 'setVisibility' and set 'mProgressNumber' to GONE.", e);
+        } catch (InvocationTargetException e) {
             Log.e("Failed to invoke the progressDialog method 'setVisibility' and set 'mProgressNumber' to GONE.", e);
         }
     }
diff --git a/main/src/cgeo/geocaching/utils/CryptUtils.java b/main/src/cgeo/geocaching/utils/CryptUtils.java
index 18a337d..9d95c68 100644
--- a/main/src/cgeo/geocaching/utils/CryptUtils.java
+++ b/main/src/cgeo/geocaching/utils/CryptUtils.java
@@ -5,6 +5,7 @@ import android.text.Spannable;
 import android.text.SpannableStringBuilder;
 
 import java.math.BigInteger;
+import java.security.GeneralSecurityException;
 import java.security.MessageDigest;
 
 import javax.crypto.Mac;
@@ -111,7 +112,7 @@ public final class CryptUtils {
             final Mac mac = Mac.getInstance("HmacSHA1");
             mac.init(secretKeySpec);
             macBytes = mac.doFinal(text.getBytes());
-        } catch (Exception e) {
+        } catch (GeneralSecurityException e) {
             Log.e("CryptUtils.hashHmac", e);
         }