refactoring: log exceptions, remove unused method

2 files changed, 5 insertions, 13 deletions

diff --git a/cgeo-calendar/src/cgeo/calendar/CalendarActivity.java b/cgeo-calendar/src/cgeo/calendar/CalendarActivity.java
index f2a5c0a..b339954 100644
--- a/cgeo-calendar/src/cgeo/calendar/CalendarActivity.java
+++ b/cgeo-calendar/src/cgeo/calendar/CalendarActivity.java
@@ -110,8 +110,7 @@ public final class CalendarActivity extends Activity {
                         calendars.put(id, calName);
                     }
                 } catch (NumberFormatException e) {
-                    // TODO Auto-generated catch block
-                    e.printStackTrace();
+                    Log.e(LOG_TAG, "CalendarActivity.selectCalendarForAdding", e);
                 }
             }
         } while (cursor.moveToNext());
@@ -237,7 +236,7 @@ public final class CalendarActivity extends Activity {
         } catch (Exception e) {
             showToast(getResources().getString(R.string.event_fail));
 
-            Log.e(LOG_TAG, "CalendarActivity.addToCalendarFn: " + e.toString());
+            Log.e(LOG_TAG, "CalendarActivity.addToCalendarFn", e);
         }
     }
 
@@ -257,7 +256,7 @@ public final class CalendarActivity extends Activity {
              * targetSdkVersion changes to 14. For example CalendarContract.EXTRA_EVENT_BEGIN_TIME and
              * Events.TITLE
              */
-            Intent intent = new Intent(Intent.ACTION_INSERT)
+            final Intent intent = new Intent(Intent.ACTION_INSERT)
                     .setData(Compatibility.getCalendarEventsProviderURI())
                     .putExtra("beginTime", eventDate.getTime() + 43200000)
                     .putExtra("allDay", true)
diff --git a/main/src/cgeo/geocaching/connector/gc/GCConnector.java b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
index 95e4921..0e9ef1f 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCConnector.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
@@ -8,7 +8,6 @@ import cgeo.geocaching.cgCache;
 import cgeo.geocaching.cgeoapplication;
 import cgeo.geocaching.connector.AbstractConnector;
 import cgeo.geocaching.enumerations.StatusCode;
-import cgeo.geocaching.geopoint.Geopoint;
 import cgeo.geocaching.geopoint.Viewport;
 import cgeo.geocaching.network.Parameters;
 import cgeo.geocaching.utils.CancellableHandler;
@@ -107,7 +106,7 @@ public class GCConnector extends AbstractConnector {
         final String page = cgBase.requestLogged("http://www.geocaching.com/seek/cache_details.aspx", params, false, false, false);
 
         if (StringUtils.isEmpty(page)) {
-            SearchResult search = new SearchResult();
+            final SearchResult search = new SearchResult();
             if (app.isThere(geocode, guid, true, false)) {
                 if (StringUtils.isBlank(geocode) && StringUtils.isNotBlank(guid)) {
                     Log.i(Settings.tag, "Loading old cache from cache.");
@@ -132,18 +131,12 @@ public class GCConnector extends AbstractConnector {
             return searchResult;
         }
 
-        SearchResult search = searchResult.filterSearchResults(false, false, Settings.getCacheType());
+        final SearchResult search = searchResult.filterSearchResults(false, false, Settings.getCacheType());
 
         return search;
     }
 
     @Override
-    public SearchResult searchByCoordinate(Geopoint center) {
-        // TODO Auto-generated method stub
-        return super.searchByCoordinate(center);
-    }
-
-    @Override
     public SearchResult searchByViewport(Viewport viewport, String[] tokens) {
         return GCBase.searchByViewport(viewport, tokens);
     }