diff options
| author | Samuel Tardieu <sam@rfc1149.net> | 2013-09-13 12:20:33 +0200 |
|---|---|---|
| committer | Samuel Tardieu <sam@rfc1149.net> | 2013-09-13 12:20:33 +0200 |
| commit | faf8118561cbb2d63c037fee34c34845f370e5d9 (patch) | |
| tree | 6434a4a3a01681a72ad63ea3a47c2a3c5b7fe2d4 | |
| parent | e81ab7839bbc768fb9965021e58e996410e0f4f7 (diff) | |
| download | cgeo-faf8118561cbb2d63c037fee34c34845f370e5d9.zip cgeo-faf8118561cbb2d63c037fee34c34845f370e5d9.tar.gz cgeo-faf8118561cbb2d63c037fee34c34845f370e5d9.tar.bz2 | |
refactoring: add assertion instead of explicit null check
| -rw-r--r-- | main/src/cgeo/geocaching/connector/gc/Login.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/main/src/cgeo/geocaching/connector/gc/Login.java b/main/src/cgeo/geocaching/connector/gc/Login.java index 4e427ba..ad07424 100644 --- a/main/src/cgeo/geocaching/connector/gc/Login.java +++ b/main/src/cgeo/geocaching/connector/gc/Login.java @@ -114,11 +114,12 @@ public abstract class Login { loginResponse = Network.postRequest("https://www.geocaching.com/login/default.aspx", params); loginData = Network.getResponseData(loginResponse); - if (loginData == null || StringUtils.isBlank(loginData)) { + if (StringUtils.isBlank(loginData)) { Log.e("Login.login: Failed to retrieve login page (2nd)"); // FIXME: should it be CONNECTION_FAILED to match the first attempt? return StatusCode.COMMUNICATION_ERROR; // no login page } + assert loginData != null; // Caught above if (Login.getLoginStatus(loginData)) { Log.i("Successfully logged in Geocaching.com as " + login.left + " (" + Settings.getMemberStatus() + ')'); |