aboutsummaryrefslogtreecommitdiffstats
path: root/main/src/cgeo/geocaching/CgeoApplication.java
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2013-09-15 16:19:00 +0200
committerSamuel Tardieu <sam@rfc1149.net>2013-09-15 16:19:00 +0200
commitec3075961071a2d41ccdf53cd6d549baedd4a226 (patch)
treec8802db8d5eb7d8aa732cc52b14d20bf9afafb83 /main/src/cgeo/geocaching/CgeoApplication.java
parent00560ffebed20390858254123fa7ae310db89293 (diff)
downloadcgeo-ec3075961071a2d41ccdf53cd6d549baedd4a226.zip
cgeo-ec3075961071a2d41ccdf53cd6d549baedd4a226.tar.gz
cgeo-ec3075961071a2d41ccdf53cd6d549baedd4a226.tar.bz2
refactoring: do not create explicit handlers when not needed
When no information is to be carried to the handler, if the handler is called from one place it is simpler to use runOnUiThread rather than to construct an explicit handler.
Diffstat (limited to 'main/src/cgeo/geocaching/CgeoApplication.java')
-rw-r--r--main/src/cgeo/geocaching/CgeoApplication.java27
1 files changed, 11 insertions, 16 deletions
diff --git a/main/src/cgeo/geocaching/CgeoApplication.java b/main/src/cgeo/geocaching/CgeoApplication.java
index b725b0b..2c419cf 100644
--- a/main/src/cgeo/geocaching/CgeoApplication.java
+++ b/main/src/cgeo/geocaching/CgeoApplication.java
@@ -9,8 +9,6 @@ import android.app.Activity;
import android.app.Application;
import android.app.ProgressDialog;
import android.content.res.Resources;
-import android.os.Handler;
-import android.os.Message;
import java.util.concurrent.atomic.AtomicBoolean;
@@ -69,24 +67,21 @@ public class CgeoApplication extends Application {
final Resources res = this.getResources();
final ProgressDialog dialog = ProgressDialog.show(fromActivity, res.getString(R.string.init_dbmove_dbmove), res.getString(R.string.init_dbmove_running), true, false);
final AtomicBoolean atomic = new AtomicBoolean(false);
- Thread moveThread = new Thread() {
- final Handler handler = new Handler() {
- @Override
- public void handleMessage(Message msg) {
- dialog.dismiss();
- boolean success = atomic.get();
- String message = success ? res.getString(R.string.init_dbmove_success) : res.getString(R.string.init_dbmove_failed);
- ActivityMixin.helpDialog(fromActivity, res.getString(R.string.init_dbmove_dbmove), message);
- }
- };
-
+ new Thread() {
@Override
public void run() {
atomic.set(DataStore.moveDatabase());
- handler.sendMessage(handler.obtainMessage());
+ fromActivity.runOnUiThread(new Runnable() {
+ @Override
+ public void run() {
+ dialog.dismiss();
+ boolean success = atomic.get();
+ String message = success ? res.getString(R.string.init_dbmove_success) : res.getString(R.string.init_dbmove_failed);
+ ActivityMixin.helpDialog(fromActivity, res.getString(R.string.init_dbmove_dbmove), message);
+ }
+ });
}
- };
- moveThread.start();
+ }.start();
}
/**