fix #2317: NPE while backuping data

The previous fix for #2317 was incomplete, as the dependency of the
CentralBackupAgent onto Settings caused a NPE because Settings static
initializations require that an application has been created, which is
apparently not the case when a backup is launched by the OS.

The preference name has been isolated into a no-dependency package so
that the CentralBackupAgent does not depend on an application existing
anymore.

1 files changed, 0 insertions, 6 deletions

diff --git a/main/src/cgeo/geocaching/Settings.java b/main/src/cgeo/geocaching/Settings.java
index 7e6f91f..850c4f4 100644
--- a/main/src/cgeo/geocaching/Settings.java
+++ b/main/src/cgeo/geocaching/Settings.java
@@ -1359,12 +1359,6 @@ public final class Settings {
         }
     }
 
-    public static String getPreferencesName() {
-        // There is currently no Android API to get the file name of the shared preferences. Let's hardcode
-        // it without needing a cgeoapplication instance.
-        return "cgeo.geocaching_preferences";
-    }
-
     public static boolean getPlainLogs() {
         return sharedPrefs.getBoolean(KEY_PLAIN_LOGS, false);
     }