refactoring for #908: waypoint list of cache is immutable for clients

and never null
* avoids initializations outside of cache
* avoids tempering with internal data outside of cache
* removes redundant code and null checks

1 files changed, 1 insertions, 2 deletions

diff --git a/main/src/cgeo/geocaching/StaticMapsProvider.java b/main/src/cgeo/geocaching/StaticMapsProvider.java
index 9834681..d37905b 100644
--- a/main/src/cgeo/geocaching/StaticMapsProvider.java
+++ b/main/src/cgeo/geocaching/StaticMapsProvider.java
@@ -3,7 +3,6 @@ package cgeo.geocaching;
 import cgeo.geocaching.files.LocalStorage;
 import cgeo.geocaching.geopoint.GeopointFormatter.Format;
 
-import org.apache.commons.collections.CollectionUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.http.HttpResponse;
 
@@ -70,7 +69,7 @@ public class StaticMapsProvider {
         }
 
         final StringBuilder waypoints = new StringBuilder();
-        if (CollectionUtils.isNotEmpty(cache.getWaypoints())) {
+        if (cache.hasWaypoints()) {
             for (cgWaypoint waypoint : cache.getWaypoints()) {
                 if (waypoint.getCoords() == null) {
                     continue;