aboutsummaryrefslogtreecommitdiffstats
path: root/main/src/cgeo/geocaching/StaticMapsProvider.java
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2013-04-06 18:06:25 +0200
committerSamuel Tardieu <sam@rfc1149.net>2013-04-06 18:06:25 +0200
commita7c667f396f629957da115da3d46ce989b7ad736 (patch)
tree0d1040d57ce58510b095bb1b4190dc9fc1b92d8e /main/src/cgeo/geocaching/StaticMapsProvider.java
parenta06ebc504275d11b740a54fddfb6dc60a0d0887a (diff)
downloadcgeo-a7c667f396f629957da115da3d46ce989b7ad736.zip
cgeo-a7c667f396f629957da115da3d46ce989b7ad736.tar.gz
cgeo-a7c667f396f629957da115da3d46ce989b7ad736.tar.bz2
refactoring: remove extra check
If getWaypoints() returns an empty collection, then the loop will do nothing. Since it cannot return a null value, the test is redundant.
Diffstat (limited to 'main/src/cgeo/geocaching/StaticMapsProvider.java')
-rw-r--r--main/src/cgeo/geocaching/StaticMapsProvider.java4
1 files changed, 2 insertions, 2 deletions
diff --git a/main/src/cgeo/geocaching/StaticMapsProvider.java b/main/src/cgeo/geocaching/StaticMapsProvider.java
index 37a6cd6..e7332a8 100644
--- a/main/src/cgeo/geocaching/StaticMapsProvider.java
+++ b/main/src/cgeo/geocaching/StaticMapsProvider.java
@@ -92,8 +92,8 @@ public class StaticMapsProvider {
}
// clean old and download static maps for waypoints if one is missing
- if (Settings.isStoreOfflineWpMaps() && CollectionUtils.isNotEmpty(cache.getWaypoints())) {
- for (Waypoint waypoint : cache.getWaypoints()) {
+ if (Settings.isStoreOfflineWpMaps()) {
+ for (final Waypoint waypoint : cache.getWaypoints()) {
if (!hasAllStaticMapsForWaypoint(cache.getGeocode(), waypoint)) {
refreshAllWpStaticMaps(cache, edge);
}