Refactoring: remove unnecessary else statements

1 files changed, 13 insertions, 2 deletions

diff --git a/main/src/cgeo/geocaching/apps/cache/navi/AbstractPointNavigationApp.java b/main/src/cgeo/geocaching/apps/cache/navi/AbstractPointNavigationApp.java
index c5abf7f..16b641e 100644
--- a/main/src/cgeo/geocaching/apps/cache/navi/AbstractPointNavigationApp.java
+++ b/main/src/cgeo/geocaching/apps/cache/navi/AbstractPointNavigationApp.java
@@ -46,13 +46,24 @@ abstract class AbstractPointNavigationApp extends AbstractNavigationApp {
 
     protected abstract void navigate(Activity activity, Geopoint point);
 
-    private static Geopoint getCoordinates(cgCache cache, cgWaypoint waypoint, Geopoint coords) {
+    /**
+     * Return the first of the cache coordinates, the waypoint coordinates or the extra coordinates. <code>null</code>
+     * entities are skipped.
+     *
+     * @param cache a cache
+     * @param waypoint a waypoint
+     * @param coords extra coordinates
+     * @return the first non-null coordinates, or null if none are set
+     */
+    private static Geopoint getCoordinates(final cgCache cache, final cgWaypoint waypoint, final Geopoint coords) {
         if (cache != null && cache.getCoords() != null) {
             return cache.getCoords();
         }
-        else if (waypoint != null && waypoint.getCoords() != null) {
+
+        if (waypoint != null && waypoint.getCoords() != null) {
             return waypoint.getCoords();
         }
+
         return coords;
     }
 }
\ No newline at end of file