don't use regular expressions for String replacement

* prefer StringUtils.replace over String.replaceAll
* have new test to verify this change
* remove cgBase instance from LogTemplates

1 files changed, 2 insertions, 2 deletions

diff --git a/main/src/cgeo/geocaching/cgCache.java b/main/src/cgeo/geocaching/cgCache.java
index d41e725..146dfcb 100644
--- a/main/src/cgeo/geocaching/cgCache.java
+++ b/main/src/cgeo/geocaching/cgCache.java
@@ -294,11 +294,11 @@ public class cgCache implements ICache {
         return true;
     }
 
-    public boolean logOffline(final IAbstractActivity fromActivity, final int logType, final cgBase base) {
+    public boolean logOffline(final IAbstractActivity fromActivity, final int logType) {
         String log = "";
         if (StringUtils.isNotBlank(Settings.getSignature())
                 && Settings.isAutoInsertSignature()) {
-            log = LogTemplateProvider.applyTemplates(Settings.getSignature(), base, true);
+            log = LogTemplateProvider.applyTemplates(Settings.getSignature(), true);
         }
         logOffline(fromActivity, log, Calendar.getInstance(), logType);
         return true;