fix #3480: quasi-systematic concurrent logins

The login procedure was initiated in both `onCreate()` and `onResume()`.
It has been limited to `onResume()` and refactored as to not manipulate
a global variable.

Also, the previous code prevented cgeo from retrying a failed login to
one of the cache providers if another had succeeded, as every provider
cleared `setLogin()` in case of success. This has been fixed as well.

1 files changed, 0 insertions, 1 deletions

diff --git a/main/src/cgeo/geocaching/connector/gc/GCConnector.java b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
index 4349d5d..5557954 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCConnector.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCConnector.java
@@ -304,7 +304,6 @@ public class GCConnector extends AbstractConnector implements ISearchByGeocode,
         final StatusCode status = GCLogin.getInstance().login();
 
         if (status == StatusCode.NO_ERROR) {
-            CgeoApplication.getInstance().checkLogin = false;
             GCLogin.detectGcCustomDate();
         }