aboutsummaryrefslogtreecommitdiffstats
path: root/main/src/cgeo/geocaching/files
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2015-03-17 08:37:59 +0100
committerSamuel Tardieu <sam@rfc1149.net>2015-03-17 08:41:06 +0100
commitb2ffc2581c6630e313c4e623d0a40c8846e1e975 (patch)
tree6859e456fdb42e6468558883761c1de40b458c80 /main/src/cgeo/geocaching/files
parent9119639276a00ef17d3ffa1a5fad0c37c1bebd78 (diff)
downloadcgeo-b2ffc2581c6630e313c4e623d0a40c8846e1e975.zip
cgeo-b2ffc2581c6630e313c4e623d0a40c8846e1e975.tar.gz
cgeo-b2ffc2581c6630e313c4e623d0a40c8846e1e975.tar.bz2
Add missing final qualifiers in main module
Diffstat (limited to 'main/src/cgeo/geocaching/files')
-rw-r--r--main/src/cgeo/geocaching/files/GPX10Parser.java4
-rw-r--r--main/src/cgeo/geocaching/files/GPX11Parser.java4
-rw-r--r--main/src/cgeo/geocaching/files/GPXParser.java2
-rw-r--r--main/src/cgeo/geocaching/files/InvalidXMLCharacterFilterReader.java12
-rw-r--r--main/src/cgeo/geocaching/files/NoCloseInputStream.java4
-rw-r--r--main/src/cgeo/geocaching/files/ParserException.java4
6 files changed, 15 insertions, 15 deletions
diff --git a/main/src/cgeo/geocaching/files/GPX10Parser.java b/main/src/cgeo/geocaching/files/GPX10Parser.java
index 0ca2606..815d577 100644
--- a/main/src/cgeo/geocaching/files/GPX10Parser.java
+++ b/main/src/cgeo/geocaching/files/GPX10Parser.java
@@ -4,12 +4,12 @@ import android.sax.Element;
public class GPX10Parser extends GPXParser {
- public GPX10Parser(int listIdIn) {
+ public GPX10Parser(final int listIdIn) {
super(listIdIn, "http://www.topografix.com/GPX/1/0", "1.0");
}
@Override
- protected Element getCacheParent(Element waypoint) {
+ protected Element getCacheParent(final Element waypoint) {
return waypoint;
}
diff --git a/main/src/cgeo/geocaching/files/GPX11Parser.java b/main/src/cgeo/geocaching/files/GPX11Parser.java
index 52a6ae3..6ac152c 100644
--- a/main/src/cgeo/geocaching/files/GPX11Parser.java
+++ b/main/src/cgeo/geocaching/files/GPX11Parser.java
@@ -4,12 +4,12 @@ import android.sax.Element;
public final class GPX11Parser extends GPXParser {
- public GPX11Parser(int listIdIn) {
+ public GPX11Parser(final int listIdIn) {
super(listIdIn, "http://www.topografix.com/GPX/1/1", "1.1");
}
@Override
- protected Element getCacheParent(Element waypoint) {
+ protected Element getCacheParent(final Element waypoint) {
return waypoint.getChild(namespace, "extensions");
}
diff --git a/main/src/cgeo/geocaching/files/GPXParser.java b/main/src/cgeo/geocaching/files/GPXParser.java
index e4bb7e1..aed82e6 100644
--- a/main/src/cgeo/geocaching/files/GPXParser.java
+++ b/main/src/cgeo/geocaching/files/GPXParser.java
@@ -225,7 +225,7 @@ public abstract class GPXParser extends FileParser {
return null; // id not found
}
// get text for string
- String stringName;
+ final String stringName;
try {
stringName = CgeoApplication.getInstance().getResources().getResourceName(stringId);
} catch (final NullPointerException ignored) {
diff --git a/main/src/cgeo/geocaching/files/InvalidXMLCharacterFilterReader.java b/main/src/cgeo/geocaching/files/InvalidXMLCharacterFilterReader.java
index 5204140..eea14c3 100644
--- a/main/src/cgeo/geocaching/files/InvalidXMLCharacterFilterReader.java
+++ b/main/src/cgeo/geocaching/files/InvalidXMLCharacterFilterReader.java
@@ -13,7 +13,7 @@ import java.io.Reader;
public class InvalidXMLCharacterFilterReader extends FilterReader
{
- public InvalidXMLCharacterFilterReader(Reader in) {
+ public InvalidXMLCharacterFilterReader(final Reader in) {
super(in);
}
@@ -28,8 +28,8 @@ public class InvalidXMLCharacterFilterReader extends FilterReader
* underling reader was reached.
*/
@Override
- public int read(char[] cbuf, int off, int len) throws IOException {
- int read = super.read(cbuf, off, len);
+ public int read(final char[] cbuf, final int off, final int len) throws IOException {
+ final int read = super.read(cbuf, off, len);
// check for end
if (read == -1) {
return -1;
@@ -48,11 +48,11 @@ public class InvalidXMLCharacterFilterReader extends FilterReader
case ';':
pos++;
if (entityStart >= 0) {
- int entityLength = readPos - entityStart + 1;
+ final int entityLength = readPos - entityStart + 1;
if (entityLength <= 5) {
- String entity = new String(cbuf, entityStart, entityLength);
+ final String entity = new String(cbuf, entityStart, entityLength);
if (StringUtils.startsWith(entity, "&#")) {
- String numberString = StringUtils.substringBetween(entity, "&#", ";");
+ final String numberString = StringUtils.substringBetween(entity, "&#", ";");
final int value;
if (StringUtils.startsWith(numberString, "x")) {
value = Integer.parseInt(numberString.substring(1), 16);
diff --git a/main/src/cgeo/geocaching/files/NoCloseInputStream.java b/main/src/cgeo/geocaching/files/NoCloseInputStream.java
index 5a72607..493f6ca 100644
--- a/main/src/cgeo/geocaching/files/NoCloseInputStream.java
+++ b/main/src/cgeo/geocaching/files/NoCloseInputStream.java
@@ -9,9 +9,9 @@ import java.io.InputStream;
* one input stream (e.g. ZipInputStream) because SAX parser closes stream.
*/
public class NoCloseInputStream extends FilterInputStream {
- private static ClosedInputStream closedInputStream = new ClosedInputStream();
+ private static final ClosedInputStream closedInputStream = new ClosedInputStream();
- public NoCloseInputStream(InputStream in) {
+ public NoCloseInputStream(final InputStream in) {
super(in);
}
diff --git a/main/src/cgeo/geocaching/files/ParserException.java b/main/src/cgeo/geocaching/files/ParserException.java
index c0076cc..6c8cfda 100644
--- a/main/src/cgeo/geocaching/files/ParserException.java
+++ b/main/src/cgeo/geocaching/files/ParserException.java
@@ -9,11 +9,11 @@ public class ParserException extends Exception {
public ParserException() {
}
- public ParserException(String detailMessage) {
+ public ParserException(final String detailMessage) {
super(detailMessage);
}
- public ParserException(String detailMessage, Throwable throwable) {
+ public ParserException(final String detailMessage, final Throwable throwable) {
super(detailMessage, throwable);
}