Refactoring: cleanup application startup

This cleanup:
  - do not pass the cgeoapplication singleton to cgData
  - do not pretend that CacheCache is a singleton, it only occurs to
    have one instance in cgData
  - start version updater thread in cgeoapplication.onCreate(), once the
    object has been created, to avoid risking accessing the sole
    instance before it is fully initialized, this could lead to a crash
    at initialization time
  - use an available context object to access version information, which
    is not accessed frequently

1 files changed, 1 insertions, 1 deletions

diff --git a/main/src/cgeo/geocaching/go4cache/Go4Cache.java b/main/src/cgeo/geocaching/go4cache/Go4Cache.java
index a2659e0..131faa4 100644
--- a/main/src/cgeo/geocaching/go4cache/Go4Cache.java
+++ b/main/src/cgeo/geocaching/go4cache/Go4Cache.java
@@ -93,7 +93,7 @@ public final class Go4Cache extends Thread {
                         "ln", lonStr,
                         "a", currentAction,
                         "s", (CryptUtils.sha1(username + "|" + latStr + "|" + lonStr + "|" + currentAction + "|" + CryptUtils.md5("carnero: developing your dreams"))).toLowerCase(),
-                        "v", Version.getVersionName());
+                        "v", Version.getVersionName(cgeoapplication.getInstance()));
 
                 Network.postRequest("http://api.go4cache.com/", params);