Add FIXME: message and ask for clarification

1 files changed, 17 insertions, 18 deletions

diff --git a/main/src/cgeo/geocaching/network/HtmlImage.java b/main/src/cgeo/geocaching/network/HtmlImage.java
index b6be931..ecf0d52 100644
--- a/main/src/cgeo/geocaching/network/HtmlImage.java
+++ b/main/src/cgeo/geocaching/network/HtmlImage.java
@@ -163,26 +163,25 @@ public class HtmlImage implements Html.ImageGetter {
     }
 
     private final String makeAbsoluteURL(final String url) {
-        try {
-            // Check if uri is absolute or not, if not attach the connector hostname
-            // FIXME: that should also include the scheme
-            if (Uri.parse(url).isAbsolute()) {
-                return url;
-            } else {
-                final String host = ConnectorFactory.getConnector(geocode).getHost();
-                if (StringUtils.isNotEmpty(host)) {
-                    StringBuilder builder = new StringBuilder("http://");
-                    builder.append(host);
-                    if (!StringUtils.startsWith(url, "/")) {
-                        builder.append('/');
-                    }
-                    builder.append(url);
-                    return builder.toString();
-                }
+        // Check if uri is absolute or not, if not attach the connector hostname
+        // FIXME: that should also include the scheme
+        if (Uri.parse(url).isAbsolute()) {
+            return url;
+        }
+
+        final String host = ConnectorFactory.getConnector(geocode).getHost();
+        if (StringUtils.isNotEmpty(host)) {
+            final StringBuilder builder = new StringBuilder("http://");
+            builder.append(host);
+            if (!StringUtils.startsWith(url, "/")) {
+                // FIXME: explain why the result URL would be valid if the path does not start with
+                // a '/', or signal an error.
+                builder.append('/');
             }
-        } catch (Exception e) {
-            Log.e("HtmlImage.makeAbsoluteURL (parse URL)", e);
+            builder.append(url);
+            return builder.toString();
         }
+
         return null;
     }