refactoring of cache logging code

* simplify control flow
* move sanity checks into GCVote and twitter methods

1 files changed, 6 insertions, 0 deletions

diff --git a/main/src/cgeo/geocaching/twitter/Twitter.java b/main/src/cgeo/geocaching/twitter/Twitter.java
index f30830e..d3b2718 100644
--- a/main/src/cgeo/geocaching/twitter/Twitter.java
+++ b/main/src/cgeo/geocaching/twitter/Twitter.java
@@ -56,6 +56,12 @@ public final class Twitter {
     }
 
     public static void postTweetCache(String geocode) {
+        if (!Settings.isUseTwitter()) {
+            return;
+        }
+        if (!Settings.isTwitterLoginValid()) {
+            return;
+        }
         final Geocache cache = cgData.loadCache(geocode, LoadFlags.LOAD_CACHE_OR_DB);
         String status;
         final String url = cache.getUrl();