refactoring: introduce handler with weak reference to activity

* remaining handler classes need to be changed also if no issues occur

1 files changed, 27 insertions, 0 deletions

diff --git a/main/src/cgeo/geocaching/ui/WeakReferenceHandler.java b/main/src/cgeo/geocaching/ui/WeakReferenceHandler.java
new file mode 100644
index 0000000..4724466
--- /dev/null
+++ b/main/src/cgeo/geocaching/ui/WeakReferenceHandler.java
@@ -0,0 +1,27 @@
+package cgeo.geocaching.ui;
+
+import android.app.Activity;
+import android.os.Handler;
+
+import java.lang.ref.WeakReference;
+
+/**
+ * Standard handler implementation which uses a weak reference to its activity. This avoids that activities stay in
+ * memory due to references from the handler to the activity (see Android Lint warning "HandlerLeak")
+ *
+ * Create static private subclasses of this handler class in your activity.
+ *
+ * @param <ActivityType>
+ */
+public abstract class WeakReferenceHandler<ActivityType extends Activity> extends Handler {
+
+    private final WeakReference<ActivityType> activityRef;
+
+    protected WeakReferenceHandler(final ActivityType activity) {
+        this.activityRef = new WeakReference<ActivityType>(activity);
+    }
+
+    protected ActivityType getActivity() {
+        return activityRef.get();
+    }
+}