diff options
| author | Bananeweizen <bananeweizen@gmx.de> | 2013-07-19 17:07:08 +0200 |
|---|---|---|
| committer | Bananeweizen <bananeweizen@gmx.de> | 2013-07-19 17:07:08 +0200 |
| commit | 46bcd8d179e95a80680e83eb43e9bf6ddfaf6f12 (patch) | |
| tree | 14ce93a5c4cb2dc182b0346b12ae450d4c22e52d /main/src/cgeo/geocaching | |
| parent | 07f3b3337f2f3bac0a4c1f16b82e2d283cc9f0d2 (diff) | |
| download | cgeo-46bcd8d179e95a80680e83eb43e9bf6ddfaf6f12.zip cgeo-46bcd8d179e95a80680e83eb43e9bf6ddfaf6f12.tar.gz cgeo-46bcd8d179e95a80680e83eb43e9bf6ddfaf6f12.tar.bz2 | |
fix #3020: document request headers for caching
Diffstat (limited to 'main/src/cgeo/geocaching')
| -rw-r--r-- | main/src/cgeo/geocaching/network/Network.java | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/main/src/cgeo/geocaching/network/Network.java b/main/src/cgeo/geocaching/network/Network.java index fc11dc8..2d2ab0b 100644 --- a/main/src/cgeo/geocaching/network/Network.java +++ b/main/src/cgeo/geocaching/network/Network.java @@ -319,8 +319,9 @@ public abstract class Network { final String etag = LocalStorage.getSavedHeader(cacheFile, LocalStorage.HEADER_ETAG); if (etag != null) { + // The ETag is a more robust check than a timestamp. If we have an ETag, it is enough + // to identify the right version of the resource. return new Parameters("If-None-Match", etag); - //FIXME: This seems to be wrong. Shouldn't we check for both headers instead of returning after finding the first? } final String lastModified = LocalStorage.getSavedHeader(cacheFile, LocalStorage.HEADER_LAST_MODIFIED); |