remove unneeded suppresswarnings

Eclipse does not show a warning if the parameter is documented in the
JavaDoc. If your IDE shows warnings about these parameters now after the
change, consider upgrading.

5 files changed, 21 insertions, 15 deletions

diff --git a/main/src/cgeo/geocaching/AbstractPopupActivity.java b/main/src/cgeo/geocaching/AbstractPopupActivity.java
index 683579f..01e714d 100644
--- a/main/src/cgeo/geocaching/AbstractPopupActivity.java
+++ b/main/src/cgeo/geocaching/AbstractPopupActivity.java
@@ -17,6 +17,7 @@ import cgeo.geocaching.utils.Log;
 import cgeo.geocaching.utils.RxUtils;
 
 import org.apache.commons.lang3.StringUtils;
+
 import rx.Observable;
 import rx.functions.Action1;
 import rx.functions.Func0;
@@ -255,7 +256,7 @@ public abstract class AbstractPopupActivity extends AbstractActivity implements
      * @param view
      *            unused here but needed since this method is referenced from XML layout
      */
-    public final void goDefaultNavigation(@SuppressWarnings("unused") View view) {
+    public final void goDefaultNavigation(View view) {
         navigateTo();
         finish();
     }
diff --git a/main/src/cgeo/geocaching/CacheListActivity.java b/main/src/cgeo/geocaching/CacheListActivity.java
index b2404d9..0aec119 100644
--- a/main/src/cgeo/geocaching/CacheListActivity.java
+++ b/main/src/cgeo/geocaching/CacheListActivity.java
@@ -1384,7 +1384,7 @@ public class CacheListActivity extends AbstractListActivity implements FilteredA
      * @param view
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void goMap(@SuppressWarnings("unused") View view) {
+    public void goMap(View view) {
         if (!cacheToShow()) {
             return;
         }
diff --git a/main/src/cgeo/geocaching/Geocache.java b/main/src/cgeo/geocaching/Geocache.java
index a224e4e..fa25576 100644
--- a/main/src/cgeo/geocaching/Geocache.java
+++ b/main/src/cgeo/geocaching/Geocache.java
@@ -34,12 +34,14 @@ import cgeo.geocaching.utils.MatcherWrapper;
 import cgeo.geocaching.utils.UncertainProperty;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+
 import org.apache.commons.collections4.CollectionUtils;
 import org.apache.commons.collections4.Predicate;
 import org.apache.commons.lang3.BooleanUtils;
 import org.apache.commons.lang3.ObjectUtils;
 import org.apache.commons.lang3.StringUtils;
 import org.eclipse.jdt.annotation.Nullable;
+
 import rx.Scheduler;
 import rx.Scheduler.Inner;
 import rx.Subscription;
@@ -177,7 +179,7 @@ public class Geocache implements ICache, IWaypoint {
      *
      * @param gpxParser
      */
-    public Geocache(@SuppressWarnings("unused") GPXParser gpxParser) {
+    public Geocache(GPXParser gpxParser) {
         setReliableLatLon(true);
         setAttributes(Collections.<String> emptyList());
         setWaypoints(Collections.<Waypoint> emptyList(), false);
diff --git a/main/src/cgeo/geocaching/MainActivity.java b/main/src/cgeo/geocaching/MainActivity.java
index b82614b..373f32a 100644
--- a/main/src/cgeo/geocaching/MainActivity.java
+++ b/main/src/cgeo/geocaching/MainActivity.java
@@ -26,7 +26,9 @@ import cgeo.geocaching.utils.Version;
 
 import com.google.zxing.integration.android.IntentIntegrator;
 import com.google.zxing.integration.android.IntentResult;
+
 import org.apache.commons.lang3.StringUtils;
+
 import rx.Observable;
 import rx.Observable.OnSubscribe;
 import rx.Subscriber;
@@ -569,7 +571,7 @@ public class MainActivity extends AbstractActivity {
      * @param v
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void cgeoFindOnMap(@SuppressWarnings("unused") final View v) {
+    public void cgeoFindOnMap(final View v) {
         findOnMap.setPressed(true);
         CGeoMap.startActivityLiveMap(this);
     }
@@ -578,7 +580,7 @@ public class MainActivity extends AbstractActivity {
      * @param v
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void cgeoFindNearest(@SuppressWarnings("unused") final View v) {
+    public void cgeoFindNearest(final View v) {
         if (app.currentGeo().getCoords() == null) {
             return;
         }
@@ -591,7 +593,7 @@ public class MainActivity extends AbstractActivity {
      * @param v
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void cgeoFindByOffline(@SuppressWarnings("unused") final View v) {
+    public void cgeoFindByOffline(final View v) {
         findByOffline.setPressed(true);
         CacheListActivity.startActivityOffline(this);
     }
@@ -600,7 +602,7 @@ public class MainActivity extends AbstractActivity {
      * @param v
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void cgeoSearch(@SuppressWarnings("unused") final View v) {
+    public void cgeoSearch(final View v) {
         advanced.setPressed(true);
         startActivity(new Intent(this, SearchActivity.class));
     }
@@ -609,7 +611,7 @@ public class MainActivity extends AbstractActivity {
      * @param v
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void cgeoPoint(@SuppressWarnings("unused") final View v) {
+    public void cgeoPoint(final View v) {
         any.setPressed(true);
         startActivity(new Intent(this, NavigateAnyPointActivity.class));
     }
@@ -618,7 +620,7 @@ public class MainActivity extends AbstractActivity {
      * @param v
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void cgeoFilter(@SuppressWarnings("unused") final View v) {
+    public void cgeoFilter(final View v) {
         filter.setPressed(true);
         filter.performClick();
     }
@@ -627,7 +629,7 @@ public class MainActivity extends AbstractActivity {
      * @param v
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void cgeoNavSettings(@SuppressWarnings("unused") final View v) {
+    public void cgeoNavSettings(final View v) {
         startActivity(new Intent(android.provider.Settings.ACTION_LOCATION_SOURCE_SETTINGS));
     }
 
@@ -708,7 +710,7 @@ public class MainActivity extends AbstractActivity {
      * @param view
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void showAbout(@SuppressWarnings("unused") final View view) {
+    public void showAbout(final View view) {
         startActivity(new Intent(this, AboutActivity.class));
     }
 
@@ -716,7 +718,7 @@ public class MainActivity extends AbstractActivity {
      * @param view
      *            unused here but needed since this method is referenced from XML layout
      */
-    public void goSearch(@SuppressWarnings("unused") final View view) {
+    public void goSearch(final View view) {
         onSearchRequested();
     }
 
diff --git a/main/src/cgeo/geocaching/sensors/GeoDirHandler.java b/main/src/cgeo/geocaching/sensors/GeoDirHandler.java
index c10cb48..0f30142 100644
--- a/main/src/cgeo/geocaching/sensors/GeoDirHandler.java
+++ b/main/src/cgeo/geocaching/sensors/GeoDirHandler.java
@@ -4,6 +4,7 @@ import cgeo.geocaching.CgeoApplication;
 import cgeo.geocaching.settings.Settings;
 
 import org.apache.commons.lang3.tuple.ImmutablePair;
+
 import rx.Observable;
 import rx.Subscription;
 import rx.android.schedulers.AndroidSchedulers;
@@ -37,7 +38,7 @@ public abstract class GeoDirHandler {
      *
      * @param geoData the new geographical data
      */
-    public void updateGeoData(@SuppressWarnings("unused") final IGeoData geoData) {
+    public void updateGeoData(final IGeoData geoData) {
     }
 
     /**
@@ -46,7 +47,7 @@ public abstract class GeoDirHandler {
      *
      * @param direction the new direction
      */
-    public void updateDirection(@SuppressWarnings("unused") final float direction) {
+    public void updateDirection(final float direction) {
     }
 
     /**
@@ -59,7 +60,7 @@ public abstract class GeoDirHandler {
      * If the device goes fast enough, or if the compass use is not enabled in the settings,
      * the GPS direction information will be used instead of the compass one.
      */
-    public void updateGeoDir(@SuppressWarnings("unused") final IGeoData geoData, @SuppressWarnings("unused") final float direction) {
+    public void updateGeoDir(final IGeoData geoData, final float direction) {
     }
 
     private static Observable<Float> fixedDirection() {