aboutsummaryrefslogtreecommitdiffstats
path: root/main/src
diff options
context:
space:
mode:
authorSamuel Tardieu <sam@rfc1149.net>2013-01-10 11:24:58 +0100
committerSamuel Tardieu <sam@rfc1149.net>2013-01-10 11:24:58 +0100
commitc1d59fe48187f50c5b2c6d7ae6ceadd28a0d0e14 (patch)
treea1c843b98619fc082dbd3a6f5066b8a595818f50 /main/src
parent51380614b1c9b5c79cd90ca9eb072bc771dfc7af (diff)
downloadcgeo-c1d59fe48187f50c5b2c6d7ae6ceadd28a0d0e14.zip
cgeo-c1d59fe48187f50c5b2c6d7ae6ceadd28a0d0e14.tar.gz
cgeo-c1d59fe48187f50c5b2c6d7ae6ceadd28a0d0e14.tar.bz2
Do not depend on mapsforge in non-maps related classes
This feels like an inversion of dependencies to depend on mapsforge in non-maps related classes. As closeQuietly() is useful, we can import it into our utility class without requiring this dependency.
Diffstat (limited to 'main/src')
-rw-r--r--main/src/cgeo/geocaching/ImagesActivity.java1
-rw-r--r--main/src/cgeo/geocaching/export/FieldnoteExport.java6
-rw-r--r--main/src/cgeo/geocaching/files/FileList.java2
-rw-r--r--main/src/cgeo/geocaching/ui/ImagesList.java2
-rw-r--r--main/src/cgeo/geocaching/utils/IOUtils.java20
5 files changed, 25 insertions, 6 deletions
diff --git a/main/src/cgeo/geocaching/ImagesActivity.java b/main/src/cgeo/geocaching/ImagesActivity.java
index 71be14c..24f699e 100644
--- a/main/src/cgeo/geocaching/ImagesActivity.java
+++ b/main/src/cgeo/geocaching/ImagesActivity.java
@@ -28,7 +28,6 @@ public class ImagesActivity extends AbstractActivity {
private ImagesList imagesList;
private ImageType imgType = ImageType.SpoilerImages;
-
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
diff --git a/main/src/cgeo/geocaching/export/FieldnoteExport.java b/main/src/cgeo/geocaching/export/FieldnoteExport.java
index 65dc291..de78c22 100644
--- a/main/src/cgeo/geocaching/export/FieldnoteExport.java
+++ b/main/src/cgeo/geocaching/export/FieldnoteExport.java
@@ -2,19 +2,19 @@ package cgeo.geocaching.export;
import cgeo.geocaching.LogEntry;
import cgeo.geocaching.R;
-import cgeo.geocaching.cgCache;
-import cgeo.geocaching.cgData;
import cgeo.geocaching.activity.ActivityMixin;
import cgeo.geocaching.activity.Progress;
+import cgeo.geocaching.cgCache;
+import cgeo.geocaching.cgData;
import cgeo.geocaching.connector.gc.Login;
import cgeo.geocaching.enumerations.StatusCode;
import cgeo.geocaching.network.Network;
import cgeo.geocaching.network.Parameters;
+import cgeo.geocaching.utils.IOUtils;
import cgeo.geocaching.utils.Log;
import org.apache.commons.lang3.CharEncoding;
import org.apache.commons.lang3.StringUtils;
-import org.mapsforge.core.IOUtils;
import android.app.Activity;
import android.app.AlertDialog;
diff --git a/main/src/cgeo/geocaching/files/FileList.java b/main/src/cgeo/geocaching/files/FileList.java
index 990d2ae..2446834 100644
--- a/main/src/cgeo/geocaching/files/FileList.java
+++ b/main/src/cgeo/geocaching/files/FileList.java
@@ -4,11 +4,11 @@ import cgeo.geocaching.R;
import cgeo.geocaching.StoredList;
import cgeo.geocaching.activity.AbstractListActivity;
import cgeo.geocaching.utils.FileUtils;
+import cgeo.geocaching.utils.IOUtils;
import cgeo.geocaching.utils.Log;
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.lang3.StringUtils;
-import org.mapsforge.core.IOUtils;
import android.app.ProgressDialog;
import android.content.DialogInterface;
diff --git a/main/src/cgeo/geocaching/ui/ImagesList.java b/main/src/cgeo/geocaching/ui/ImagesList.java
index e3332a0..00543df 100644
--- a/main/src/cgeo/geocaching/ui/ImagesList.java
+++ b/main/src/cgeo/geocaching/ui/ImagesList.java
@@ -5,10 +5,10 @@ import cgeo.geocaching.R;
import cgeo.geocaching.StoredList;
import cgeo.geocaching.files.LocalStorage;
import cgeo.geocaching.network.HtmlImage;
+import cgeo.geocaching.utils.IOUtils;
import cgeo.geocaching.utils.Log;
import org.apache.commons.lang3.StringUtils;
-import org.mapsforge.core.IOUtils;
import android.app.Activity;
import android.app.ProgressDialog;
diff --git a/main/src/cgeo/geocaching/utils/IOUtils.java b/main/src/cgeo/geocaching/utils/IOUtils.java
new file mode 100644
index 0000000..73db12f
--- /dev/null
+++ b/main/src/cgeo/geocaching/utils/IOUtils.java
@@ -0,0 +1,20 @@
+package cgeo.geocaching.utils;
+
+import java.io.Closeable;
+import java.io.IOException;
+
+final public class IOUtils {
+
+ private IOUtils() {}
+
+ public static void closeQuietly(final Closeable closeable) {
+ if (closeable != null) {
+ try {
+ closeable.close();
+ } catch (final IOException e) {
+ Log.w("closeQuietly: unable to close " + closeable, e);
+ }
+ }
+ }
+
+}