Refactoring: remove redundant initializers

The initial values were never used as the variables are set in any case
before being used.

25 files changed, 50 insertions, 50 deletions

diff --git a/main/src/cgeo/geocaching/CacheDetailActivity.java b/main/src/cgeo/geocaching/CacheDetailActivity.java
index ab660dc..fc92d28 100644
--- a/main/src/cgeo/geocaching/CacheDetailActivity.java
+++ b/main/src/cgeo/geocaching/CacheDetailActivity.java
@@ -1781,7 +1781,7 @@ public class CacheDetailActivity extends AbstractActivity {
             if (cache.getListId() >= StoredList.STANDARD_LIST_ID) {
                 long diff = (System.currentTimeMillis() / (60 * 1000)) - (cache.getDetailedUpdate() / (60 * 1000)); // minutes
 
-                String ago = "";
+                String ago;
                 if (diff < 15) {
                     ago = res.getString(R.string.cache_offline_time_mins_few);
                 } else if (diff < 50) {
diff --git a/main/src/cgeo/geocaching/StaticMapsProvider.java b/main/src/cgeo/geocaching/StaticMapsProvider.java
index 2ae54b5..9fbf429 100644
--- a/main/src/cgeo/geocaching/StaticMapsProvider.java
+++ b/main/src/cgeo/geocaching/StaticMapsProvider.java
@@ -137,7 +137,7 @@ public class StaticMapsProvider {
     private static int guessMinDisplaySide(Display display) {
         final int maxWidth = display.getWidth() - 25;
         final int maxHeight = display.getHeight() - 25;
-        int edge = 0;
+        int edge;
         if (maxWidth > maxHeight) {
             edge = maxWidth;
         } else {
diff --git a/main/src/cgeo/geocaching/VisitCacheActivity.java b/main/src/cgeo/geocaching/VisitCacheActivity.java
index 342f19d..8221218 100644
--- a/main/src/cgeo/geocaching/VisitCacheActivity.java
+++ b/main/src/cgeo/geocaching/VisitCacheActivity.java
@@ -295,7 +295,7 @@ public class VisitCacheActivity extends AbstractActivity implements DateDialog.D
 
     @Override
     public boolean onCreateOptionsMenu(Menu menu) {
-        SubMenu menuLog = null;
+        SubMenu menuLog;
 
         menuLog = menu.addSubMenu(0, 0, 0, res.getString(R.string.log_add)).setIcon(android.R.drawable.ic_menu_add);
         for (LogTemplate template : LogTemplateProvider.getTemplates()) {
diff --git a/main/src/cgeo/geocaching/cgData.java b/main/src/cgeo/geocaching/cgData.java
index 468dbfa..fd90a02 100644
--- a/main/src/cgeo/geocaching/cgData.java
+++ b/main/src/cgeo/geocaching/cgData.java
@@ -751,7 +751,7 @@ public class cgData {
                     "100");
 
             if (cursor != null) {
-                int index = 0;
+                int index;
 
                 if (cursor.getCount() > 0) {
                     cursor.moveToFirst();
@@ -812,7 +812,7 @@ public class cgData {
             }
 
             if (cursor != null) {
-                int index = 0;
+                int index;
                 cnt = cursor.getCount();
 
                 if (cnt > 0) {
@@ -863,7 +863,7 @@ public class cgData {
     public boolean isOffline(String geocode, String guid) {
         init();
 
-        Cursor cursor = null;
+        Cursor cursor;
         long listId = StoredList.TEMPORARY_LIST_ID;
 
         try {
@@ -893,7 +893,7 @@ public class cgData {
 
             if (cursor != null) {
                 final int cnt = cursor.getCount();
-                int index = 0;
+                int index;
 
                 if (cnt > 0) {
                     cursor.moveToFirst();
@@ -2100,8 +2100,8 @@ public class cgData {
         }
         init();
 
-        String listSql = null;
-        String listSqlW = null;
+        String listSql;
+        String listSqlW;
         if (list == 0) {
             listSql = " where reason >= 1";
             listSqlW = " and reason >= 1";
@@ -2114,7 +2114,7 @@ public class cgData {
 
         int count = 0;
         try {
-            String sql = "select count(_id) from " + dbTableCaches; // this default is not used, but we like to have variables initialized
+            String sql; // this default is not used, but we like to have variables initialized
             if (!detailedOnly) {
                 if (cacheType == CacheType.ALL) {
                     sql = "select count(_id) from " + dbTableCaches + listSql;
@@ -2367,7 +2367,7 @@ public class cgData {
 
         Log.d("Database clean: started");
 
-        Cursor cursor = null;
+        Cursor cursor;
         Set<String> geocodes = new HashSet<String>();
 
         try {
diff --git a/main/src/cgeo/geocaching/cgeoimages.java b/main/src/cgeo/geocaching/cgeoimages.java
index d46cbb4..7145d59 100644
--- a/main/src/cgeo/geocaching/cgeoimages.java
+++ b/main/src/cgeo/geocaching/cgeoimages.java
@@ -67,7 +67,7 @@ public class cgeoimages extends AbstractActivity {
         progressDialog.setMax(count);
         progressDialog.show();
 
-        LinearLayout rowView = null;
+        LinearLayout rowView;
         for (final cgImage img : images) {
             rowView = (LinearLayout) inflater.inflate(R.layout.cache_image_item, null);
 
diff --git a/main/src/cgeo/geocaching/cgeoinit.java b/main/src/cgeo/geocaching/cgeoinit.java
index a5c7854..0aeed10 100644
--- a/main/src/cgeo/geocaching/cgeoinit.java
+++ b/main/src/cgeo/geocaching/cgeoinit.java
@@ -175,7 +175,7 @@ public class cgeoinit extends AbstractActivity {
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == 0) {
-            boolean status = false;
+            boolean status;
 
             ((EditText) findViewById(R.id.username)).setText("");
             ((EditText) findViewById(R.id.password)).setText("");
diff --git a/main/src/cgeo/geocaching/cgeonavigate.java b/main/src/cgeo/geocaching/cgeonavigate.java
index 89c2820..9e903b6 100644
--- a/main/src/cgeo/geocaching/cgeonavigate.java
+++ b/main/src/cgeo/geocaching/cgeonavigate.java
@@ -289,7 +289,7 @@ public class cgeonavigate extends AbstractActivity implements IObserver<IGeoData
             }
 
             if (geo.getCoords() != null) {
-                String satellites = null;
+                String satellites;
                 if (geo.getSatellitesFixed() > 0) {
                     satellites = res.getString(R.string.loc_sat) + ": " + geo.getSatellitesFixed() + "/" + geo.getSatellitesVisible();
                 } else if (geo.getSatellitesVisible() >= 0) {
diff --git a/main/src/cgeo/geocaching/cgeopoint.java b/main/src/cgeo/geocaching/cgeopoint.java
index 805b2cc..e85b27d 100644
--- a/main/src/cgeo/geocaching/cgeopoint.java
+++ b/main/src/cgeo/geocaching/cgeopoint.java
@@ -495,8 +495,8 @@ public class cgeopoint extends AbstractActivity implements IObserver<IGeoData> {
     }
 
     private Geopoint getDestination() {
-        Geopoint result = null;
-        Geopoint coords = null;
+        Geopoint result;
+        Geopoint coords;
 
         String bearingText = ((EditText) findViewById(R.id.bearing)).getText().toString();
         // combine distance from EditText and distanceUnit saved from Spinner
@@ -528,7 +528,7 @@ public class cgeopoint extends AbstractActivity implements IObserver<IGeoData> {
 
         if (StringUtils.isNotBlank(bearingText) && StringUtils.isNotBlank(distanceText)) {
             // bearing & distance
-            double bearing = 0;
+            double bearing;
             try {
                 bearing = Double.parseDouble(bearingText);
             } catch (NumberFormatException e) {
diff --git a/main/src/cgeo/geocaching/cgeopopup.java b/main/src/cgeo/geocaching/cgeopopup.java
index d2ff14f..20c4702 100644
--- a/main/src/cgeo/geocaching/cgeopopup.java
+++ b/main/src/cgeo/geocaching/cgeopopup.java
@@ -427,7 +427,7 @@ public class cgeopopup extends AbstractActivity {
             if (cache.getListId() > 0) {
                 long diff = (System.currentTimeMillis() / (60 * 1000)) - (cache.getDetailedUpdate() / (60 * 1000)); // minutes
 
-                String ago = "";
+                String ago;
                 if (diff < 15) {
                     ago = res.getString(R.string.cache_offline_time_mins_few);
                 } else if (diff < 50) {
diff --git a/main/src/cgeo/geocaching/cgeotouch.java b/main/src/cgeo/geocaching/cgeotouch.java
index 8e6be36..d7438ce 100644
--- a/main/src/cgeo/geocaching/cgeotouch.java
+++ b/main/src/cgeo/geocaching/cgeotouch.java
@@ -193,10 +193,10 @@ public class cgeotouch extends AbstractActivity implements DateDialog.DateDialog
     public boolean onOptionsItemSelected(MenuItem item) {
         int id = item.getItemId();
 
-        EditText text = null;
-        String textContent = null;
-        String dateString = null;
-        String timeString = null;
+        EditText text;
+        String textContent;
+        String dateString;
+        String timeString;
         String addText = "";
 
         if ((id >= 0x1 && id <= 0x7)) {
diff --git a/main/src/cgeo/geocaching/cgeotrackable.java b/main/src/cgeo/geocaching/cgeotrackable.java
index 41a22cc..7078200 100644
--- a/main/src/cgeo/geocaching/cgeotrackable.java
+++ b/main/src/cgeo/geocaching/cgeotrackable.java
@@ -88,7 +88,7 @@ public class cgeotrackable extends AbstractActivity {
                 addDetail(R.string.trackable_name, StringUtils.isNotBlank(trackable.getName()) ? Html.fromHtml(trackable.getName()).toString() : res.getString(R.string.trackable_unknown));
 
                 // trackable type
-                String tbType = null;
+                String tbType;
                 if (StringUtils.isNotBlank(trackable.getType())) {
                     tbType = Html.fromHtml(trackable.getType()).toString();
                 } else {
@@ -111,7 +111,7 @@ public class cgeotrackable extends AbstractActivity {
                         trackable.getSpottedType() == cgTrackable.SPOTTED_UNKNOWN ||
                         trackable.getSpottedType() == cgTrackable.SPOTTED_OWNER
                 ) {
-                    String text = null;
+                    String text;
 
                     if (trackable.getSpottedType() == cgTrackable.SPOTTED_CACHE) {
                         text = res.getString(R.string.trackable_spotted_in_cache) + " " + Html.fromHtml(trackable.getSpottedName()).toString();
@@ -207,7 +207,7 @@ public class cgeotrackable extends AbstractActivity {
 
                         @Override
                         public void run() {
-                            BitmapDrawable image = null;
+                            BitmapDrawable image;
                             try {
                                 HtmlImage imgGetter = new HtmlImage(cgeotrackable.this, geocode, true, 0, false);
 
@@ -555,7 +555,7 @@ public class cgeotrackable extends AbstractActivity {
                 return;
             }
 
-            BitmapDrawable image = null;
+            BitmapDrawable image;
             try {
                 HtmlImage imgGetter = new HtmlImage(cgeotrackable.this, trackable.getGeocode(), false, 0, false);
 
diff --git a/main/src/cgeo/geocaching/cgeowaypointadd.java b/main/src/cgeo/geocaching/cgeowaypointadd.java
index 865a107..9c02eef 100644
--- a/main/src/cgeo/geocaching/cgeowaypointadd.java
+++ b/main/src/cgeo/geocaching/cgeowaypointadd.java
@@ -367,7 +367,7 @@ public class cgeowaypointadd extends AbstractActivity implements IObserver<IGeoD
 
             if (StringUtils.isNotBlank(bearingText) && StringUtils.isNotBlank(distanceText)) {
                 // bearing & distance
-                double bearing = 0;
+                double bearing;
                 try {
                     bearing = Double.parseDouble(bearingText);
                 } catch (NumberFormatException e) {
diff --git a/main/src/cgeo/geocaching/connector/gc/GCParser.java b/main/src/cgeo/geocaching/connector/gc/GCParser.java
index 0e5221c..e0cb70f 100644
--- a/main/src/cgeo/geocaching/connector/gc/GCParser.java
+++ b/main/src/cgeo/geocaching/connector/gc/GCParser.java
@@ -627,8 +627,8 @@ public abstract class GCParser {
         }
 
         // waypoints
-        int wpBegin = 0;
-        int wpEnd = 0;
+        int wpBegin;
+        int wpEnd;
 
         wpBegin = page.indexOf("<table class=\"Table\" id=\"ctl00_ContentBody_Waypoints\">");
         if (wpBegin != -1) { // parse waypoints
@@ -991,7 +991,7 @@ public abstract class GCParser {
                     final StringBuilder hdnSelected = new StringBuilder();
 
                     for (TrackableLog tb : trackables) {
-                        String ctl = null;
+                        String ctl;
                         final String action = Integer.toString(tb.id) + tb.action.action;
 
                         if (tb.ctl < 10) {
@@ -1350,7 +1350,7 @@ public abstract class GCParser {
      *            retrieve friend logs
      */
     private static List<LogEntry> loadLogsFromDetails(final String page, final cgCache cache, final boolean friends, final boolean getDataFromPage) {
-        String rawResponse = null;
+        String rawResponse;
 
         if (!getDataFromPage) {
             final Matcher userTokenMatcher = GCConstants.PATTERN_USERTOKEN2.matcher(page);
diff --git a/main/src/cgeo/geocaching/export/FieldnoteExport.java b/main/src/cgeo/geocaching/export/FieldnoteExport.java
index 50cc620..babc4b6 100644
--- a/main/src/cgeo/geocaching/export/FieldnoteExport.java
+++ b/main/src/cgeo/geocaching/export/FieldnoteExport.java
@@ -169,7 +169,7 @@ class FieldnoteExport extends AbstractExport {
                 SimpleDateFormat fileNameDateFormat = new SimpleDateFormat("yyyyMMddHHmmss");
                 exportFile = new File(exportLocation.toString() + '/' + fileNameDateFormat.format(new Date()) + ".txt");
 
-                OutputStream os = null;
+                OutputStream os;
                 Writer fw = null;
                 try {
                     os = new FileOutputStream(exportFile);
diff --git a/main/src/cgeo/geocaching/files/FileParser.java b/main/src/cgeo/geocaching/files/FileParser.java
index 20e757c..090573a 100644
--- a/main/src/cgeo/geocaching/files/FileParser.java
+++ b/main/src/cgeo/geocaching/files/FileParser.java
@@ -52,7 +52,7 @@ public abstract class FileParser {
         final BufferedReader input = new BufferedReader(new InputStreamReader(progressInputStream));
 
         try {
-            String line = null;
+            String line;
             while ((line = input.readLine()) != null) {
                 buffer.append(line);
                 showProgressMessage(progressHandler, progressInputStream.getProgress());
diff --git a/main/src/cgeo/geocaching/files/GPXParser.java b/main/src/cgeo/geocaching/files/GPXParser.java
index 8a405fc..7870a16 100644
--- a/main/src/cgeo/geocaching/files/GPXParser.java
+++ b/main/src/cgeo/geocaching/files/GPXParser.java
@@ -193,7 +193,7 @@ public abstract class GPXParser extends FileParser {
                 return null; // id not found
             }
             // get text for string
-            String stringName = null;
+            String stringName;
             try {
                 stringName = cgeoapplication.getInstance().getResources().getResourceName(stringId);
             } catch (NullPointerException e) {
diff --git a/main/src/cgeo/geocaching/gcvote/GCVote.java b/main/src/cgeo/geocaching/gcvote/GCVote.java
index c8976b8..5a00009 100644
--- a/main/src/cgeo/geocaching/gcvote/GCVote.java
+++ b/main/src/cgeo/geocaching/gcvote/GCVote.java
@@ -98,7 +98,7 @@ public final class GCVote {
                 return null;
             }
 
-            String voteData = null;
+            String voteData;
             final Matcher matcherVoteElement = patternVoteElement.matcher(page);
             while (matcherVoteElement.find()) {
                 voteData = matcherVoteElement.group(1);
diff --git a/main/src/cgeo/geocaching/maps/CGeoMap.java b/main/src/cgeo/geocaching/maps/CGeoMap.java
index 4b01540..e81760a 100644
--- a/main/src/cgeo/geocaching/maps/CGeoMap.java
+++ b/main/src/cgeo/geocaching/maps/CGeoMap.java
@@ -1329,7 +1329,7 @@ public class CGeoMap extends AbstractMap implements OnMapDragListener, ViewFacto
             List<OtherCachersOverlayItemImpl> items = new ArrayList<OtherCachersOverlayItemImpl>();
 
             int counter = 0;
-            OtherCachersOverlayItemImpl item = null;
+            OtherCachersOverlayItemImpl item;
 
             for (Go4CacheUser userOne : users) {
                 if (userOne.getCoords() == null) {
diff --git a/main/src/cgeo/geocaching/maps/OtherCachersOverlayItem.java b/main/src/cgeo/geocaching/maps/OtherCachersOverlayItem.java
index d71bbcf..9844e83 100644
--- a/main/src/cgeo/geocaching/maps/OtherCachersOverlayItem.java
+++ b/main/src/cgeo/geocaching/maps/OtherCachersOverlayItem.java
@@ -16,7 +16,7 @@ public class OtherCachersOverlayItem {
     }
 
     public Drawable getMarker() {
-        Drawable marker = null;
+        Drawable marker;
 
         if (user != null && user.getDate() != null && user.getDate().getTime() >= (System.currentTimeMillis() - (20 * 60 * 1000))) {
             marker = context.getResources().getDrawable(R.drawable.user_location_active);
diff --git a/main/src/cgeo/geocaching/maps/PositionOverlay.java b/main/src/cgeo/geocaching/maps/PositionOverlay.java
index ba39cd2..9099498 100644
--- a/main/src/cgeo/geocaching/maps/PositionOverlay.java
+++ b/main/src/cgeo/geocaching/maps/PositionOverlay.java
@@ -150,7 +150,7 @@ public class PositionOverlay implements GeneralOverlay {
         if (Settings.isMapTrail()) {
             int size = history.size();
             if (size > 1) {
-                int alpha = 0;
+                int alpha;
                 int alphaCnt = size - 201;
                 if (alphaCnt < 1) {
                     alphaCnt = 1;
diff --git a/main/src/cgeo/geocaching/ui/CacheListAdapter.java b/main/src/cgeo/geocaching/ui/CacheListAdapter.java
index 1cd05f0..bda53d7 100644
--- a/main/src/cgeo/geocaching/ui/CacheListAdapter.java
+++ b/main/src/cgeo/geocaching/ui/CacheListAdapter.java
@@ -470,7 +470,7 @@ public class CacheListAdapter extends ArrayAdapter<cgCache> {
             holder.inventory.removeAllViews();
         }
 
-        ImageView tbIcon = null;
+        ImageView tbIcon;
         if (cache.getInventoryItems() > 0) {
             tbIcon = (ImageView) inflater.inflate(R.layout.trackable_icon, null);
             tbIcon.setImageResource(R.drawable.trackable_all);
diff --git a/main/src/cgeo/geocaching/ui/CompassMiniView.java b/main/src/cgeo/geocaching/ui/CompassMiniView.java
index 1fa4cfb..b51b7a2 100644
--- a/main/src/cgeo/geocaching/ui/CompassMiniView.java
+++ b/main/src/cgeo/geocaching/ui/CompassMiniView.java
@@ -111,8 +111,8 @@ public class CompassMiniView extends View {
         // compass margins
         canvas.setDrawFilter(setfil);
 
-        int marginLeft = 0;
-        int marginTop = 0;
+        int marginLeft;
+        int marginTop;
 
         int compassArrowWidth = compassArrow.getWidth();
         int compassArrowHeight = compassArrow.getWidth();
@@ -136,7 +136,7 @@ public class CompassMiniView extends View {
     }
 
     private int measureWidth(int measureSpec) {
-        int result = 0;
+        int result;
         int specMode = MeasureSpec.getMode(measureSpec);
         int specSize = MeasureSpec.getSize(measureSpec);
 
@@ -154,7 +154,7 @@ public class CompassMiniView extends View {
     }
 
     private int measureHeight(int measureSpec) {
-        int result = 0;
+        int result;
         int specMode = MeasureSpec.getMode(measureSpec);
         int specSize = MeasureSpec.getSize(measureSpec);
 
diff --git a/main/src/cgeo/geocaching/ui/CompassView.java b/main/src/cgeo/geocaching/ui/CompassView.java
index f9fb569..8a295c3 100644
--- a/main/src/cgeo/geocaching/ui/CompassView.java
+++ b/main/src/cgeo/geocaching/ui/CompassView.java
@@ -209,8 +209,8 @@ public class CompassView extends View {
         int canvasCenterX = (compassRoseWidth / 2) + ((getWidth() - compassRoseWidth) / 2);
         int canvasCenterY = (compassRoseHeight / 2) + ((getHeight() - compassRoseHeight) / 2);
 
-        int marginLeftTemp = 0;
-        int marginTopTemp = 0;
+        int marginLeftTemp;
+        int marginTopTemp;
 
         super.onDraw(canvas);
 
@@ -251,7 +251,7 @@ public class CompassView extends View {
     }
 
     private int measureWidth(int measureSpec) {
-        int result = 0;
+        int result;
         int specMode = MeasureSpec.getMode(measureSpec);
         int specSize = MeasureSpec.getSize(measureSpec);
 
@@ -269,7 +269,7 @@ public class CompassView extends View {
     }
 
     private int measureHeight(int measureSpec) {
-        int result = 0;
+        int result;
         int specMode = MeasureSpec.getMode(measureSpec);
         int specSize = MeasureSpec.getSize(measureSpec);
 
diff --git a/main/src/cgeo/geocaching/ui/GPXListAdapter.java b/main/src/cgeo/geocaching/ui/GPXListAdapter.java
index c62fa8c..76dc10e 100644
--- a/main/src/cgeo/geocaching/ui/GPXListAdapter.java
+++ b/main/src/cgeo/geocaching/ui/GPXListAdapter.java
@@ -39,7 +39,7 @@ public class GPXListAdapter extends ArrayAdapter<File> {
         final File file = getItem(position);
 
         View v = rowView;
-        GPXListView holder = null;
+        GPXListView holder;
 
         if (v == null) {
             v = inflater.inflate(R.layout.gpx_item, null);
diff --git a/main/src/com/viewpagerindicator/TitlePageIndicator.java b/main/src/com/viewpagerindicator/TitlePageIndicator.java
index 248a96f..a181fed 100644
--- a/main/src/com/viewpagerindicator/TitlePageIndicator.java
+++ b/main/src/com/viewpagerindicator/TitlePageIndicator.java
@@ -686,7 +686,7 @@ public class TitlePageIndicator extends View implements PageIndicator {
      * @return The width of the view, honoring constraints from measureSpec
      */
     private int measureWidth(int measureSpec) {
-        int result = 0;
+        int result;
         int specMode = MeasureSpec.getMode(measureSpec);
         int specSize = MeasureSpec.getSize(measureSpec);
 
@@ -705,7 +705,7 @@ public class TitlePageIndicator extends View implements PageIndicator {
      * @return The height of the view, honoring constraints from measureSpec
      */
     private int measureHeight(int measureSpec) {
-        float result = 0;
+        float result;
         int specMode = MeasureSpec.getMode(measureSpec);
         int specSize = MeasureSpec.getSize(measureSpec);