cleanup: downgrade unnecessary fields

3 files changed, 3 insertions, 7 deletions

diff --git a/main/src/cgeo/geocaching/connector/oc/OCAuthorizationActivity.java b/main/src/cgeo/geocaching/connector/oc/OCAuthorizationActivity.java
index ed544be..08d796e 100644
--- a/main/src/cgeo/geocaching/connector/oc/OCAuthorizationActivity.java
+++ b/main/src/cgeo/geocaching/connector/oc/OCAuthorizationActivity.java
@@ -9,8 +9,6 @@ import org.apache.commons.lang3.tuple.ImmutablePair;
 
 public class OCAuthorizationActivity extends OAuthAuthorizationActivity {
 
-    private final int siteResId = R.string.auth_ocde;
-
     public OCAuthorizationActivity() {
         super("www.opencaching.de",
                 "/okapi/services/oauth/request_token",
@@ -38,7 +36,7 @@ public class OCAuthorizationActivity extends OAuthAuthorizationActivity {
 
     @Override
     protected String getAuthTitle() {
-        return res.getString(siteResId);
+        return res.getString(R.string.auth_ocde);
     }
 
     @Override
diff --git a/main/src/cgeo/geocaching/settings/Settings.java b/main/src/cgeo/geocaching/settings/Settings.java
index 775b699..08f30af 100644
--- a/main/src/cgeo/geocaching/settings/Settings.java
+++ b/main/src/cgeo/geocaching/settings/Settings.java
@@ -77,7 +77,6 @@ public final class Settings {
 
     // maps
     private static MapProvider mapProvider = null;
-    private static String cacheTwitterMessage = "I found [NAME] ([URL])";
 
     private Settings() {
         // this class is not to be instantiated;
@@ -914,7 +913,7 @@ public final class Settings {
 
     public static String getCacheTwitterMessage() {
         // TODO make customizable from UI
-        return cacheTwitterMessage;
+        return "I found [NAME] ([URL])";
     }
 
     public static String getTrackableTwitterMessage() {
diff --git a/main/src/cgeo/geocaching/ui/EditNoteDialog.java b/main/src/cgeo/geocaching/ui/EditNoteDialog.java
index d121433..9a122e2 100644
--- a/main/src/cgeo/geocaching/ui/EditNoteDialog.java
+++ b/main/src/cgeo/geocaching/ui/EditNoteDialog.java
@@ -20,7 +20,6 @@ public class EditNoteDialog extends DialogFragment {
     public static final String ARGUMENT_INITIAL_NOTE = "initialNote";
 
     private EditText mEditText;
-    private String initialNote;
 
     public static EditNoteDialog newInstance(final String initialNote) {
         EditNoteDialog dialog = new EditNoteDialog();
@@ -37,7 +36,7 @@ public class EditNoteDialog extends DialogFragment {
         LayoutInflater inflater = getActivity().getLayoutInflater();
         View view = inflater.inflate(R.layout.fragment_edit_note, null);
         mEditText = (EditText) view.findViewById(R.id.note);
-        initialNote = getArguments().getString(ARGUMENT_INITIAL_NOTE);
+        String initialNote = getArguments().getString(ARGUMENT_INITIAL_NOTE);
         if (initialNote != null) {
             mEditText.setText(initialNote);
             initialNote = null;