fix #4681: highlight saved log in orange

Also fixes some wrong click handlers.

2 files changed, 9 insertions, 11 deletions

diff --git a/main/src/cgeo/geocaching/ui/logs/CacheLogsViewCreator.java b/main/src/cgeo/geocaching/ui/logs/CacheLogsViewCreator.java
index e52003d..076c412 100644
--- a/main/src/cgeo/geocaching/ui/logs/CacheLogsViewCreator.java
+++ b/main/src/cgeo/geocaching/ui/logs/CacheLogsViewCreator.java
@@ -103,11 +103,11 @@ public class CacheLogsViewCreator extends LogsViewCreator {
     @Override
     protected void fillViewHolder(final View convertView, final LogViewHolder holder, final LogEntry log) {
         super.fillViewHolder(convertView, holder, log);
-        if (null == convertView) {
-            if (isOfflineLog(log)) {
-                holder.author.setOnClickListener(new EditOfflineLogListener(getCache(), cacheDetailActivity));
-                holder.text.setOnClickListener(new EditOfflineLogListener(getCache(), cacheDetailActivity));
-            }
+        if (isOfflineLog(log)) {
+            holder.author.setOnClickListener(new EditOfflineLogListener(getCache(), cacheDetailActivity));
+            holder.text.setOnClickListener(new EditOfflineLogListener(getCache(), cacheDetailActivity));
+            holder.marker.setVisibility(View.VISIBLE);
+            holder.marker.setImageResource(R.drawable.mark_orange);
         }
     }
 
diff --git a/main/src/cgeo/geocaching/ui/logs/LogsViewCreator.java b/main/src/cgeo/geocaching/ui/logs/LogsViewCreator.java
index 3aaeec1..6715c76 100644
--- a/main/src/cgeo/geocaching/ui/logs/LogsViewCreator.java
+++ b/main/src/cgeo/geocaching/ui/logs/LogsViewCreator.java
@@ -116,12 +116,10 @@ public abstract class LogsViewCreator extends AbstractCachingListViewPageViewCre
             holder.marker.setVisibility(View.GONE);
         }
 
-        if (null == convertView) {
-            holder.author.setOnClickListener(createUserActionsListener());
-            holder.text.setMovementMethod(AnchorAwareLinkMovementMethod.getInstance());
-            holder.text.setOnClickListener(new DecryptTextClickListener(holder.text));
-            activity.registerForContextMenu(holder.text);
-        }
+        holder.author.setOnClickListener(createUserActionsListener());
+        holder.text.setMovementMethod(AnchorAwareLinkMovementMethod.getInstance());
+        holder.text.setOnClickListener(new DecryptTextClickListener(holder.text));
+        activity.registerForContextMenu(holder.text);
     }
 
     abstract protected UserActionsClickListener createUserActionsListener();