refactoring: factor out code for cache dropping

4 files changed, 19 insertions, 37 deletions

diff --git a/main/src/cgeo/geocaching/CacheDetailActivity.java b/main/src/cgeo/geocaching/CacheDetailActivity.java
index b125e14..80e1f7b 100644
--- a/main/src/cgeo/geocaching/CacheDetailActivity.java
+++ b/main/src/cgeo/geocaching/CacheDetailActivity.java
@@ -1074,20 +1074,7 @@ public class CacheDetailActivity extends AbstractViewPagerActivity<CacheDetailAc
                 }
 
                 progress.show(CacheDetailActivity.this, res.getString(R.string.cache_dialog_offline_drop_title), res.getString(R.string.cache_dialog_offline_drop_message), true, null);
-                new DropCacheThread(new ChangeNotificationHandler(CacheDetailActivity.this, progress)).start();
-            }
-        }
-
-        private class DropCacheThread extends Thread {
-            private Handler handler;
-
-            public DropCacheThread(Handler handler) {
-                this.handler = handler;
-            }
-
-            @Override
-            public void run() {
-                cache.drop(this.handler);
+                cache.drop(new ChangeNotificationHandler(CacheDetailActivity.this, progress), Schedulers.io());
             }
         }
 
diff --git a/main/src/cgeo/geocaching/CacheListActivity.java b/main/src/cgeo/geocaching/CacheListActivity.java
index 7e45477..51f98ad 100644
--- a/main/src/cgeo/geocaching/CacheListActivity.java
+++ b/main/src/cgeo/geocaching/CacheListActivity.java
@@ -828,7 +828,7 @@ public class CacheListActivity extends AbstractListActivity implements FilteredA
                         adapter.notifyDataSetChanged();
                         refreshCurrentList();
                     }
-                });
+                }, Schedulers.io());
                 break;
             case R.id.menu_move_to_list:
                 new StoredList.UserInterface(this).promptForListSelection(R.string.cache_menu_move_list, new Action1<Integer>() {
diff --git a/main/src/cgeo/geocaching/CachePopup.java b/main/src/cgeo/geocaching/CachePopup.java
index 38c6e65..700b81c 100644
--- a/main/src/cgeo/geocaching/CachePopup.java
+++ b/main/src/cgeo/geocaching/CachePopup.java
@@ -174,20 +174,7 @@ public class CachePopup extends AbstractPopupActivity {
 
             final DropCacheHandler dropCacheHandler = new DropCacheHandler();
             progress.show(CachePopup.this, res.getString(R.string.cache_dialog_offline_drop_title), res.getString(R.string.cache_dialog_offline_drop_message), true, null);
-            new DropCacheThread(dropCacheHandler).start();
-        }
-    }
-
-    private class DropCacheThread extends Thread {
-        final private Handler handler;
-
-        public DropCacheThread(Handler handlerIn) {
-            handler = handlerIn;
-        }
-
-        @Override
-        public void run() {
-            cache.drop(handler);
+            cache.drop(dropCacheHandler, Schedulers.io());
         }
     }
 
diff --git a/main/src/cgeo/geocaching/Geocache.java b/main/src/cgeo/geocaching/Geocache.java
index f3c2ecd..8dde37d 100644
--- a/main/src/cgeo/geocaching/Geocache.java
+++ b/main/src/cgeo/geocaching/Geocache.java
@@ -1445,15 +1445,23 @@ public class Geocache implements ICache, IWaypoint {
         return "cache";
     }
 
-    public void drop(Handler handler) {
-        try {
-            DataStore.markDropped(Collections.singletonList(this));
-            DataStore.removeCache(getGeocode(), EnumSet.of(RemoveFlag.REMOVE_CACHE));
+    public Subscription drop(final Handler handler, final Scheduler scheduler) {
+        return scheduler.schedule(new Action1<Inner>() {
+            @Override
+            public void call(final Inner inner) {
+                try {
+                    dropSynchronous();
+                    handler.sendMessage(Message.obtain());
+                } catch (final Exception e) {
+                    Log.e("cache.drop: ", e);
+                }
+            }
+        });
+    }
 
-            handler.sendMessage(Message.obtain());
-        } catch (final Exception e) {
-            Log.e("cache.drop: ", e);
-        }
+    public void dropSynchronous() {
+        DataStore.markDropped(Collections.singletonList(this));
+        DataStore.removeCache(getGeocode(), EnumSet.of(RemoveFlag.REMOVE_CACHE));
     }
 
     public void checkFields() {