refactoring: more cleanup in connector interfaces

* switch from method overrides to interface detection for connector
features
* remove GCBase and put code into other classes
* reduce GC specific code being used in general activities

1 files changed, 6 insertions, 7 deletions

diff --git a/tests/src/cgeo/geocaching/connector/gc/GCBaseTest.java b/tests/src/cgeo/geocaching/connector/gc/GCBaseTest.java
index 88873a1..91ff2f9 100644
--- a/tests/src/cgeo/geocaching/connector/gc/GCBaseTest.java
+++ b/tests/src/cgeo/geocaching/connector/gc/GCBaseTest.java
@@ -22,20 +22,19 @@ public class GCBaseTest extends TestCase {
     }
 
     private static void assertKey(String key, int x, int y) {
-        UTFGridPosition pos = UTFGridPosition.fromString(key);
+        final UTFGridPosition pos = UTFGridPosition.fromString(key);
         assertEquals(x, pos.getX());
         assertEquals(y, pos.getY());
     }
 
-    public static void testSearchByGeocodes() {
+    public static void testSearchFromMap() {
+        final MockedCache mockedCache = new GC2CJPF();
 
-        MockedCache mockedCache = new GC2CJPF();
-
-        Set<String> geocodes = new HashSet<String>();
+        final Set<String> geocodes = new HashSet<String>();
         geocodes.add(mockedCache.getGeocode());
 
-        SearchResult result = GCBase.searchByGeocodes(geocodes);
-        cgCache parsedCache = result.getFirstCacheFromResult(LoadFlags.LOAD_CACHE_ONLY);
+        final SearchResult result = GCMap.searchByGeocodes(geocodes);
+        final cgCache parsedCache = result.getFirstCacheFromResult(LoadFlags.LOAD_CACHE_ONLY);
 
         Compare.assertCompareCaches(mockedCache, parsedCache, false);