code cleanup: fix Lint warnings about Locales

3 files changed, 13 insertions, 7 deletions

diff --git a/tests/src/cgeo/geocaching/enumerations/CacheSizeTest.java b/tests/src/cgeo/geocaching/enumerations/CacheSizeTest.java
index c872c9d..9c3063d 100644
--- a/tests/src/cgeo/geocaching/enumerations/CacheSizeTest.java
+++ b/tests/src/cgeo/geocaching/enumerations/CacheSizeTest.java
@@ -2,6 +2,8 @@ package cgeo.geocaching.enumerations;
 
 import android.test.AndroidTestCase;
 
+import java.util.Locale;
+
 public class CacheSizeTest extends AndroidTestCase {
 
     public static void testOrder() {
@@ -15,13 +17,14 @@ public class CacheSizeTest extends AndroidTestCase {
         assertEquals(CacheSize.UNKNOWN, CacheSize.getById(null));
         assertEquals(CacheSize.UNKNOWN, CacheSize.getById("random garbage"));
         assertEquals(CacheSize.LARGE, CacheSize.getById("large"));
+        assertEquals(CacheSize.LARGE, CacheSize.getById("LARGE"));
     }
 
     public static void testGetByIdComplete() {
         for (CacheSize size : CacheSize.values()) {
             assertEquals(size, CacheSize.getById(size.id));
-            assertEquals(size, CacheSize.getById(size.id.toLowerCase()));
-            assertEquals(size, CacheSize.getById(size.id.toUpperCase()));
+            assertEquals(size, CacheSize.getById(size.id.toLowerCase(Locale.US)));
+            assertEquals(size, CacheSize.getById(size.id.toUpperCase(Locale.US)));
         }
     }
 }
diff --git a/tests/src/cgeo/geocaching/enumerations/CacheTypeTest.java b/tests/src/cgeo/geocaching/enumerations/CacheTypeTest.java
index dd35669..21e97c0 100644
--- a/tests/src/cgeo/geocaching/enumerations/CacheTypeTest.java
+++ b/tests/src/cgeo/geocaching/enumerations/CacheTypeTest.java
@@ -2,6 +2,8 @@ package cgeo.geocaching.enumerations;
 
 import android.test.AndroidTestCase;
 
+import java.util.Locale;
+
 public class CacheTypeTest extends AndroidTestCase {
 
     public static void testGetById() {
@@ -21,16 +23,16 @@ public class CacheTypeTest extends AndroidTestCase {
     public static void testGetByIdComplete() {
         for (CacheType type : CacheType.values()) {
             assertEquals(type, CacheType.getById(type.id));
-            assertEquals(type, CacheType.getById(type.id.toLowerCase()));
-            assertEquals(type, CacheType.getById(type.id.toUpperCase()));
+            assertEquals(type, CacheType.getById(type.id.toLowerCase(Locale.US)));
+            assertEquals(type, CacheType.getById(type.id.toUpperCase(Locale.US)));
         }
     }
 
     public static void testGetByPatternComplete() {
         for (CacheType type : CacheType.values()) {
             assertEquals(type, CacheType.getByPattern(type.pattern));
-            assertEquals(type, CacheType.getByPattern(type.pattern.toLowerCase()));
-            assertEquals(type, CacheType.getByPattern(type.pattern.toUpperCase()));
+            assertEquals(type, CacheType.getByPattern(type.pattern.toLowerCase(Locale.US)));
+            assertEquals(type, CacheType.getByPattern(type.pattern.toUpperCase(Locale.US)));
         }
     }
 }
diff --git a/tests/src/cgeo/geocaching/enumerations/LogTypeTest.java b/tests/src/cgeo/geocaching/enumerations/LogTypeTest.java
index ce2a37a..d4c8f5e 100644
--- a/tests/src/cgeo/geocaching/enumerations/LogTypeTest.java
+++ b/tests/src/cgeo/geocaching/enumerations/LogTypeTest.java
@@ -19,7 +19,8 @@ public class LogTypeTest extends AndroidTestCase {
     public static void testGetByType() {
         assertEquals(LogType.UNKNOWN, LogType.getByIconName(""));
         assertEquals(LogType.UNKNOWN, LogType.getByIconName(null));
-        assertEquals(LogType.GRABBED_IT, LogType.getByType("grabbed IT "));
+        assertEquals(LogType.GRABBED_IT, LogType.getByType("grabbed it"));
+        assertEquals(LogType.GRABBED_IT, LogType.getByType("  gRAbbed IT "));
     }
 
 }