refactorings

* always use CacheAttribute for attribute strings
* avoid concatenation in append
* use SparseArray instead of maps

1 files changed, 10 insertions, 0 deletions

diff --git a/tests/src/cgeo/geocaching/enumerations/CacheAttributeTest.java b/tests/src/cgeo/geocaching/enumerations/CacheAttributeTest.java
index a15bd17..f369b0e 100644
--- a/tests/src/cgeo/geocaching/enumerations/CacheAttributeTest.java
+++ b/tests/src/cgeo/geocaching/enumerations/CacheAttributeTest.java
@@ -10,4 +10,14 @@ public class CacheAttributeTest extends AndroidTestCase {
             assertTrue("bad attribute name " + rawName, CacheAttribute.trimAttributeName(rawName).equals(rawName));
         }
     }
+
+    public static void testIds() {
+        for (CacheAttribute attribute : CacheAttribute.values()) {
+            if (attribute != CacheAttribute.UNKNOWN) {
+                assertTrue(attribute.drawableId != 0);
+                assertTrue(attribute.stringIdYes != 0);
+                assertTrue(attribute.stringIdNo != 0);
+            }
+        }
+    }
 }